From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kE7RBDaQfF9TcwAA0tVLHw (envelope-from ) for ; Tue, 06 Oct 2020 15:41:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OEbRADaQfF+NFgAAbx9fmQ (envelope-from ) for ; Tue, 06 Oct 2020 15:41:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D2499401D9 for ; Tue, 6 Oct 2020 15:41:41 +0000 (UTC) Received: from localhost ([::1]:33710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPp5u-0001m1-EN for larch@yhetil.org; Tue, 06 Oct 2020 11:41:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPp5N-0001jw-RN for guix-patches@gnu.org; Tue, 06 Oct 2020 11:41:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPp5J-0008An-Tl for guix-patches@gnu.org; Tue, 06 Oct 2020 11:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPp5J-0006RV-Rg for guix-patches@gnu.org; Tue, 06 Oct 2020 11:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43591] [PATCH core-updates] gnu: glibc-final: Catch all cases of a glibc user not requesting 64-bit offsets and then using readdir. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Oct 2020 15:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43591 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43591@debbugs.gnu.org, Marius Bakke Received: via spool by 43591-submit@debbugs.gnu.org id=B43591.160199881224685 (code B ref 43591); Tue, 06 Oct 2020 15:41:01 +0000 Received: (at 43591) by debbugs.gnu.org; 6 Oct 2020 15:40:12 +0000 Received: from localhost ([127.0.0.1]:53942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPp4W-0006Q5-A6 for submit@debbugs.gnu.org; Tue, 06 Oct 2020 11:40:12 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:38786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPp4U-0006Pv-2M for 43591@debbugs.gnu.org; Tue, 06 Oct 2020 11:40:10 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 73BBA336559F; Tue, 6 Oct 2020 17:40:08 +0200 (CEST) Date: Tue, 6 Oct 2020 17:39:32 +0200 From: Danny Milosavljevic Message-ID: <20201006173932.08003c1d@scratchpost.org> In-Reply-To: <87o8lmv2nx.fsf@gnu.org> References: <20200924141211.21649-1-dannym@scratchpost.org> <87363759at.fsf@gnu.org> <20200924222711.2f22281a@scratchpost.org> <87tuvm4vop.fsf@gnu.org> <87h7rg4879.fsf@gnu.org> <20200930000934.6812b7c8@scratchpost.org> <87tuvf1uet.fsf@gnu.org> <20200930122821.1471d155@scratchpost.org> <87o8lmv2nx.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/440vdPmj4AYN3Vex.7rjJ/C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: 7bxazCC3I2yA --Sig_/440vdPmj4AYN3Vex.7rjJ/C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Thu, 01 Oct 2020 09:14:10 +0200 Ludovic Court=C3=A8s wrote: > Could you propose a patch for maintenance.git? OK--patch #43829. > >> I have mixed feelings: fixing packages one by one doesn=E2=80=99t soun= d great, > >> but OTOH setting the =E2=80=98CFLAGS=E2=80=99 environment variable glo= bally can have > >> unexpected side effects in some cases (overriding package-specific > >> CFLAGS)=20 Doing (setenv CFLAGS "-g -O2 -D_FILE_OFFSET_BITS=3D64") right after phase 'set-SOURCE-DATE-EPOCH doesn't override package-specific CFLAGS. Quite the opposite can happen, though. But: > > The latter is easy to detect since I patched dirent.h in glibc exactly = for that > > reason. That way, glibc WON'T let you use it wrong (except if you expl= icitly > > ask for it). On Guix systems, there is no legitimate reason to use it = wrong > > in the first place. =20 >=20 > I=E2=80=99m very reluctant to patching public libc headers. Also, it=E2= =80=99s not just > =E2=80=9Cour=E2=80=9D problem, we should definitely discuss it with upstr= eam and perhaps > propose your dirent.h patch. I've reported it upstream. However, GNU gcc and glibc support a lot of weird architectures--but Guix system really doesn't. So it's much easier for us to get a good patch than it is for them. > A diff at one point in time (if we ever managed to get a usable diff) is > not enough: problems could pop up anytime. Setting =E2=80=98CFLAGS=E2=80= =99 globally as > an environment variable seems risky. We are about 15 years late--so all other distributions already triggered most of the bugs in that time. I don't think it's that bad anymore... That's why I would prefer setting CFLAGS globally anyway. And I don't have the energy to manually FIND AND fix however many packages are affected otherwise. Having this problem in 2020 is ridiculous--it's like someone accidentially enabled a time machine... The only reason this didn't fall on our head on x86_64 is because on 64 bit systems something like it is the default anyway. --Sig_/440vdPmj4AYN3Vex.7rjJ/C Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl98j7QACgkQ5xo1VCww uqUvrgf+IotLG5H1B4fcZhvssJhkOrqpzLJmq4n7YnaYiMuUmxAV94jLvyjHWz66 Ab9zW0EFg8eKpR7GpvXI3J35aPUk+aHUb6frhkbp7ky6ItN6IfJYpyNyHJZv3eb4 bmdRAe6uW2a/09oH/Zhtji1cI9CH2tMudfWGfhNUZJwXeM2ZE99HDr4vsSeu0gYu wEwJMxBdRwnITYofQBbPxnbYGipzLObAErew5zMSpoC4RXPHWbUsNGgkuSlnpSLu /nUeWfJNkqOLHUj8vsemTyHw+kZ5qVsaKqOpEfjLuqK5ebx65XoDmAezcHwV05d4 4L/P5clGSvZ2ZfD+V1SPGD/b2af7Dg== =gZXy -----END PGP SIGNATURE----- --Sig_/440vdPmj4AYN3Vex.7rjJ/C--