From: Danny Milosavljevic <dannym@scratchpost.org>
To: Stefan <stefan-guix@vodafonemail.de>
Cc: 41011@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP.
Date: Sat, 26 Sep 2020 18:13:57 +0200 [thread overview]
Message-ID: <20200926181357.1aa2faa4@scratchpost.org> (raw)
In-Reply-To: <066A5D57-B0B1-4FF4-B07B-1A5030AA789F@vodafonemail.de>
[-- Attachment #1: Type: text/plain, Size: 2726 bytes --]
Hi Stefan,
I think this is almost ready to be merged.
There's still one thing I'm unclear about.
I tested it this way:
(1) create ~/config.scm with the following contents:
(use-modules (gnu))
(operating-system
(timezone "UTC")
(bootloader
(bootloader-configuration
(bootloader grub-efi-netboot-bootloader)
(target "/boot")))
(file-systems
(cons* (file-system
(mount-point "/")
(device ":/foo")
(type "nfs"))
%base-file-systems))
(host-name "client1"))
(2) mkdir ~/tf
(3) ./pre-inst-env guix system init ~/config.scm ~/tf
Now, ~/tf contains the system to be booted over the network, right?
But ~/tf/boot/efi/Guix/grub.cfg points to the tftp machine's /boot .
Is that a bug? Shouldn't it point to the /boot of ~/tf, the system
to be booted?
Likewise, the gnu store directly inside ~/tf is not used, but
~/tf/boot/gnu points to the tftp machines's /gnu. Shouldn't it
point to the former?
On Sat, 26 Sep 2020 12:54:00 +0200
Stefan <stefan-guix@vodafonemail.de> wrote:
> + (let* ((net-dir (string-append mount-point target "/"))
> + (sub-dir (string-append net-dir #$subdir "/"))
> + (store-link (string-append net-dir (%store-prefix)))
> + (grub-cfg "/boot/grub/grub.cfg")
Shouldn't that be
(string-append mount-point "/boot/grub/grub.cfg")
?
> + (grub-cfg-link (string-append sub-dir (basename grub-cfg)))
> + (boot-efi-link (string-append sub-dir #$boot-efi-link)))
> + ;; Prepare the symlink to the store.
> + (mkdir-p (dirname store-link))
> + (false-if-exception (delete-file store-link))
> + (symlink-relative (%store-prefix) store-link)
Shouldn't that be
(symlink-relative (string-append mount-point (%store-prefix)) store-link)
?
> + ;; Install GRUB, which refers to the grub.cfg, with support for
> + ;; encrypted partitions,
> + (setenv "GRUB_ENABLE_CRYPTODISK" "y")
> + (invoke/quiet (string-append bootloader "/bin/grub-mknetdir")
> + (string-append "--net-directory=" net-dir)
> + (string-append "--subdir=" #$subdir))
> + ;; Prepare the symlink to the grub.cfg, which points into the store.
> + (false-if-exception (delete-file grub-cfg-link))
> + (symlink-relative grub-cfg grub-cfg-link)
> + ;; Prepare the bootloader symlink, which points to GRUB.
> + (false-if-exception (delete-file boot-efi-link))
> + (symlink #$efi-bootloader boot-efi-link))))))
Okay.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-26 16:15 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 20:32 [bug#41011] [PATCH] gnu: grub: Support for network boot via tftp/nfs Stefan
2020-05-10 8:20 ` Mathieu Othacehe
2020-05-10 21:13 ` Stefan
2020-05-18 21:43 ` Stefan
2020-05-21 15:07 ` Stefan
2020-05-21 18:40 ` Stefan
2020-05-23 8:10 ` Mathieu Othacehe
2020-05-24 0:22 ` Stefan
2020-05-23 8:02 ` Mathieu Othacehe
2020-05-24 10:18 ` Stefan
2020-05-24 11:00 ` Danny Milosavljevic
2020-05-24 13:09 ` Stefan
2020-05-24 13:42 ` Danny Milosavljevic
2020-05-24 13:58 ` Danny Milosavljevic
2020-05-24 17:06 ` Stefan
2020-05-24 16:47 ` Stefan
2020-06-06 13:30 ` Stefan
2020-06-06 13:33 ` Stefan
2020-06-06 17:37 ` Danny Milosavljevic
[not found] ` <46CD97B3-9994-4AB7-AA7D-4DE39AB7A238@vodafonemail.de>
2020-06-09 13:44 ` Danny Milosavljevic
2020-06-09 14:25 ` Stefan
2020-06-11 4:21 ` Maxim Cournoyer
2020-06-11 11:36 ` Stefan
2020-06-11 13:07 ` Maxim Cournoyer
2020-06-11 13:19 ` Danny Milosavljevic
2020-06-12 14:41 ` Stefan
2020-06-14 18:56 ` Maxim Cournoyer
2020-06-11 23:43 ` [bug#41820] [PATCH] file-systems: Add record type <nfs-share> for a file system device Stefan
2020-06-20 13:52 ` Stefan
2020-06-12 0:06 ` [bug#41011] [PATCH] gnu: grub: Support for network boot via tftp/nfs Stefan
2020-06-14 19:09 ` Maxim Cournoyer
2020-06-17 13:12 ` Stefan
2020-09-05 11:25 ` Stefan
2020-09-06 13:07 ` Stefan
2020-09-06 14:35 ` Danny Milosavljevic
2020-09-06 15:14 ` Danny Milosavljevic
2020-09-07 22:59 ` Stefan
2020-09-08 22:37 ` Danny Milosavljevic
2020-09-13 17:46 ` [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP Stefan
2020-09-14 6:59 ` Efraim Flashner
2020-09-15 20:28 ` Stefan
2020-09-16 7:51 ` Efraim Flashner
2020-09-19 17:54 ` Stefan
2020-09-20 11:47 ` Stefan
2020-09-20 11:56 ` Stefan
2020-09-26 10:52 ` Stefan
2020-09-26 10:54 ` Stefan
2020-09-26 16:13 ` Danny Milosavljevic [this message]
2020-09-27 10:50 ` Stefan
2020-09-27 10:51 ` Stefan
2020-09-27 11:47 ` Danny Milosavljevic
2020-09-14 12:34 ` Danny Milosavljevic
2020-09-15 22:10 ` Danny Milosavljevic
2020-09-27 11:57 ` bug#41011: " Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926181357.1aa2faa4@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=41011@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=stefan-guix@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).