unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#43576] [PATCH] gnu: nng: Update to build as shared library
@ 2020-09-23  8:11 Hamzeh Nasajpour
  2020-09-23  9:14 ` bug#43576: " Efraim Flashner
  0 siblings, 1 reply; 2+ messages in thread
From: Hamzeh Nasajpour @ 2020-09-23  8:11 UTC (permalink / raw)
  To: 43576

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 89e47a6726..a5aac7b878 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -419,7 +419,9 @@ at the link-layer level.")
     (arguments
      `(#:configure-flags
        (list "-DNNG_ENABLE_COVERAGE=ON"
-             "-DNNG_ENABLE_TLS=ON")
+             "-DNNG_ENABLE_TLS=ON"
+             ;; To building as shared library
+             "-DBUILD_SHARED_LIBS=ON")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'disable-failing-tests




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#43576: [PATCH] gnu: nng: Update to build as shared library
  2020-09-23  8:11 [bug#43576] [PATCH] gnu: nng: Update to build as shared library Hamzeh Nasajpour
@ 2020-09-23  9:14 ` Efraim Flashner
  0 siblings, 0 replies; 2+ messages in thread
From: Efraim Flashner @ 2020-09-23  9:14 UTC (permalink / raw)
  To: Hamzeh Nasajpour; +Cc: 43576-done

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On Wed, Sep 23, 2020 at 11:41:25AM +0330, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 89e47a6726..a5aac7b878 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -419,7 +419,9 @@ at the link-layer level.")
>      (arguments
>       `(#:configure-flags
>         (list "-DNNG_ENABLE_COVERAGE=ON"
> -             "-DNNG_ENABLE_TLS=ON")
> +             "-DNNG_ENABLE_TLS=ON"
> +             ;; To building as shared library

This comment isn't really necessary

> +             "-DBUILD_SHARED_LIBS=ON")
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'disable-failing-tests
> 

I created a whole commit message, added a copyright line for you
and pushed the patch. Thanks!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-23  9:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-23  8:11 [bug#43576] [PATCH] gnu: nng: Update to build as shared library Hamzeh Nasajpour
2020-09-23  9:14 ` bug#43576: " Efraim Flashner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).