* [bug#43504] [PATCH] gnu: Add scantailor-advanced. @ 2020-09-19 5:52 Brendan Tildesley 2020-09-25 12:29 ` Mathieu Othacehe 0 siblings, 1 reply; 6+ messages in thread From: Brendan Tildesley @ 2020-09-19 5:52 UTC (permalink / raw) To: 43504 * gnu/packages/image-processing.scm (scantailor-advanced): New variable. --- gnu/packages/image-processing.scm | 50 +++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index 9158e14938..c480fae05a 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -11,6 +11,7 @@ ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; Copyright © 2020 Vinicius Monego <monego@posteo.net> ;;; Copyright © 2020 Pierre Neidhardt <mail@ambrevar.xyz> +;;; Copyright © 2020 Brendan Tildesley <mail@brendan.scot> ;;; ;;; This file is part of GNU Guix. ;;; @@ -33,6 +34,7 @@ #:use-module (guix utils) #:use-module (guix download) #:use-module (guix git-download) + #:use-module (guix build-system qt) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (gnu packages) @@ -1015,3 +1017,51 @@ substitued, as well as collage-style photomosaics, in which rectangular parts of the source image at arbitrary positions (i.e. not aligned to a matrix) are substituted by matching images.") (license license:gpl2)))) + +(define-public scantailor-advanced + (let ((commit "df1f8e25d16e08594d530c18de58f44b1fd7b0a5")) + (package + (name "scantailor-advanced") + (version (string-append "1.0.16-" (string-take commit 7))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/brendan-t/scantailor-advanced") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0jycvw39yg17zrd2fdmihskkwb3jx2j50479bnqh50jcndligb3f")))) + (build-system qt-build-system) + (native-inputs + `(("qttools" ,qttools))) + (inputs + `(("boost" ,boost) + ("libjpeg" ,libjpeg-turbo) + ("libpng" ,libpng) + ("libtiff" ,libtiff) + ("qtbase" ,qtbase) + ("qtsvg" ,qtsvg) + ("zlib" ,zlib))) + (arguments + `(#:phases + (modify-phases %standard-phases + ;; Some tests require a display and fail with offscreen mode. + (add-after 'unpack 'disable-failing-tests + (lambda _ + (setenv "ARGS" "--exclude-regex \"imageproc_.*\"") + #t))))) + (home-page "https://github.com/4lex4/scantailor-advanced") + (synopsis "Clean up scanned pages") + (description "Scan Tailor is an interactive post-processing tool for +scanned pages. It performs operations such as page splitting, deskewing, +adding/removing borders, and others. You give it raw scans, and you get pages +ready to be printed or assembled into a PDF or DJVU file. Scanning, optical +character recognition, and assembling multi-page documents are out of scope of +this project. + +Scan Tailer Advanced is a development of Scan Tailer that merges features and +bug fixes from Scan Tailor Featured and Scan Tailor Enhanced versions. Guix's +version additionally includes a Korean translation.") + (license license:gpl3+)))) -- 2.28.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#43504] [PATCH] gnu: Add scantailor-advanced. 2020-09-19 5:52 [bug#43504] [PATCH] gnu: Add scantailor-advanced Brendan Tildesley @ 2020-09-25 12:29 ` Mathieu Othacehe 2020-09-25 20:46 ` Brendan Tildesley 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Othacehe @ 2020-09-25 12:29 UTC (permalink / raw) To: Brendan Tildesley; +Cc: 43504 Hello, > + (uri (git-reference > + (url "https://github.com/brendan-t/scantailor-advanced") > + (commit commit))) What's the reason for not using the upstream 1.0.16 release? Is the only reason the addition of the Korean translation? In that case, it could be contributed upstream or added as a side patch I guess. Thanks, Mathieu ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#43504] [PATCH] gnu: Add scantailor-advanced. 2020-09-25 12:29 ` Mathieu Othacehe @ 2020-09-25 20:46 ` Brendan Tildesley 2020-10-01 7:37 ` Mathieu Othacehe 0 siblings, 1 reply; 6+ messages in thread From: Brendan Tildesley @ 2020-09-25 20:46 UTC (permalink / raw) To: Mathieu Othacehe; +Cc: 43504 [-- Attachment #1: Type: text/plain, Size: 999 bytes --] On September 25, 2020 10:29:48 PM GMT+10:00, Mathieu Othacehe <othacehe@gnu.org> wrote: > >Hello, > >> + (uri (git-reference >> + (url >"https://github.com/brendan-t/scantailor-advanced") >> + (commit commit))) > >What's the reason for not using the upstream 1.0.16 release? Is the >only >reason the addition of the Korean translation? In that case, it could >be >contributed upstream or added as a side patch I guess. > >Thanks, > >Mathieu Well I saw the merge request for it and it was ignored, so I just added it manually. Also I wasn't using the latest tag release but the latest commit because the release is 2 years old and there are many fixes and changes afterwards. This is not just the latest release plus the translation but the latest commit plus it, in my own repo. It didn't look like the channel owner was planning to make a release any time soon. Do you think I should just use the latest release then and not worry about it? [-- Attachment #2: Type: text/html, Size: 1392 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#43504] [PATCH] gnu: Add scantailor-advanced. 2020-09-25 20:46 ` Brendan Tildesley @ 2020-10-01 7:37 ` Mathieu Othacehe 2020-10-01 10:23 ` Brendan Tildesley 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Othacehe @ 2020-10-01 7:37 UTC (permalink / raw) To: Brendan Tildesley; +Cc: 43504 Hello Brendan, > Well I saw the merge request for it and it was ignored, so I just added it manually. Also I wasn't using the latest tag release but the latest commit because the release is 2 years old and there > are many fixes and changes afterwards. This is not just the latest release plus the translation but the latest commit plus it, in my own repo. It didn't look like the channel owner was planning > to make a release any time soon. Do you think I should just use the latest release then and not worry about it? The project is not explicitly discontinued, so maybe you could package the latest upstream commit. Regarding your translation commit, I saw you submitted a MR a few days ago, let's see if it gets a review. Thanks, Mathieu ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#43504] [PATCH] gnu: Add scantailor-advanced. 2020-10-01 7:37 ` Mathieu Othacehe @ 2020-10-01 10:23 ` Brendan Tildesley 2020-10-01 12:23 ` bug#43504: " Mathieu Othacehe 0 siblings, 1 reply; 6+ messages in thread From: Brendan Tildesley @ 2020-10-01 10:23 UTC (permalink / raw) To: Mathieu Othacehe; +Cc: 43504 [-- Attachment #1: Type: text/plain, Size: 1044 bytes --] On 1/10/20 7:37 am, Mathieu Othacehe wrote: > Hello Brendan, > >> Well I saw the merge request for it and it was ignored, so I just added it manually. Also I wasn't using the latest tag release but the latest commit because the release is 2 years old and there >> are many fixes and changes afterwards. This is not just the latest release plus the translation but the latest commit plus it, in my own repo. It didn't look like the channel owner was planning >> to make a release any time soon. Do you think I should just use the latest release then and not worry about it? > The project is not explicitly discontinued, so maybe you could package > the latest upstream commit. Regarding your translation commit, I saw you > submitted a MR a few days ago, let's see if it gets a review. > > Thanks, > > Mathieu I attached a new one that uses up stream's latest. By the way, to test it, just take a photo of a page from a book, and try load it in. if you can go through the steps processing it to a clean output then it should be working ok. [-- Attachment #2: 0001-gnu-Add-scantailor-advanced.patch --] [-- Type: text/x-patch, Size: 3333 bytes --] From b2113f7dc97a3486ad79bf77ef139ef026305234 Mon Sep 17 00:00:00 2001 From: Brendan Tildesley <mail@brendan.scot> Date: Thu, 17 Sep 2020 19:09:21 +1000 Subject: [PATCH] gnu: Add scantailor-advanced. * gnu/packages/image-processing.scm (scantailor-advanced): New variable. --- gnu/packages/image-processing.scm | 49 +++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index 9158e14938..d9fd0e5baa 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -11,6 +11,7 @@ ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com> ;;; Copyright © 2020 Vinicius Monego <monego@posteo.net> ;;; Copyright © 2020 Pierre Neidhardt <mail@ambrevar.xyz> +;;; Copyright © 2020 Brendan Tildesley <mail@brendan.scot> ;;; ;;; This file is part of GNU Guix. ;;; @@ -33,6 +34,7 @@ #:use-module (guix utils) #:use-module (guix download) #:use-module (guix git-download) + #:use-module (guix build-system qt) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (gnu packages) @@ -1015,3 +1017,50 @@ substitued, as well as collage-style photomosaics, in which rectangular parts of the source image at arbitrary positions (i.e. not aligned to a matrix) are substituted by matching images.") (license license:gpl2)))) + +(define-public scantailor-advanced + (let ((commit "3d1e74e6ace413733511086934a66f4e3f7a6027")) + (package + (name "scantailor-advanced") + (version (string-append "1.0.16-" (string-take commit 7))) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/4lex4/scantailor-advanced") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0kixwjb2x457dq7927hkh34c803p7yh1pmn6n61rk9shqrcg492h")))) + (build-system qt-build-system) + (native-inputs + `(("qttools" ,qttools))) + (inputs + `(("boost" ,boost) + ("libjpeg" ,libjpeg-turbo) + ("libpng" ,libpng) + ("libtiff" ,libtiff) + ("qtbase" ,qtbase) + ("qtsvg" ,qtsvg) + ("zlib" ,zlib))) + (arguments + `(#:phases + (modify-phases %standard-phases + ;; Some tests require a display and fail with offscreen mode. + (add-after 'unpack 'disable-failing-tests + (lambda _ + (setenv "ARGS" "--exclude-regex \"imageproc_.*\"") + #t))))) + (home-page "https://github.com/4lex4/scantailor-advanced") + (synopsis "Clean up scanned pages") + (description "Scan Tailor is an interactive post-processing tool for +scanned pages. It performs operations such as page splitting, deskewing, +adding/removing borders, and others. You give it raw scans, and you get pages +ready to be printed or assembled into a PDF or DJVU file. Scanning, optical +character recognition, and assembling multi-page documents are out of scope of +this project. + +Scan Tailer Advanced is a fork of Scan Tailer that merges Scan Tailor Featured +and Scan Tailor Enhanced versions as well as including many more bug fixes.") + (license license:gpl3+)))) -- 2.28.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#43504: [PATCH] gnu: Add scantailor-advanced. 2020-10-01 10:23 ` Brendan Tildesley @ 2020-10-01 12:23 ` Mathieu Othacehe 0 siblings, 0 replies; 6+ messages in thread From: Mathieu Othacehe @ 2020-10-01 12:23 UTC (permalink / raw) To: Brendan Tildesley; +Cc: 43504-done Hey Brendan, > I attached a new one that uses up stream's latest. By the way, to test it, > just take a photo of a page from a book, and try load it in. if you can go > through the steps processing it to a clean output then it should be working > ok. Pushed as a76e9d13e9b5cad2bbfc0433d2f8d0eae2af0b05. Thanks, Mathieu ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-01 12:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-09-19 5:52 [bug#43504] [PATCH] gnu: Add scantailor-advanced Brendan Tildesley 2020-09-25 12:29 ` Mathieu Othacehe 2020-09-25 20:46 ` Brendan Tildesley 2020-10-01 7:37 ` Mathieu Othacehe 2020-10-01 10:23 ` Brendan Tildesley 2020-10-01 12:23 ` bug#43504: " Mathieu Othacehe
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).