From: Julien Lepiller <julien@lepiller.eu>
To: 43458@debbugs.gnu.org
Subject: [bug#43458] [PATCH] guix: build: Add a hint for unspecified value
Date: Wed, 16 Sep 2020 23:40:03 +0200 [thread overview]
Message-ID: <20200916234003.35f2ac07@tachikoma.lepiller.eu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
Hi Guix!
this patch adds a hint to guix build, when you try to build from a file
and it returns #<unspecified>. The most common error is when you copy
the structure from other guix modules and use `define-public` for your
package. The file returns #<unspecified> and you get this message:
> #<unspecified>: not something we can build.
Which is not very helpful. Here is what happens with this change:
> guix build: error: #<unspecified>: not something we can build
>
> hint: If you build from a file, make sure the last scheme expression
> returns a package value. `define-public' defines a variable, but
> returns #<unspecified>. To fix this, add a scheme expression at the
> end of the file that consists only of the package's variable name you
> defined. ex:
>
> (define-public my-package
> (package
> ...))
>
> my-package
If instead, you return a value that is not understood, the message is
simpler (as this is not something that happens out of confusion / being
new to guix or guile):
> guix build: error: 1: not something we can build
>
> hint: If you build from a file, make sure the last scheme expression
> returns a package, gexp, derivation value or a list of such values.
(here the file returned "1" which we can't build :))
[-- Attachment #2: 0001-guix-build-Add-a-hint-for-unspecified-value.patch --]
[-- Type: text/x-patch, Size: 2272 bytes --]
From b29a325ef52d402c9618bfe9f02e478134297c0f Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Wed, 16 Sep 2020 23:32:00 +0200
Subject: [PATCH] guix: build: Add a hint for unspecified value.
* guix/scripts/build.scm (options->things-to-build): Add a hint when we
cannot build something.
---
guix/scripts/build.scm | 24 +++++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm
index 25418661b9..46d1415a4d 100644
--- a/guix/scripts/build.scm
+++ b/guix/scripts/build.scm
@@ -38,6 +38,7 @@
#:use-module (guix monads)
#:use-module (guix gexp)
#:use-module (guix profiles)
+ #:use-module (guix diagnostics)
#:autoload (guix http-client) (http-fetch http-get-error?)
#:use-module (ice-9 format)
#:use-module (ice-9 match)
@@ -46,6 +47,7 @@
#:use-module (srfi srfi-11)
#:use-module (srfi srfi-26)
#:use-module (srfi srfi-34)
+ #:use-module (srfi srfi-35)
#:use-module (srfi srfi-37)
#:use-module (gnu packages)
#:autoload (guix download) (download-to-store)
@@ -805,7 +807,27 @@ must be one of 'package', 'all', or 'transitive'~%")
build---packages, gexps, derivations, and so on."
(define (validate-type x)
(unless (or (derivation? x) (file-like? x) (gexp? x) (procedure? x))
- (leave (G_ "~s: not something we can build~%") x)))
+ (raise (make-compound-condition
+ (formatted-message (G_ "~s: not something we can build~%") x)
+ (condition
+ (&fix-hint
+ (hint
+ (if (unspecified? x)
+ (G_ "If you build from a file, make sure the last scheme
+expression returns a package value. @code{define-public} defines a variable,
+but returns #<unspecified>. To fix this, add a scheme expression at the end of
+the file that consists only of the package's variable name you defined. ex:
+
+@example
+(define-public my-package
+ (package
+ ...))
+
+my-package
+@end example")
+ (G_ "If you build from a file, make sure the last scheme
+expression returns a package, gexp, derivation value or a list of such
+values.")))))))))
(define (ensure-list x)
(let ((lst (match x
--
2.28.0
next reply other threads:[~2020-09-16 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 21:40 Julien Lepiller [this message]
2020-09-18 20:35 ` [bug#43458] [PATCH] guix: build: Add a hint for unspecified value Ludovic Courtès
2020-09-29 13:16 ` bug#43458: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916234003.35f2ac07@tachikoma.lepiller.eu \
--to=julien@lepiller.eu \
--cc=43458@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).