From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WEPPDaO1YV+yXAAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 06:50:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wEcnCKO1YV+CTQAAB5/wlQ (envelope-from ) for ; Wed, 16 Sep 2020 06:50:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BF77940221 for ; Wed, 16 Sep 2020 06:50:10 +0000 (UTC) Received: from localhost ([::1]:58988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIRGa-0000iZ-Gs for larch@yhetil.org; Wed, 16 Sep 2020 02:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIRGU-0000iR-1j for guix-patches@gnu.org; Wed, 16 Sep 2020 02:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49687) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIRGT-0001xF-Ok for guix-patches@gnu.org; Wed, 16 Sep 2020 02:50:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIRGT-0002uJ-Ml for guix-patches@gnu.org; Wed, 16 Sep 2020 02:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43414] [PATCH 1/3] gnu: Add rust-lab. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Sep 2020 06:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43414 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Arazas Cc: 43414@debbugs.gnu.org Received: via spool by 43414-submit@debbugs.gnu.org id=B43414.160023897011119 (code B ref 43414); Wed, 16 Sep 2020 06:50:01 +0000 Received: (at 43414) by debbugs.gnu.org; 16 Sep 2020 06:49:30 +0000 Received: from localhost ([127.0.0.1]:33000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIRFv-0002tD-8Q for submit@debbugs.gnu.org; Wed, 16 Sep 2020 02:49:30 -0400 Received: from flashner.co.il ([178.62.234.194]:53540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIRFr-0002sx-PA for 43414@debbugs.gnu.org; Wed, 16 Sep 2020 02:49:25 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id 8E6CF401B2; Wed, 16 Sep 2020 06:49:17 +0000 (UTC) Date: Wed, 16 Sep 2020 09:48:40 +0300 From: Efraim Flashner Message-ID: <20200916064840.GB19874@E5400> References: <20200915005226.1978-1-foo.dogsquared@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9dgjiU4MmWPVapMU" Content-Disposition: inline In-Reply-To: <20200915005226.1978-1-foo.dogsquared@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 1.1 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 0.1 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: TVJy2rx6cLTZ --9dgjiU4MmWPVapMU Content-Type: multipart/mixed; boundary="da4uJneut+ArUgXk" Content-Disposition: inline --da4uJneut+ArUgXk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable A couple of issues I've found with this patch: (I've attached the updated patch) On Tue, Sep 15, 2020 at 08:52:24AM +0800, Gabriel Arazas wrote: > * gnu/packages/crates-io.scm (rust-lab-0.8): New variable. > * gnu/packages/crates-io.scm (rust-lab-0.7): New variable. > * gnu/packages/crates-io.scm (rust-lab-0.4): New variable. > --- > gnu/packages/crates-io.scm | 61 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) >=20 > diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm > index 0f0f0c28c9..2f3cead9cf 100644 > --- a/gnu/packages/crates-io.scm > +++ b/gnu/packages/crates-io.scm > @@ -12220,6 +12220,67 @@ currently supports parsing (fully conformant par= ser), formatting and comparing > language tags.") > (license license:expat))) > =20 > +(define-public rust-lab-0.8 > + (package > + (name "rust-lab") > + (version "0.8.1") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "lab" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1ysnbviwi35mq6xyz9c59mpgigyfp4s4y2mispxzrms4vk83bx15")))) > + (build-system cargo-build-system) > + (arguments > + `(#:cargo-development-inputs > + (("rust-approx" ,rust-approx-0.3) > + ("rust-criterion" ,rust-criterion-0.3) > + ("rust-lazy-static" ,rust-lazy-static-1.4) > + ("rust-pretty-assertions" > + ,rust-pretty-assertions-0.6) > + ("rust-rand" ,rust-rand-0.7)))) This is actually rust-rand-0.5 > + (home-page "https://github.com/TooManyBees/lab") > + (synopsis > + "Converts RGB to CIE-LAB for Rust") > + (description > + "Tools for converting RGB colors to the CIE-LAB color space, and > +comparing differences in color. > + ") > + (license license:expat))) > + These two packages don't actually use the same dependencies as rust-lab-0.8. I normally check https://crates.io/crates/ to make sure I have the correct dependencies. > +(define-public rust-lab-0.7 > + (package > + (inherit rust-lab-0.8) > + (name "rust-lab") > + (version "0.7.2") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "lab" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0g692d489lq01pv3mzfhxd98j0r22lw28l6bk112m74djlfzxdmw")))))) > + > +(define-public rust-lab-0.4 > + (package > + (inherit rust-lab-0.8) > + (name "rust-lab") > + (version "0.4.4") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "lab" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0h4ig5bvzmwlzd74zj7b4sh7kzi3c6mjjnw7yjz8ijxvr4mrcr1s")))))) > + > (define-public rust-lalrpop-0.17 > (package > (name "rust-lalrpop") > --=20 > 2.28.0 >=20 In addition, rust-lab-0.7 failed the test suite for me. I got: error: process didn't exit successfully: `/tmp/guix-build-rust-lab-0.7.2.dr= v-0/lab-0.7.2/target/release/deps/lab-674125292fb73d25` (signal: 4, SIGILL:= illegal instruction) When I looked into it more it looks like it's building targeting avx2 with 0.8.1=C2=B9, unspecified on 0.7.2=C2=B2 and nothing in particular in 0= =2E4.2 (couldn't find a tag for 0.4.4 in the git repo). Do programs compiled using this crate work on machines without all the expected CPU extensions? Since the two packages depending on lab-0.7 pass their test suite I assume it's more of an issue about the test suite for 0.7 and less of an issue about the crate itself. =C2=B9 https://github.com/TooManyBees/lab/blob/v0.8.1/src/lib.rs#L96 =C2=B2 https://github.com/TooManyBees/lab/blob/v0.7.2/src/lib.rs#L51 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --da4uJneut+ArUgXk Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0001-gnu-Add-rust-lab-0.8-rust-lab-0.7-rust-lab-0.4.patch" Content-Transfer-Encoding: quoted-printable =46rom 833dfde76e9058a22b80526a73038dc341947c5b Mon Sep 17 00:00:00 2001 =46rom: Gabriel Arazas Date: Tue, 15 Sep 2020 08:52:24 +0800 Subject: [PATCH] gnu: Add rust-lab-0.8, rust-lab-0.7, rust-lab-0.4. * gnu/packages/crates-io.scm (rust-lab-0.8, rust-lab-0.7, rust-lab-0.4): New variables. Signed-off-by: Efraim Flashner --- gnu/packages/crates-io.scm | 69 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm index 0f0f0c28c9..eee1432f94 100644 --- a/gnu/packages/crates-io.scm +++ b/gnu/packages/crates-io.scm @@ -8,6 +8,7 @@ ;;; Copyright =C2=A9 2019, 2020 Hartmut Goebel ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka ;;; Copyright =C2=A9 2020 Leo Famulari +;;; Copyright =C2=A9 2020 Gabriel Arazas ;;; ;;; This file is part of GNU Guix. ;;; @@ -12220,6 +12221,74 @@ currently supports parsing (fully conformant parse= r), formatting and comparing language tags.") (license license:expat))) =20 +(define-public rust-lab-0.8 + (package + (name "rust-lab") + (version "0.8.1") + (source + (origin + (method url-fetch) + (uri (crate-uri "lab" version)) + (file-name + (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1ysnbviwi35mq6xyz9c59mpgigyfp4s4y2mispxzrms4vk83bx15")))) + (build-system cargo-build-system) + (arguments + `(#:cargo-development-inputs + (("rust-approx" ,rust-approx-0.3) + ("rust-criterion" ,rust-criterion-0.3) + ("rust-lazy-static" ,rust-lazy-static-1) + ("rust-pretty-assertions" ,rust-pretty-assertions-0.6) + ("rust-rand" ,rust-rand-0.5)))) + (home-page "https://github.com/TooManyBees/lab") + (synopsis "Convert RGB to CIE-LAB for Rust") + (description + "This package contains tools for converting RGB colors to the CIE-LAB= color +space, and comparing differences in color.") + (license license:expat))) + +(define-public rust-lab-0.7 + (package + (inherit rust-lab-0.8) + (name "rust-lab") + (version "0.7.2") + (source + (origin + (method url-fetch) + (uri (crate-uri "lab" version)) + (file-name + (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "0g692d489lq01pv3mzfhxd98j0r22lw28l6bk112m74djlfzxdmw")))) + (arguments + `(#:tests? #f ; test suite assumes avx2 support + #:cargo-development-inputs + (("rust-criterion" ,rust-criterion-0.3) + ("rust-lazy-static" ,rust-lazy-static-1) + ("rust-pretty-assertions" ,rust-pretty-assertions-0.6) + ("rust-rand" ,rust-rand-0.5)))))) + +(define-public rust-lab-0.4 + (package + (inherit rust-lab-0.8) + (name "rust-lab") + (version "0.4.4") + (source + (origin + (method url-fetch) + (uri (crate-uri "lab" version)) + (file-name + (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "0h4ig5bvzmwlzd74zj7b4sh7kzi3c6mjjnw7yjz8ijxvr4mrcr1s")))) + (arguments + `(#:cargo-development-inputs + (("rust-rand" ,rust-rand-0.3)))))) + (define-public rust-lalrpop-0.17 (package (name "rust-lalrpop") --=20 2.28.0 --da4uJneut+ArUgXk-- --9dgjiU4MmWPVapMU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9htUcACgkQQarn3Mo9 g1FSvw/9EXdQKaclKWkAtRQeZJbGNVm+KUJJncEJvevTQyzO5Dy89c5ug24W/6gh yhZjX/xTmTdF1aDQdFJLiJcWk6gam3FyWhYHyE3gUYm7yYIuLda/H0Um0oaiYDpa daxQ+BEUkHzlSG81KF42bXvo/2PFd+imvZnHAibZs+Y1sJKtoOE1lkZJNYdDA8Ld FWrS+Zs5VZ2BT444keplH4iNLaU7gg6PJSFgzDhPwYDPFhJg9G0dUCkWATT0Zo1B 9TEq95qTKpKbFBH/ZjEQYuK4j/pWSGWbwLVyjEhlj3aYCef41MocUuRmSdxTlYjh B6SqTwa8JbHW96k5F34SFT3gMSd2n3l8gdyyIyNuDPcfKdW0N288aX85Z8KwHacc jCG4eRzZNE/9GHQUqZ3X9KxW1Ydar2Z1kkjBbJCJ9nzgaFx1qXkB1ATrFhH8GyRD +aXPhSMaBaPy6jH27VHNe5cJd0+HrENrA7avQLx4DXoAoy3nk1+Ba75EJlzU1jCX teuB/9gtpPwFcT5bymp6HhK6mwR9yjpNJRavCYtR+sE75G2UgnP1ZMskXab9OmTF iHl93HRD0FtYKK9PfPRnxqUJchEYjAifdjpzJ3m/tIoLkGUbsNJOeTaRrJCm+9xA YWcODDcpspCrs+JkZHVToaXS+t8awCjX6eD379Wod2XHbXaxAaM= =SaZS -----END PGP SIGNATURE----- --9dgjiU4MmWPVapMU--