A couple of issues I've found with this patch: (I've attached the updated patch) On Tue, Sep 15, 2020 at 08:52:24AM +0800, Gabriel Arazas wrote: > * gnu/packages/crates-io.scm (rust-lab-0.8): New variable. > * gnu/packages/crates-io.scm (rust-lab-0.7): New variable. > * gnu/packages/crates-io.scm (rust-lab-0.4): New variable. > --- > gnu/packages/crates-io.scm | 61 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm > index 0f0f0c28c9..2f3cead9cf 100644 > --- a/gnu/packages/crates-io.scm > +++ b/gnu/packages/crates-io.scm > @@ -12220,6 +12220,67 @@ currently supports parsing (fully conformant parser), formatting and comparing > language tags.") > (license license:expat))) > > +(define-public rust-lab-0.8 > + (package > + (name "rust-lab") > + (version "0.8.1") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "lab" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1ysnbviwi35mq6xyz9c59mpgigyfp4s4y2mispxzrms4vk83bx15")))) > + (build-system cargo-build-system) > + (arguments > + `(#:cargo-development-inputs > + (("rust-approx" ,rust-approx-0.3) > + ("rust-criterion" ,rust-criterion-0.3) > + ("rust-lazy-static" ,rust-lazy-static-1.4) > + ("rust-pretty-assertions" > + ,rust-pretty-assertions-0.6) > + ("rust-rand" ,rust-rand-0.7)))) This is actually rust-rand-0.5 > + (home-page "https://github.com/TooManyBees/lab") > + (synopsis > + "Converts RGB to CIE-LAB for Rust") > + (description > + "Tools for converting RGB colors to the CIE-LAB color space, and > +comparing differences in color. > + ") > + (license license:expat))) > + These two packages don't actually use the same dependencies as rust-lab-0.8. I normally check https://crates.io/crates/ to make sure I have the correct dependencies. > +(define-public rust-lab-0.7 > + (package > + (inherit rust-lab-0.8) > + (name "rust-lab") > + (version "0.7.2") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "lab" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0g692d489lq01pv3mzfhxd98j0r22lw28l6bk112m74djlfzxdmw")))))) > + > +(define-public rust-lab-0.4 > + (package > + (inherit rust-lab-0.8) > + (name "rust-lab") > + (version "0.4.4") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "lab" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0h4ig5bvzmwlzd74zj7b4sh7kzi3c6mjjnw7yjz8ijxvr4mrcr1s")))))) > + > (define-public rust-lalrpop-0.17 > (package > (name "rust-lalrpop") > -- > 2.28.0 > In addition, rust-lab-0.7 failed the test suite for me. I got: error: process didn't exit successfully: `/tmp/guix-build-rust-lab-0.7.2.drv-0/lab-0.7.2/target/release/deps/lab-674125292fb73d25` (signal: 4, SIGILL: illegal instruction) When I looked into it more it looks like it's building targeting avx2 with 0.8.1¹, unspecified on 0.7.2² and nothing in particular in 0.4.2 (couldn't find a tag for 0.4.4 in the git repo). Do programs compiled using this crate work on machines without all the expected CPU extensions? Since the two packages depending on lab-0.7 pass their test suite I assume it's more of an issue about the test suite for 0.7 and less of an issue about the crate itself. ¹ https://github.com/TooManyBees/lab/blob/v0.8.1/src/lib.rs#L96 ² https://github.com/TooManyBees/lab/blob/v0.7.2/src/lib.rs#L51 -- Efraim Flashner אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted