From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4MESLcWWX1+iNQAA0tVLHw (envelope-from ) for ; Mon, 14 Sep 2020 16:13:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gOJIJ8WWX1+FHAAAB5/wlQ (envelope-from ) for ; Mon, 14 Sep 2020 16:13:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 269DC94060E for ; Mon, 14 Sep 2020 16:13:57 +0000 (UTC) Received: from localhost ([::1]:59830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHr75-0001iD-Vi for larch@yhetil.org; Mon, 14 Sep 2020 12:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHpbK-0002vd-Rz for guix-patches@gnu.org; Mon, 14 Sep 2020 10:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHpbK-0003S2-Gl for guix-patches@gnu.org; Mon, 14 Sep 2020 10:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHpbK-0007rm-E7 for guix-patches@gnu.org; Mon, 14 Sep 2020 10:37:02 -0400 Subject: bug#43310: [PATCH] gnu: Add lsp-dsp-lib. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 14 Sep 2020 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43310 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandros Theodotou Cc: 43310-done@debbugs.gnu.org Mail-Followup-To: 43310@debbugs.gnu.org, efraim@flashner.co.il, alex@zrythm.org Received: via spool by 43310-done@debbugs.gnu.org id=D43310.160009419530198 (code D ref 43310); Mon, 14 Sep 2020 14:37:02 +0000 Received: (at 43310-done) by debbugs.gnu.org; 14 Sep 2020 14:36:35 +0000 Received: from localhost ([127.0.0.1]:55708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpas-0007qz-L6 for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:36:34 -0400 Received: from flashner.co.il ([178.62.234.194]:46108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpao-0007qj-Rx for 43310-done@debbugs.gnu.org; Mon, 14 Sep 2020 10:36:33 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id DD1EF401B2; Mon, 14 Sep 2020 14:36:24 +0000 (UTC) Date: Mon, 14 Sep 2020 17:35:41 +0300 From: Efraim Flashner Message-ID: <20200914143541.GC17272@E5400> References: <9160c83dd3e513eb0f73b6a8b22ee78323fd2555.camel@zrythm.org> <20200914140203.GB17272@E5400> <3128d450cf954008cadc7c24d9817c5e88a6b4ea.camel@zrythm.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: <3128d450cf954008cadc7c24d9817c5e88a6b4ea.camel@zrythm.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: iy++YludgWC5 --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 14, 2020 at 03:17:48PM +0100, Alexandros Theodotou wrote: > Hi Efraim, >=20 > Thanks for the review. >=20 > On Mon, 2020-09-14 at 17:02 +0300, Efraim Flashner wrote: > > It looks like everything in the modules directory is vendored. Can we > > build it separately and link it in?=20 >=20 > I asked the author something similar a while back=20 > https://github.com/sadko4u/lsp-dsp-lib/issues/1#issuecomment-676517050 > I think the build system just expects those modules to be there as > sources - not sure if they even build anything to link to. BTW, this is > my initial patch, before the author started to provide an all-inclusive= =20 > tarball in the github releases page: >=20 > ```scheme > (define-public lsp-dsp-lib > (package > (name "lsp-dsp-lib") > (version "0.5.6") > (source > (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/sadko4u/lsp-dsp-lib") > (commit (string-append "lsp-dsp-lib-" version)))) > (file-name (git-file-name name version)) > (sha256 > (base32 > "1n5qp9bjsgg1ziy9mqnx034qlzbsp7yl473vk9aigzkyj883dfpj")))) > (build-system gnu-build-system) > (arguments > `(#:tests? #f ; no tests > #:make-flags > (list "CC=3Dgcc") > #:phases > (modify-phases %standard-phases > (add-before 'build 'copy-modules > (lambda* (#:key inputs #:allow-other-keys) > (copy-recursively (assoc-ref inputs "lsp-common-lib") > "modules/lsp-common-lib") > (copy-recursively (assoc-ref inputs "lsp-test-fw") > "modules/lsp-test-fw") > #t)) > (replace 'configure > (lambda _ > (invoke "make" "config" (string-append "PREFIX=3D" (assoc- > ref %outputs "out"))) > #t))))) > (inputs > `(("lsp-common-lib" ,(origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/sadko4u/lsp-common-lib") > (commit "lsp-common-lib-1.0.7"))) > (file-name (git-file-name name version)) > (sha256 > (base32 > "1alxv2ryivbj122gryxrrvyicw6zgbdk15wp010lrq6r1nj7mjxh")))) > ("lsp-test-fw" ,(origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/sadko4u/lsp-test-fw") > (commit "lsp-test-fw-1.0.5"))) > (file-name (git-file-name name version)) > (sha256 > (base32 > "0n4ircp9bgzwfaa6023bvfsb90qvl2iawbihnwivr5id1js5jq3p")))) > )) > (home-page "https://github.com/sadko4u/lsp-dsp-lib") > (synopsis "Digital signal processing library") > (description "The LSP DSP library provides a set of functions that > perform > SIMD-optimized computing on several hardware architectures. All > functions > currently operate on IEEE-754 single-precision floating-point > numbers.") > (license license:lgpl3+))) > ``` The current patch looks better. It is the same author and all. >=20 > > Also, I saw that there were a few > > test directories. Are there tests to be built? >=20 > Not sure - I don't see a check/test make target (see `make help`) >=20 I didn't see anything either. >=20 > > > + (arguments > > > + `(#:tests? #f ; no tests > > > + #:make-flags > > > + (list "CC=3Dgcc") > >=20 > > This can be cc-for-target > > (list (string-append "CC=3D" ,(cc-for-target))) >=20 > ACK >=20 > > > + (modify-phases %standard-phases > > > + (replace 'configure > > > + (lambda _ > > > + (invoke "make" "config" (string-append "PREFIX=3D" > > > (assoc-ref %outputs "out"))) > > > + #t))))) > >=20 > > We'd rather not use %outputs if possible, but to add it to the > > lambda. > > Also invoke already returns #t > >=20 > > (lambda* (#:key outputs #:allow-other-keys) > > (invoke "make" "config" > > (string-append "PREFIX=3D" (assoc-ref outputs > > "out")))))))) >=20 > ACK >=20 > Please find the updated patch attached. >=20 > Thanks, > Alex Thanks! Patch pushed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9ff7oACgkQQarn3Mo9 g1FJ1g/9G0XxgIDCV3U0HG/eftQj6AuIEzU/7JbymzJbVLZ/vzoiXpE4eNNA/jbf dvO4B85sLUL4dhWOAvIJrQZGw5aoKGPhiNAUwlJ6Kl2jNnaxOkr/zu5cKDjEMKoi eQjT/DqbCRAKWN0VdnXGqc1Xci/wnsOI0H+DxVUQHbFNDvlIUj+A/towdEOKD6FP wfkN9BfKDhdaC2P0+bc5oeFpEqBic8W01G+SRH9OLG9eWuz6RBiV7zl5leO9aTjo VnEXTnztFf3cUhqwV5fifqpnXWOvzvzMXbSwAc5Eyz2i/lrlZgjtiVDawd6UtNgo EWGaK+uKuqTLn1VDa5T4taGhqwhPziNMjeF8/uXqrfdrVjlEX9Uk2m3CJucJMqvP KVTwyE4lFjMDHJPpf2nw70xxlmxCqXx0Xv/RHAZs9QkLi6HUsRgMLcDqi+vCQQAY MsimM7xXlwL5IkB3KwMYr3Piu0bA12bL/hHcAu2jB7g6x5dcjvLDjHbU/PYnb9p2 QPGS118qDC/+p24X7Lls4dF4yqV2CByBl1VSWbkkCfoRYhwkbKbAYjAAxx25Ucwz zg4DHDohJ63PBh7jFAsNaLhjjlo++iYo4PWa42cE+4lSyBEFZPTd7AR6YxfCDzpC G0X9/CFflyXSP4WtLjg/ioQ+YGci1klCe2HEG3+YCyBK2wbkDfU= =NSCD -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--