From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id paSzCoRjX18nPAAA0tVLHw (envelope-from ) for ; Mon, 14 Sep 2020 12:35:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KEOzBIRjX190YQAA1q6Kng (envelope-from ) for ; Mon, 14 Sep 2020 12:35:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2DC6940878 for ; Mon, 14 Sep 2020 12:35:15 +0000 (UTC) Received: from localhost ([::1]:35028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHnhS-0006LZ-6q for larch@yhetil.org; Mon, 14 Sep 2020 08:35:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHnhG-0006LL-Ul for guix-patches@gnu.org; Mon, 14 Sep 2020 08:35:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHnhG-0000YJ-Lr for guix-patches@gnu.org; Mon, 14 Sep 2020 08:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHnhG-0007zF-Je for guix-patches@gnu.org; Mon, 14 Sep 2020 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Sep 2020 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41011 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan Cc: 41011@debbugs.gnu.org Received: via spool by 41011-submit@debbugs.gnu.org id=B41011.160008688530675 (code B ref 41011); Mon, 14 Sep 2020 12:35:02 +0000 Received: (at 41011) by debbugs.gnu.org; 14 Sep 2020 12:34:45 +0000 Received: from localhost ([127.0.0.1]:52988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHngy-0007yg-UC for submit@debbugs.gnu.org; Mon, 14 Sep 2020 08:34:45 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:38678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHngx-0007yX-9R for 41011@debbugs.gnu.org; Mon, 14 Sep 2020 08:34:43 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id CC40C3368786; Mon, 14 Sep 2020 14:34:40 +0200 (CEST) Date: Mon, 14 Sep 2020 14:34:25 +0200 From: Danny Milosavljevic Message-ID: <20200914143425.4fd44411@scratchpost.org> In-Reply-To: References: <9AAFEFF4-8ACE-4C95-975F-67C3F4FDAF81@vodafonemail.de> <20200906163559.1b56c36f@scratchpost.org> <45F0D825-F888-42E9-BDAE-7BB6FA010A6E@vodafonemail.de> <20200909003732.5c401932@scratchpost.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+WfMwVAzatxc=4JCDcp+2TN"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: 8OzUK1NZCNjS --Sig_/+WfMwVAzatxc=4JCDcp+2TN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Stefan, On Sun, 13 Sep 2020 19:46:01 +0200 Stefan wrote: > diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm > index e3febeefd0..552bc34f5a 100644 > --- a/gnu/bootloader/grub.scm > +++ b/gnu/bootloader/grub.scm > @@ -295,6 +300,9 @@ code." > ((? file-system-label? label) > (format #f "search --label --set ~a" > (file-system-label->string label))) > + ((? (lambda (device) > + (and (string? device) (string-contains device ":/"))) nfs-= uri) > + "set root=3D(tftp)") > ((or #f (? string?)) > #~(format #f "search --file --set ~a" #$file))))) After careful consideration, I've pushed this to guix master, with a big comment in the source code as to why we are doing what we are doing. I can see no downside to defaulting to TFTP for the time being. I do wonder if there are cases now where Grub tries to use TFTP when the us= er meant to boot locally--but nothing comes to mind.=20 Thank you for your elaborative E-Mails. I will still review the remainder. Please take Efraim's comments into consideration. --Sig_/+WfMwVAzatxc=4JCDcp+2TN Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9fY1EACgkQ5xo1VCww uqX5DggAkJs1l5lsqlplWwFjm9X2W2gldMfpf1dsO5w4KWwP5gJWW5B+IzqLb/IA Jp/D+sHsp2vSBwo+zzNUTazna+T0ky89moeiiDafp0vFHNFcCJdYi5/a/mo5779W mPojnDObZP6bozTmPNLtxenWlzZgDi3rRZdfsnRctslD0kVouBFUueh3bk3nEMFe yKf2Ux9OCUvIlw/ep7Cw2sO5luAZdTshcqzddX1BJVXyqtkCRuIYg5SkP7a8yHXT fNNe/tsyNN4KstOIq/oxXdgRXgEK3d9v6CwCKAfCH7DnI/QysQ4RI0PahFmxuyvn KbiFt6OZnIlKWUDiEYnH8nz6HCMY2A== =jG9D -----END PGP SIGNATURE----- --Sig_/+WfMwVAzatxc=4JCDcp+2TN--