unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 43348-done@debbugs.gnu.org
Subject: bug#43348: Profanity
Date: Sun, 13 Sep 2020 11:54:26 +0200	[thread overview]
Message-ID: <20200913115426.0a0bba06@scratchpost.org> (raw)
In-Reply-To: <0b908255-200f-ee7d-50c0-f0ad4f68eade@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Hi RG,

On Sun, 13 Sep 2020 05:12:04 -0400
Raghav Gururajan <raghavgururajan@disroot.org> wrote:

> > I still don't get it why python-wrapper is a *native* input in order to support
> > Python plugins.  That would mean the Python plugins are only used at build time
> > and not used at runtime.  Is that correct?  
> 
> As far as I understand, the package uses the python binary to compile a
> component, which will be used to add/remove python plugins.

I doubt it.

$ ./pre-inst-env guix gc --references `./pre-inst-env guix build profanity`
[...]
/gnu/store/09a5iq080g9b641jyl363dr5jkkvnhcn-python-3.8.2

So it keeps a runtime reference to python.  I suspect it just embeds a Python
interpreter.  So it should probably be a regular input.
The question is whether the plugins written in Python actually work or not.
Usually they require some extra PYTHONPATH or whatever setting in order to
find stuff.  Just raw Python is often not enough.

But we'll see.

Moved python-wrapper to regular input.

Pushed patchset to master.

I edited the commit messages not to include internal rationale like that that
change is the correct change (for glib-or-gtk-build-system) or whatever.

If we need that it should go in the source code as a comment--where it can
be easily seen.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-09-13  9:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 19:52 [bug#43348] Profanity Raghav Gururajan
2020-09-12  0:51 ` Danny Milosavljevic
2020-09-13  4:38   ` Raghav Gururajan
2020-09-13  9:11     ` Danny Milosavljevic
2020-09-13  9:12       ` Raghav Gururajan
2020-09-13  9:54         ` Danny Milosavljevic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200913115426.0a0bba06@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=43348-done@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).