[bug#43346] Poezio (Revised Patches)

[Danny Milosavljevic <dannym@scratchpost.org>]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Hi RG,

On Sat, 12 Sep 2020 08:06:05 -0400
Raghav Gururajan <raghavgururajan@disroot.org> wrote:

> I had to make some changes to poezio, based on your changes. Could you
> push the attached patches please?

... why?

I've checked the source code of poezio and it does not use aiodns, aiohttp.

In order to find that out:

$ guix build python-aiodns

Check resulting directory to find 
/gnu/store/8bzk4dwhhbblz8gky9hzdnzjlsi1nk7v-python-aiodns-1.1.1/lib/python3.8/site-packages/aiodns/__init__.py

That means a user of the library would have to do 

  from aiodns import *

or

  import aiodns
.

So I grepped the whole source code of poezio, and it doesn't do that.  Hence
it is not a direct input.

It is a propagated-input in a dependency, which indeed does do the import.

You can't really trust what upstream says here.  Almost no package manager
has non-propagated inputs, so of course they wouldn't be saying "the input
such and such is propagated, and the input such and such is not propagated".

Thus you have to check it yourself.

Could you do so with the other dependencies before adding them?

Thanks.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]