From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GxgaIrkbXF87JgAA0tVLHw (envelope-from ) for ; Sat, 12 Sep 2020 00:52:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UGcOHLkbXF/jRQAAbx9fmQ (envelope-from ) for ; Sat, 12 Sep 2020 00:52:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE4B49407C8 for ; Sat, 12 Sep 2020 00:52:08 +0000 (UTC) Received: from localhost ([::1]:59812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGtlv-0002lA-2l for larch@yhetil.org; Fri, 11 Sep 2020 20:52:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGtlq-0002l1-BC for guix-patches@gnu.org; Fri, 11 Sep 2020 20:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGtlq-0005jN-0f for guix-patches@gnu.org; Fri, 11 Sep 2020 20:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGtlp-0006Sb-Ug for guix-patches@gnu.org; Fri, 11 Sep 2020 20:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43348] Profanity Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Sep 2020 00:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan Cc: 43348@debbugs.gnu.org Received: via spool by 43348-submit@debbugs.gnu.org id=B43348.159987190224804 (code B ref 43348); Sat, 12 Sep 2020 00:52:01 +0000 Received: (at 43348) by debbugs.gnu.org; 12 Sep 2020 00:51:42 +0000 Received: from localhost ([127.0.0.1]:45829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGtlV-0006S0-RZ for submit@debbugs.gnu.org; Fri, 11 Sep 2020 20:51:42 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:34158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGtlU-0006Rt-Nt for 43348@debbugs.gnu.org; Fri, 11 Sep 2020 20:51:41 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id AB360336895A; Sat, 12 Sep 2020 02:51:39 +0200 (CEST) Date: Sat, 12 Sep 2020 02:51:38 +0200 From: Danny Milosavljevic Message-ID: <20200912025125.7540e02a@scratchpost.org> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/iW9FU7+=PvYN.K=J8YjCq2_"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: s9FsHn+Cc9LY --Sig_/iW9FU7+=PvYN.K=J8YjCq2_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi RG, please, for existing packages, try to be as clear as possible in the commit messages in what is changed (only one related set of things should be chang= ed per commit). In this case the commit confounds things: * Changing the build-system reference. This does not enable runtime features--which is what the commit message's topic stated that the commit d= oes. * Changing the autoconf method. This does not enable runtime features--whi= ch is what the commit message's topic stated that the commit does. * Adding Python as a NATIVE input. What is that about? Is profanity using a Python program as a compiler only? * I think that moving those native-inputs to inputs, while correct, does not enable runtime features--which is what the commit message's topic stated th= at the commit does. * Please use two spaces (after the period) in order to separate sentences. * Moving blocks around makes review much harder for users. The goal of those commit messages, and of the commit rules, is to make it easy for each user to see at a glance what topic each commit changes. --Sig_/iW9FU7+=PvYN.K=J8YjCq2_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9cG5oACgkQ5xo1VCww uqVibwf9GKRZMcFuYtdrEd/J93VpF0XyzP8IHzFfC9QGhmnFawgdo8jwwm7j4BIE 1zlv/hS1hV6ypuN5E0dFVJi0X7aiKBjdJteqLjOCbqXelINVIB67Zr99+n3DQJlS ZLjxAasy5XOcEpCwxrJFfVV+mjF8tyeszaGWDzx2jV09TZrCwvFvSX9K5wNlCRUG XyET3pMGDikugsdIwYcWteE9qdkYQ1T4Rr3DNERU7bYiVSrGZb1IfeQa8QS90CA2 IKzB421EcOPA4dRovlDkyYqMCkzXO3MG45YRuBXyyYYya5vTRde7o754GJC5LjoH ceEY5rFDHk2cAqdrwrCEGw0iV7+wkg== =v8le -----END PGP SIGNATURE----- --Sig_/iW9FU7+=PvYN.K=J8YjCq2_--