unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 43348@debbugs.gnu.org
Subject: [bug#43348] Profanity
Date: Sat, 12 Sep 2020 02:51:38 +0200	[thread overview]
Message-ID: <20200912025125.7540e02a@scratchpost.org> (raw)
In-Reply-To: <a560bb06-7d8a-5933-9f58-1a4e1f1b810e@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

Hi RG,

please, for existing packages, try to be as clear as possible in the commit
messages in what is changed (only one related set of things should be changed
per commit).

In this case the commit confounds things:

* Changing the build-system reference.  This does not enable runtime
features--which is what the commit message's topic stated that the commit does.
* Changing the autoconf method.  This does not enable runtime features--which
is what the commit message's topic stated that the commit does.
* Adding Python as a NATIVE input.  What is that about?  Is profanity using
a Python program as a compiler only?
* I think that moving those native-inputs to inputs, while correct, does not
enable runtime features--which is what the commit message's topic stated that
the commit does.
* Please use two spaces (after the period) in order to separate sentences.
* Moving blocks around makes review much harder for users.

The goal of those commit messages, and of the commit rules, is to make it
easy for each user to see at a glance what topic each commit changes.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-09-12  0:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 19:52 [bug#43348] Profanity Raghav Gururajan
2020-09-12  0:51 ` Danny Milosavljevic [this message]
2020-09-13  4:38   ` Raghav Gururajan
2020-09-13  9:11     ` Danny Milosavljevic
2020-09-13  9:12       ` Raghav Gururajan
2020-09-13  9:54         ` bug#43348: Profanity Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200912025125.7540e02a@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=43348@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).