From: "Ludovic Courtès" <ludo@gnu.org>
To: 43340@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#43340] [PATCH 0/5] Speed up archive export/import
Date: Fri, 11 Sep 2020 16:40:49 +0200 [thread overview]
Message-ID: <20200911144049.14632-1-ludo@gnu.org> (raw)
Hi!
This patch series goes on top of <https://issues.guix.gnu.org/43285>.
It addresses the performance issue described at:
https://lists.gnu.org/archive/html/guix-devel/2020-09/msg00073.html
Specifically, it implements option #4 (spawning ‘guix authenticate’
once for the whole session, instead of spawning it every time a
store item needs to be signed or authenticated), achieving a ~15x
speedup, which is not bad. :-)
There’s way more C++ code than I would like, and it’s probably not
pretty code (I always end up typing things like “C++ list append”
in a search engine to find the obscure incantation that does that).
There’s now a query/reply protocol between the daemon and ‘guix
authenticate’. Nothing fancy, but it allows for strings that contain
whitespace or newlines, which is necessary here.
That’s it!
Ludo’.
Ludovic Courtès (5):
daemon: Generalize 'HookInstance' to 'Agent'.
daemon: Isolate signing and signature verification functions.
daemon: Move 'Agent' to libutil.
daemon: Spawn 'guix authenticate' once for all.
authenticate: Cache the ACL and key pairs.
guix/scripts/authenticate.scm | 163 ++++++++++++++++++++++++++--------
nix/libstore/build.cc | 146 +++++-------------------------
nix/libstore/local-store.cc | 103 +++++++++++++++++----
nix/libutil/util.cc | 84 ++++++++++++++++++
nix/libutil/util.hh | 25 ++++++
tests/guix-authenticate.sh | 45 ++++++----
tests/store.scm | 8 +-
7 files changed, 372 insertions(+), 202 deletions(-)
--
2.28.0
next reply other threads:[~2020-09-11 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 14:40 Ludovic Courtès [this message]
2020-09-11 14:51 ` [bug#43340] [PATCH 1/5] daemon: Generalize 'HookInstance' to 'Agent' Ludovic Courtès
2020-09-11 14:51 ` [bug#43340] [PATCH 2/5] daemon: Isolate signing and signature verification functions Ludovic Courtès
2020-09-11 14:51 ` [bug#43340] [PATCH 3/5] daemon: Move 'Agent' to libutil Ludovic Courtès
2020-09-12 7:21 ` Mathieu Othacehe
2020-09-11 14:51 ` [bug#43340] [PATCH 4/5] daemon: Spawn 'guix authenticate' once for all Ludovic Courtès
2020-09-12 7:20 ` Mathieu Othacehe
2020-09-11 14:51 ` [bug#43340] [PATCH 5/5] authenticate: Cache the ACL and key pairs Ludovic Courtès
2020-09-11 15:01 ` [bug#43340] [PATCH 0/5] Speed up archive export/import Ludovic Courtès
2020-09-12 7:12 ` Mathieu Othacehe
2020-09-13 13:07 ` Ludovic Courtès
2020-09-14 13:47 ` bug#43340: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911144049.14632-1-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=43340@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).