From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aPa4BkM9WF8xQAAA0tVLHw (envelope-from ) for ; Wed, 09 Sep 2020 02:26:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uCKCAkM9WF+XAgAAbx9fmQ (envelope-from ) for ; Wed, 09 Sep 2020 02:26:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 895A99401AE for ; Wed, 9 Sep 2020 02:26:09 +0000 (UTC) Received: from localhost ([::1]:35882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFpoG-000339-6V for larch@yhetil.org; Tue, 08 Sep 2020 22:26:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFpoA-00032q-Cc for guix-patches@gnu.org; Tue, 08 Sep 2020 22:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFpoA-0008Ot-3C for guix-patches@gnu.org; Tue, 08 Sep 2020 22:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFpo9-0002oH-U2 for guix-patches@gnu.org; Tue, 08 Sep 2020 22:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42380] [PATCH] gnu: Add torbrowser-unbundle. Resent-From: =?UTF-8?Q?Andr=C3=A9?= Batista Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Sep 2020 02:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42380 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42380@debbugs.gnu.org Received: via spool by 42380-submit@debbugs.gnu.org id=B42380.159961833010760 (code B ref 42380); Wed, 09 Sep 2020 02:26:01 +0000 Received: (at 42380) by debbugs.gnu.org; 9 Sep 2020 02:25:30 +0000 Received: from localhost ([127.0.0.1]:56833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFpne-0002nT-6y for submit@debbugs.gnu.org; Tue, 08 Sep 2020 22:25:30 -0400 Received: from mx1.riseup.net ([198.252.153.129]:52996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFpnb-0002nK-H0 for 42380@debbugs.gnu.org; Tue, 08 Sep 2020 22:25:28 -0400 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4BmQpV1jb1zFdrN; Tue, 8 Sep 2020 19:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1599618326; bh=lHq7duuL3WzzLSLdKVHfmVsAvCAlJ3C24a5zn1hQNhY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lmYC7i0m1zNkmGb5AypxQftP9b8YIXQnxBSrqMpPdHN3tqE7vvNVauYgd0Stzhk5I MIFScwcmVcikkWNSFbDOpUZOZNO2x54feauVj8U48D5ccAi6U4s79cKuMhnSzX2pH/ ZwQHUzslSu2ZE9b3V22EzJA1rgUoMz4bwXWbdPd8= X-Riseup-User-ID: 4658DA0A8DCBE0F1E44ECFD97B3DC313A8085433941B2A54310658F48C3D5D81 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 4BmQpS5wNXzJmnT; Tue, 8 Sep 2020 19:25:04 -0700 (PDT) Date: Tue, 8 Sep 2020 23:24:29 -0300 From: =?UTF-8?Q?Andr=C3=A9?= Batista Message-ID: <20200909022429.GA24930@andel> References: <20200715211547.GA17146@andel> <20200725144930.GA13751@andel> <20200803125556.GA18868@andel> <87blihhdz6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87blihhdz6.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=riseup.net header.s=squak header.b=lmYC7i0m; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: 7GtaZaqEn6Y+ Hello, seg 07 set 2020 às 16:13:17 (1599505997), ludo@gnu.org enviou: > Hello, > > Woow, thanks for working on this! The end result is functional, right? > Any important missing items? Just a small token of my appreciation for your years of work on guix. I'm glad to be able to give something back to this community. I've been using this package for the last month or so and did not hit any bugs so, though I'm not a heavy web user, I think it's fair to say the result is functional. On the down side, the https-everywhere extension is broken as is since it's missing lib-wasm. I've built but did not send here a version which just copies lib-wasm to its proper place before building the extension and this version works without further issues. The reason I did not send it to this list is that lib-wasm source provides a precompiled prepackaged file[1] which is then used on https-everywhere build script and it's source code is not actualy compiled[2]. As I understand it, the Tor Project just relies on this precompiled binary on its build procedure and the same seems to be true for IceCat[3][4]. In order to have everything compiled from source, I've had to define a lot of rust libs which were required for building wasm-pack and then to have a rustc with wasm32-unknown-unknown target enabled and compatible with wasm-pack (apparently newer versions changed compiler strings and wasm-pack errors out when trying to parse). For over two weeks I've been trying without success and always thinking that the next build would succeed. Long story short, maybe there's just one more issue pending when compiling lib-wasm. When wasm-pack is invoked, everything compiles but I'm getting the following error: note: lld: error: /gnu/store/kwdsf42z7ib6fr5vggqi9nc4jpi1znxy-rust-1.38.0/lib/rustlib/wasm32-unknown-unknown/lib/libstd-373ca16e620a2f9a.rlib: archive has no index; run ranlib to add one for a few rust libs. Without lld, it complains about a missing rust-lld binary. Also, this appears to be the rust standard nowadays[5]. If I'm not terribly wrong, this issue[6] seems to suggest an approach for emscripten which could solve this issue without removing the 'strip' phase which was the work around suggested by some on the same thread. Another issue that is pending is that libwasm depends on rust multi-default-trait-impl crate. This crate defines lgpl2.1+ on its Cargo.toml file, but the sources does not contain neither a copy of the license. So I'm unsure if this is enough to make it free software. So I'm planning on sending some mails to both the maintainer and FSF to see if this needs improvement. > For the final submission, we’d need one patch per new package, as is > customary. That will have the advantage of allowing review to proceed > one bit at a time. :-) For sure. I'll give it a few more tries and cleanup the mess here before sending this patch series. If I don't succeed, I'm planning on sending it anyway so at least the libs can be added and maybe someone can spot what I'm missing. But maybe it's wise to hold Tor Browser itself since there has been an announcement of some large percentage of exit relays messing with Tor traffic[7]. > Regarding Tor Browser itself, can you think of ways to factorize code > with IceCat? Other than sharing the https-everywhere definition, I was thinking maybe we could take a diff of Tor Browser and Firefox and avoid downloading firefox source twice when building both browsers. But I need to take a more careful look. I'll give this question some thought. Cheers, 1. https://docs.rs/crate/https-everywhere-lib-wasm/0.1.2/source/pkg/https_everywhere_lib_wasm_bg.wasm 2. https://github.com/EFForg/https-everywhere/blob/master/make.sh#L113 3. https://git.savannah.gnu.org/cgit/gnuzilla.git/tree/makeicecat?h=68#n565 4. https://git.savannah.gnu.org/cgit/gnuzilla.git/tree/data/extensions/https-everywhere@eff.org/wasm/https_everywhere_lib_wasm_bg.wasm?h=68 5. https://github.com/rust-lang/rust/pull/48125 6. https://github.com/emscripten-core/emscripten/issues/9705 7. https://blog.torproject.org/bad-exit-relays-may-june-2020