From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qGqoA5c5V1/CBgAA0tVLHw (envelope-from ) for ; Tue, 08 Sep 2020 07:58:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6Io9O5Y5V1+yAQAA1q6Kng (envelope-from ) for ; Tue, 08 Sep 2020 07:58:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 481119404C3 for ; Tue, 8 Sep 2020 07:58:14 +0000 (UTC) Received: from localhost ([::1]:59474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFYW3-0004yf-Hw for larch@yhetil.org; Tue, 08 Sep 2020 03:58:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFYVu-0004yP-Dw for guix-patches@gnu.org; Tue, 08 Sep 2020 03:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40231) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFYVu-00072e-4w for guix-patches@gnu.org; Tue, 08 Sep 2020 03:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFYVu-0003VX-3H for guix-patches@gnu.org; Tue, 08 Sep 2020 03:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Sep 2020 07:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43261 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 43261@debbugs.gnu.org Received: via spool by 43261-submit@debbugs.gnu.org id=B43261.159955183813427 (code B ref 43261); Tue, 08 Sep 2020 07:58:02 +0000 Received: (at 43261) by debbugs.gnu.org; 8 Sep 2020 07:57:18 +0000 Received: from localhost ([127.0.0.1]:51775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFYVC-0003UV-Cc for submit@debbugs.gnu.org; Tue, 08 Sep 2020 03:57:18 -0400 Received: from flashner.co.il ([178.62.234.194]:42682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFYVA-0003UG-CS for 43261@debbugs.gnu.org; Tue, 08 Sep 2020 03:57:17 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id 9D4544034D; Tue, 8 Sep 2020 07:57:09 +0000 (UTC) Date: Tue, 8 Sep 2020 10:56:36 +0300 From: Efraim Flashner Message-ID: <20200908075636.GF1643@E5400> References: <20200907180229.29475-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pql/uPZNXIm1JCle" Content-Disposition: inline In-Reply-To: <20200907180229.29475-1-zimon.toutoune@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: OhOS1zMd6nOm --Pql/uPZNXIm1JCle Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 07, 2020 at 08:02:29PM +0200, zimoun wrote: > Dear, >=20 > The first patch fixes the unexpected behaviour of "guix lint": >=20 > guix lint -c description -n > vs > guix lint -n -c description >=20 > Now, if '--no-network' and any checkers are provided using '--checkers' t= hen > the ones requiring Internet access are turned off. >=20 I was going to say I didn't like the '-n' flag but I see it's already there, just not documented in the help message. >=20 > The second patch adds the '--no-checkers' option discussed some time ago.= I > am not convinced by the 'option-checker' helper function. What could be > better? >=20 > Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. >=20 how about '--skip' >=20 > Last, note that '--list-checkers' operates as a dry-run: >=20 > --8<---------------cut here---------------start------------->8--- > ./pre-inst-env guix lint -c description,formatting,synopsis -n -x descrip= tion -l > Available checkers: > - formatting: Look for formatting issues in the source > --8<---------------cut here---------------end--------------->8--- >=20 >=20 > All the best, > simon >=20 > zimoun (2): > lint: Fix '--no-network' option. > lint: Add '--no-checkers' option. >=20 > doc/guix.texi | 9 +++++++ > guix/scripts/lint.scm | 55 +++++++++++++++++++++++++++---------------- > 2 files changed, 44 insertions(+), 20 deletions(-) >=20 >=20 > base-commit: 89e1e4481382d18033a9773b90c09345fa33d6cb > --=20 > 2.28.0 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Pql/uPZNXIm1JCle Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9XOTQACgkQQarn3Mo9 g1EpkxAArAlR8q/hLeSzsAbRmHG/eaYB+VuUYB2f3k03r30te3Q4W5+2BaBpO8B8 YFkHSyxtq1OOtmy1mhXHyzd/+QEbkkzFPETXk4P6qKAXtEbS18jTaSTV50ladt0V runmhZ9JbL7sPcqdiIsTHmO/SNOUN0AuM8XzxViv/VnyEccSCFMoGurFSm/Bz0gR F4Lpjr9tkUUrXw2XsV6bGxFcvIrtSsu1pUVdDF08VF5V4cum4RKIqwxJbksXDMXh PNbsPOp6sfUXLhcZ0e38XaSu6T9nK3Bh0wNOblwtpUrYvCFVRmAp4CG/S5CW/mpc 86SVfKo4Yruvp53w4z1/1LPjQmE8rBpJVn2I802iI21Po2DpjoPqIjc62breFxK/ LoKnhHjnfL0oP/LTuhaTp29B8FkOyPR7lIK2zgPscpfS6UVtpJRglr4QhKBNXgG0 va0raIxmh6m1Ef4FZFEzsKl0Ger176HQ/sjwvtqEw8e73IqKU/Mp43YtLH/SNAdC FgvZvpGUtKy94LXtfkj0iCfrKdwU7X6ZOyPkHhkdD0EYy4UycPMLWo1Rx/4HTdOy zbW9I+a7Rb+Kyzj5EZ4YMxKIqg43xRzOS/vdUYsUKMFwvUS/EOTqtGXqlN2JDw55 AyNBajhaoRrl6+5jTfqZDR6B0Ir/vDkUeu63/bWKhfQHV2xB1E0= =c/4w -----END PGP SIGNATURE----- --Pql/uPZNXIm1JCle--