From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2NbbJ9t1Vl8RVgAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 18:03:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OGgjI9t1Vl/QYQAAbx9fmQ (envelope-from ) for ; Mon, 07 Sep 2020 18:03:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3075A9400EF for ; Mon, 7 Sep 2020 18:03:07 +0000 (UTC) Received: from localhost ([::1]:43568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFLTu-0002sJ-1j for larch@yhetil.org; Mon, 07 Sep 2020 14:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFLTq-0002rg-Nu for guix-patches@gnu.org; Mon, 07 Sep 2020 14:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39232) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFLTq-0002Bu-FH for guix-patches@gnu.org; Mon, 07 Sep 2020 14:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFLTq-0001Jp-Ax for guix-patches@gnu.org; Mon, 07 Sep 2020 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43261] [PATCH 0/2] lint: Fix 'no-network' and add 'no-checkers' options Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43261 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43261@debbugs.gnu.org Cc: zimoun X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15995017775054 (code B ref -1); Mon, 07 Sep 2020 18:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Sep 2020 18:02:57 +0000 Received: from localhost ([127.0.0.1]:50778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLTk-0001JR-Py for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:02:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:38160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFLTj-0001JJ-00 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 14:02:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFLTi-0002pp-QY for guix-patches@gnu.org; Mon, 07 Sep 2020 14:02:54 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:41494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFLTh-0002BR-8E for guix-patches@gnu.org; Mon, 07 Sep 2020 14:02:54 -0400 Received: by mail-wr1-x431.google.com with SMTP id w5so16619634wrp.8 for ; Mon, 07 Sep 2020 11:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Do2XwWA7UicSCEYd2uH680JGcJY/QKZdjyOSwIOigpM=; b=bShEnn3G/XXZDtWR3cdvShPSUvA60AIhB5AdkMZxRBF/FSGY3654Vb8lJfA5nEuoiY C6F4zHCPGwMkhWI06fRzZo46YVGN4nNjGtAQNEloF4ZCelpY2tmeiQhOBUlnTS5i8h+0 1YHQiNpFn1Qpej42/udjZiyOYc2NL802JviBPLrrQWOKslkrodp85er/poMajcW9JmOG SZoZpTjizQFU4wJERvRMh1RqWqoQfO+1lGcKxyN1AqxVxUT9VgGLshS5yb7KNGAfRwNe o1uY4Q2UoV/xzvWR+WyOx1/PWkfrOoKX3E4snv+lEKvg5VxZcRgy0/7YDHYuD41cjI8R itXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Do2XwWA7UicSCEYd2uH680JGcJY/QKZdjyOSwIOigpM=; b=MYL+8JMYAAc+UiVOtPliiXpHRFywthDlJd16ZpipMhhWYf/e4lqDQbOXtxE+h80blv hdATJJtl7SiSvpI/l5fLfBqZ8A92vJnDGlWEkvutKGkT6kP2uFaAdXY82mDF7oKTPiSD yEMuvTd73EBDY+Nao39qvZOeHX2DABTem3IUQIeMOJj5cQJMJALmIj8YuCc8PBfjGrDq lHEsRZJqKWv81kmLwMiZjK5vWCWzbjsZUkfZz6YpEnmSISW9AIKxsWRsJP8VB0/2iCxo +HS0p+iCIYVH7xMQLThmCbTnX9v4DD3W6/in09lKnT/oQ7XTRp0FosxjCrHcA6wC+WCY NCjg== X-Gm-Message-State: AOAM531FTpc3auiiqlBUp3nzRh2sg7ygQAWgZRE8d0vR7/K7AelDsFFm S5RaZYFm5mDsUsaIgDWjZRJkYnedJUw= X-Google-Smtp-Source: ABdhPJwzCllSo2buU/h7Dx6pmMa08+WjXFSF3vHz/KikO2mFVnbucZT6AJCMD3HeGAw7xcBWdewlMw== X-Received: by 2002:adf:91e1:: with SMTP id 88mr22181979wri.305.1599501771109; Mon, 07 Sep 2020 11:02:51 -0700 (PDT) Received: from pfiuh02.univ-paris-diderot.fr ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id 59sm9703052wro.82.2020.09.07.11.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 11:02:50 -0700 (PDT) From: zimoun Date: Mon, 7 Sep 2020 20:02:29 +0200 Message-Id: <20200907180229.29475-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x431.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=bShEnn3G; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 4.09 X-TUID: lRbNtbOmnv8K Dear, The first patch fixes the unexpected behaviour of "guix lint": guix lint -c description -n vs guix lint -n -c description Now, if '--no-network' and any checkers are provided using '--checkers' then the ones requiring Internet access are turned off. The second patch adds the '--no-checkers' option discussed some time ago. I am not convinced by the 'option-checker' helper function. What could be better? Instead of '--no-checkers' maybe '--exclude-checkers' is a better name. Last, note that '--list-checkers' operates as a dry-run: --8<---------------cut here---------------start------------->8--- ./pre-inst-env guix lint -c description,formatting,synopsis -n -x description -l Available checkers: - formatting: Look for formatting issues in the source --8<---------------cut here---------------end--------------->8--- All the best, simon zimoun (2): lint: Fix '--no-network' option. lint: Add '--no-checkers' option. doc/guix.texi | 9 +++++++ guix/scripts/lint.scm | 55 +++++++++++++++++++++++++++---------------- 2 files changed, 44 insertions(+), 20 deletions(-) base-commit: 89e1e4481382d18033a9773b90c09345fa33d6cb -- 2.28.0