From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mOFoLHbUVF+SRwAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 12:22:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WCAeKHbUVF9BZgAAbx9fmQ (envelope-from ) for ; Sun, 06 Sep 2020 12:22:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39D95940390 for ; Sun, 6 Sep 2020 12:22:14 +0000 (UTC) Received: from localhost ([::1]:58304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEtgT-0007pC-8R for larch@yhetil.org; Sun, 06 Sep 2020 08:22:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEtgI-0007os-Ob for guix-patches@gnu.org; Sun, 06 Sep 2020 08:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEtgI-0004kL-Bu for guix-patches@gnu.org; Sun, 06 Sep 2020 08:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEtgI-0001px-8X for guix-patches@gnu.org; Sun, 06 Sep 2020 08:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43219] [PATCH] gnu: Handle nfs-root device strings. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Sep 2020 12:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43219 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan Cc: Mathieu Othacehe , 43219@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 43219-submit@debbugs.gnu.org id=B43219.15993948867019 (code B ref 43219); Sun, 06 Sep 2020 12:22:02 +0000 Received: (at 43219) by debbugs.gnu.org; 6 Sep 2020 12:21:26 +0000 Received: from localhost ([127.0.0.1]:44962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEtfi-0001p8-3q for submit@debbugs.gnu.org; Sun, 06 Sep 2020 08:21:26 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:59620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEtff-0001oy-4c for 43219@debbugs.gnu.org; Sun, 06 Sep 2020 08:21:25 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id A43ED3360BBD; Sun, 6 Sep 2020 14:21:20 +0200 (CEST) Date: Sun, 6 Sep 2020 14:21:18 +0200 From: Danny Milosavljevic Message-ID: <20200906142118.092b702e@scratchpost.org> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/1QVgwQ3rZoO3vErRbLTsr=d"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.39 X-TUID: 9nCZ9VhlB40Q --Sig_/1QVgwQ3rZoO3vErRbLTsr=d Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Stefan, On Sun, 6 Sep 2020 13:52:28 +0200 Stefan wrote: > I=E2=80=99d like to propose these minimal changes to support an NFS as a = root file system. Thanks! > Currently there are three ways to define the root file system: >=20 > =E2=80=A2 (file-system (device (label =E2=80=A6)) =E2=80=A6),=20 > =E2=80=A2 (file-system (device (union =E2=80=A6)) =E2=80=A6),=20 > =E2=80=A2 (file-system (device "") =E2=80=A6). >=20 > The manual does not mention that an NFS is currently not supported as a r= oot file system. However, NFS mounts are possible already with (file-system= (type "nfs") (device "") =E2=80=A6). Yeah. > This patch enables users to use an NFS also as a root file system without= introducing a new syntax. That sounds like a good idea. For the time being, let's just use the string thing for your functionality--nevermind the thing for now. > I was asked before to introduce an record to achieve the same >And I did so, see . >But due to some other PXE efforts =E2=80=93 for which I don=E2=80=99t see = progress =E2=80=93 that >patch got on hold. First, I like to apologize for the huge delay in handling this stuff. My original intent was to let Brice Waegeneire , my GSoC in= tern for network booting, handle your request--both because he needs it anyway a= nd because he presumably has more knowledge on network booting. He's missing = in action (no communication at all) and I gave up having Brice do it. In any case, his GSoC is over. I will now look at your request on my own. I obtained some Raspberry Pis, a NAS with TFTP server support out of the box and I made sure I could manipul= ate the DHCP server I use on my network, so the next step is to try to actually use your patchset myself--which I didn't do before (sorry). I want to note that patches with system tests are processed *much* faster--I don't think many reviewers would go to those lengths I did (obtaining speci= al hardware) in order to test contributions--so usually, it would have been basically stuck forever without system tests. Thanks for persevering on this feature. > However, that record would brake with the compatibility of ho= w an >NFS mount is defined today, and it makes the code much more complex without >having a real gain. The real gain would be this: There are a lot of options that one could need (see https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt . They= have: >* (IP address of the NFS server) >* (name of the directory on the NFS server to mount as /, with = %s as format string in order to substitute client IP address) >* : port (!), rsize, wsize, timeo, retrans, acregmin, acregma= x, acregmin, acregmax, flags (hard, nointr, noposix, cto, ac). >ip=3D::::::: > :: > > This parameter tells the kernel how to configure IP addresses of devices > and also how to set up the IP routing table. It was originally called > `nfsaddrs', but now the boot-time IP configuration works independently of > NFS, so it was renamed to `ip' and the old name remained as an alias for > compatibility reasons. ). I'm just saying that it will become a record over time anyway. But maybe it will be something more general for PXE--hard to tell which is better at this point in time. So nevermind for now. > I think this minimal patch will not conflict with that other PXE effort. >Its only purpose is to enable the use of an NFS as a root file system alre= ady today. Yeah, I agree. However, I cannot see a patch as attachment to your E-Mail. --Sig_/1QVgwQ3rZoO3vErRbLTsr=d Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9U1D4ACgkQ5xo1VCww uqV0IAf/UuCPClO5bYmVdQvDGz2Si0tfkHiYHEdiHiPOsqpLE+xeTMGCqPj8pQ2Z g5Z46qg5OLWODf7fmzSMSEd4EbdrWedbFNmeALGgTi2giEynMXy+Xcs0aKTD4izq eBIN/oej8XpuaZMBC7RMAuhTb8PgAb6WybqcpemJNCUmwA7a35dpyMvp7t7R5Ft0 Ae7XFCp/t+eH8WRbQeUIg6a8TkzbrtLGiP4PNqHmsF9PkVGP/cxr78rvM6/giyuy fdYQUVrw4YXdwQ8RiZ3YFygA64XvgfCqUbdpnW6vD/SpuNCE0IAz4fGUbjRemP4F NAqiwphPD2gr2oGPJxQ6YI18n5q0CQ== =65XK -----END PGP SIGNATURE----- --Sig_/1QVgwQ3rZoO3vErRbLTsr=d--