From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8FEqB6bsU1+faQAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 19:53:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AKfnAqbsU1/cEQAAbx9fmQ (envelope-from ) for ; Sat, 05 Sep 2020 19:53:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58006940221 for ; Sat, 5 Sep 2020 19:53:09 +0000 (UTC) Received: from localhost ([::1]:41746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEeFH-0001nn-2P for larch@yhetil.org; Sat, 05 Sep 2020 15:53:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEeFC-0001nS-Ks for guix-patches@gnu.org; Sat, 05 Sep 2020 15:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEeFC-0006rv-Bg for guix-patches@gnu.org; Sat, 05 Sep 2020 15:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEeFC-0002OF-8Z for guix-patches@gnu.org; Sat, 05 Sep 2020 15:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42458] [PATCH] gnu: Add npiet. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Sep 2020 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42458 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jesse Gibbons Cc: 42458@debbugs.gnu.org, Marius Bakke Received: via spool by 42458-submit@debbugs.gnu.org id=B42458.15993355659164 (code B ref 42458); Sat, 05 Sep 2020 19:53:02 +0000 Received: (at 42458) by debbugs.gnu.org; 5 Sep 2020 19:52:45 +0000 Received: from localhost ([127.0.0.1]:44121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEeEt-0002Ni-15 for submit@debbugs.gnu.org; Sat, 05 Sep 2020 15:52:45 -0400 Received: from flashner.co.il ([178.62.234.194]:55556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEeEo-0002NT-BY for 42458@debbugs.gnu.org; Sat, 05 Sep 2020 15:52:41 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id 634C14000B; Sat, 5 Sep 2020 19:52:32 +0000 (UTC) Date: Sat, 5 Sep 2020 22:51:59 +0300 From: Efraim Flashner Message-ID: <20200905195159.GB1643@E5400> References: <87365fvchn.fsf@gnu.org> <299c431d-40d0-6db3-553f-eb1d4fd69856@gmail.com> <20200819070904.GD10528@E5400> <8705fe29-ed91-acd4-7eb5-a5bdb9c851a9@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FkmkrVfFsRoUs1wW" Content-Disposition: inline In-Reply-To: <8705fe29-ed91-acd4-7eb5-a5bdb9c851a9@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: 0lkQyF0fJRXv --FkmkrVfFsRoUs1wW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 03, 2020 at 10:06:13PM -0600, Jesse Gibbons wrote: > Hello again >=20 > On 8/19/20 1:09 AM, Efraim Flashner wrote: > > Overall looks good, just a few changes before it can be merged: > >=20 > > On Mon, Jul 27, 2020 at 10:05:56PM -0600, Jesse Gibbons wrote: > > > V2 attached. > > >=20 > > > On 7/25/20 9:30 AM, Marius Bakke wrote: > > > > Jesse Gibbons writes: > > > >=20 > > > > > * gnu/packages/piet.scm: New file. > > > > > * gnu/local.mk: Add it. > > > > The patch seems to have been mangled so it does not apply. > > > >=20 > > > > It would be great if you could expand the description with informat= ion > > > > about what the piet language is and why users would want to try it. > > > From 077214a6e13d770f70dfba2a7fe2faf40b1fbc56 Mon Sep 17 00:00:00 20= 01 > > > From: Jesse Gibbons > > > Date: Mon, 20 Jul 2020 20:35:09 -0600 > > > Subject: [PATCH v2 1/1] gnu: Add npiet. > > >=20 > > > * gnu/packages/piet.scm: New file. > > > * gnu/local.mk: Add it. > > > --- > > > gnu/local.mk | 1 + > > > gnu/packages/piet.scm | 60 ++++++++++++++++++++++++++++++++++++++++= +++ > > > 2 files changed, 61 insertions(+) > > > create mode 100644 gnu/packages/piet.scm > > >=20 > > > diff --git a/gnu/local.mk b/gnu/local.mk > > > index 7bae1daf61..fc68786ab6 100644 > > > --- a/gnu/local.mk > > > +++ b/gnu/local.mk > > > @@ -425,6 +425,7 @@ GNU_SYSTEM_MODULES =3D \ > > > %D%/packages/photo.scm \ > > > %D%/packages/phabricator.scm \ > > > %D%/packages/php.scm \ > > > + %D%/packages/piet.scm \ > > > %D%/packages/pkg-config.scm \ > > > %D%/packages/plotutils.scm \ > > > %D%/packages/poedit.scm \ > > > diff --git a/gnu/packages/piet.scm b/gnu/packages/piet.scm > > > new file mode 100644 > > > index 0000000000..e82b2aa339 > > > --- /dev/null > > > +++ b/gnu/packages/piet.scm > > > @@ -0,0 +1,60 @@ > > > +;;; GNU Guix --- Functional package management for GNU > > > +;;; Copyright =C2=A9 2020 Jesse Gibbons > > > +;;; > > > +;;; This file is part of GNU Guix. > > > +;;; > > > +;;; GNU Guix is free software; you can redistribute it and/or modify= it > > > +;;; under the terms of the GNU General Public License as published by > > > +;;; the Free Software Foundation; either version 3 of the License, o= r (at > > > +;;; your option) any later version. > > > +;;; > > > +;;; GNU Guix is distributed in the hope that it will be useful, but > > > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > > > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > +;;; GNU General Public License for more details. > > > +;;; > > > +;;; You should have received a copy of the GNU General Public License > > > +;;; along with GNU Guix. If not, see . > > > + > > > +(define-module (gnu packages piet) > > > + #:use-module (guix packages) > > > + #:use-module (guix download) > > > + #:use-module (guix build-system gnu) > > > + #:use-module (gnu packages gd) > > > + #:use-module (gnu packages groff) > > > + #:use-module (guix licenses)) > > > + > > > + > > > +(define-public npiet > > > + (package > > > + (name "npiet") > > > + (version "1.3e") > > It seems 1.3f has come out in the meantime, can you update to the newer > > version? > >=20 > > > + (source (origin > > > + (method url-fetch) > > > + (uri > > > + (string-append > > > + "https://www.bertnase.de/npiet/npiet-" > > > + version ".tar.gz")) > > > + (sha256 > > > + (base32 > > > + "1i9ihbjmravid3h7wvns712axdl5xn398hk12pvzl79fs5kcf6g= 8")))) > > > + (build-system gnu-build-system) > > > + (inputs > > > + `(("gd" ,gd))) > > Looking at the build output and the test output (and npiet --help) it > > looks like it's missing giflib and libpng. > >=20 > > > + (native-inputs `(("groff" ,groff))) > > > + (synopsis "Piet interpreter") > > > + (description > > > + "Npiet is an interpreter for the piet programming language. In= stead of > > > +text, piet programs are pictures. Commands are determined based on = changes in > > > +color. > > > + > > > +This package includes: > > > +@enumerate > > > +@item npiet, a piet interpreter with debugging capabilities > > > +@item npiet-foogol, a program that builds a piet program from foogol= , an > > > +algol-like language > > > +@item npietedit, an editor for the piet programming language > > > +@end enumerate") > > > + (home-page "https://www.bertnase.de/npiet/") > > > + (license gpl2+))) > > > + > > > --=20 > > > 2.27.0 > > >=20 > > Also, when running npietedit, the program complains about missing wish. > > npietedit should be wrapped with tk, which provides the 'wish' binary. > >=20 > All of these objections have been fixed. See attached patch. >=20 > -Jesse >=20 > From 5e856c667c9763666cfd164735cd854c8dae7804 Mon Sep 17 00:00:00 2001 > From: Jesse Gibbons > Date: Mon, 20 Jul 2020 20:35:09 -0600 > Subject: [PATCH v2 1/1] gnu: Add npiet. >=20 > * gnu/packages/piet.scm: New file. > * gnu/local.mk: Add it. > --- > gnu/local.mk | 1 + > gnu/packages/piet.scm | 55 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 56 insertions(+) > create mode 100644 gnu/packages/piet.scm >=20 > diff --git a/gnu/local.mk b/gnu/local.mk > index d2753f52ae..974d44e481 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -430,6 +430,7 @@ GNU_SYSTEM_MODULES =3D \ > %D%/packages/photo.scm \ > %D%/packages/phabricator.scm \ > %D%/packages/php.scm \ > + %D%/packages/piet.scm \ > %D%/packages/pkg-config.scm \ > %D%/packages/plotutils.scm \ > %D%/packages/poedit.scm \ > diff --git a/gnu/packages/piet.scm b/gnu/packages/piet.scm > new file mode 100644 > index 0000000000..a70089a481 > --- /dev/null > +++ b/gnu/packages/piet.scm > @@ -0,0 +1,55 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2020 Jesse Gibbons > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages piet) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (gnu packages gd) > + #:use-module (gnu packages groff) > + #:use-module (gnu packages image) > + #:use-module (gnu packages tcl) > + #:use-module (guix licenses)) > + > + > +(define-public npiet > + (package > + (name "npiet") > + (version "1.3f") > + (source (origin > + (method url-fetch) > + (uri > + (string-append > + "https://www.bertnase.de/npiet/npiet-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "0nl59fhdqqr7nslxdirdn8nvlq5wws67c7jyx2ckbmxbc9h8bv9d"))= )) > + (build-system gnu-build-system) I added the following to wrap npietedit with wish. (arguments `(#:phases (modify-phases %standard-phases (add-after 'install 'wrap-binaries (lambda* (#:key outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out"))) (wrap-program (string-append out "/bin/npietedit") `("PATH" ":" prefix (,(dirname (which "wish"))))) #t)))))) > + (inputs > + `(("gd" ,gd) > + ("tk" ,tk) > + ("giflib" ,giflib) > + ("libpng" ,libpng))) > + (native-inputs `(("groff" ,groff))) > + (synopsis "Piet interpreter") > + (description > + "An interpreter for the piet programming language") > + (home-page "https://www.bertnase.de/npiet/") > + (license gpl2+))) > + > --=20 > 2.28.0 >=20 I also re-added the description that you had earlier and ordered the inputs alphabetically. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --FkmkrVfFsRoUs1wW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9T7F8ACgkQQarn3Mo9 g1Ewvg//ZWb+AdljQXLBFtcod5ZYBZjttNSvm09RXszd8x0K0SUsR0IGBQrwZXFz tJ3GHBiWH48ToiLNXkI7fU1fMA+Fc8BBRN9hbUkDtfmJDBXg4LtWUCISKGe9XuIA 1XJLnKzitKF2m5ZIuZXcurzCKnHTU1CkZicId05VYZb84PLv6UAvGJLDT+Aphjl+ 6qNiBI81VkhZGsJLDd/cRumlcaSzm0v3jfR5VFs2o/ipOaMD87ha9s7B8mRL8QBu dtc5vlnllpsWtcWHWzWp0rlk/34NBzswiFCq1mGL60Ps3/GKt50M0xiCIRphKlOP 6nC822TOfjEmXmIY1Aek5zQaoX/Vrhctr6nt5CnSz71UZp6nnxCl5TRYUpigURjv BmQRpBRbzzBEkLKRod3M7ifQth4RIdQyy6CjzyJDrpynFJhOQpzLBy8rS0+v+/QK MUVhhZKEqVPvm2kLwbtZD84F3hu+TdjiL2x8d2rb1ytbl+AMywCQGaCm/PAX/+NK HPbIz2WwbsdrlYNcZUFxRdkwunhQG+hcieY9SgnNqCYHGPsRx9NYg2zeGeI03mbq KkCObKkxzSyn+IRuh6Bi1I6RRvCDYGrjq+HphBa2NFvUB2di1fSGsd5WxfW+FsyK SYAhVcKKRs1KKcIQzcL2uxuHUz355nOEkBKf1s/V+g31Uo3WjNQ= =JlB8 -----END PGP SIGNATURE----- --FkmkrVfFsRoUs1wW--