From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AA+zAbzkT1+oKQAA0tVLHw (envelope-from ) for ; Wed, 02 Sep 2020 18:30:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wGI1ObvkT188IwAA1q6Kng (envelope-from ) for ; Wed, 02 Sep 2020 18:30:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2FF2940366 for ; Wed, 2 Sep 2020 18:30:18 +0000 (UTC) Received: from localhost ([::1]:56418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDXWT-0007sh-UG for larch@yhetil.org; Wed, 02 Sep 2020 14:30:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDXWF-0007rc-IM for guix-patches@gnu.org; Wed, 02 Sep 2020 14:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDXWE-00035O-M5 for guix-patches@gnu.org; Wed, 02 Sep 2020 14:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kDXWE-00066W-J4 for guix-patches@gnu.org; Wed, 02 Sep 2020 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43173] Ensure that the correct linux-libre deblobbing scripts are used Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Sep 2020 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43173 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 43173@debbugs.gnu.org Cc: Mark H Weaver , Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159907137223399 (code B ref -1); Wed, 02 Sep 2020 18:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Sep 2020 18:29:32 +0000 Received: from localhost ([127.0.0.1]:60691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDXVk-00065L-A5 for submit@debbugs.gnu.org; Wed, 02 Sep 2020 14:29:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:34930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDXVi-00065D-Dl for submit@debbugs.gnu.org; Wed, 02 Sep 2020 14:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDXVi-0007Ok-7J for guix-patches@gnu.org; Wed, 02 Sep 2020 14:29:30 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:57461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDXVg-0002zE-AV for guix-patches@gnu.org; Wed, 02 Sep 2020 14:29:29 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 57727F8D; Wed, 2 Sep 2020 14:29:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 02 Sep 2020 14:29:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:mime-version:content-type; s=mesmtp; bh=M2jjTV5/f4irCY5TEfeHEC+1DdLNlDWVXk81rhYl+i4=; b=Xl hE1Hw18E3rYgfZ+2NffbrO993cCZmtIen5BFByuGhKJKE5Zd1LASEx70CuSuVZSs DtP6aZ8X5VCIB2MJAAtaiBNiRInbKijBJdKu7O2kmdH/riofqKhA9COoUnN9yJb1 8RQ/GASeNG1Yk4hwyxA/a49zWgXx2z5uCcu/uh1Aw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=M2jjTV5/f4irCY5TEfeHEC+1DdLNl DWVXk81rhYl+i4=; b=YTFzjtqWJQbU619o60uL34eV3yS6mKpmDNBKPxzZjCV6A A5JCaqn6RTARtFuhisaKVdAQkce6Lb6VMJQgX3WtpwXwvqpuFj92JfhiRwCpbIsA s8Q96fbZ6twty1jZ5biOB5+UkBKe27JRHZoYHnDQj+V7VKgtmImCtyyCsHSkceLu eNvZEa6TpSevwiUPPwWnzspalVxPn92fLPSzNH1KHArHCs8JyOiNRhWoMp74Fy0G kcNTyVZWAu9EZypFW8JRUFH2Sv0VUegtEH9Re6E1ZNdEGlJxOmAjKop83a2PrLrr d0x4LxLU9B5hXvGQyUMy62mFPjFn/aJhoeuiuTu2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefledguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkgggtugesghdtreertddtjeenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvg hrnhepudeludeujefggefhteekudekveevueffleefleffgeegteevgeekveehffejteeh necuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeejfedrudeguddruddvjedrudegie enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvgho sehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 54A00306005E; Wed, 2 Sep 2020 14:29:24 -0400 (EDT) Date: Wed, 2 Sep 2020 14:29:22 -0400 From: Leo Famulari Message-ID: <20200902182922.GA26301@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline Received-SPF: pass client-ip=64.147.123.25; envelope-from=leo@famulari.name; helo=wout2-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/02 14:29:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=Xl hE1Hw; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm3 header.b=YTFzjtqW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.11 X-TUID: fc/o3DwFxzaZ --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In recent discussions [0], people raised the possibility that we might accidentally leave non-free firmware blobs in our linux-libre packages. If I understand correctly, the root of the issue is that, currently, we manually specify the versions of the deblobbing scripts. They are not changed with every linux-libre release, so it is usually okay to use an older version number =E2=80=94 the scripts themselves will be identical. However, sometimes the scripts do change, and we might not notice, and thus we would fail to remove every blob from the kernel sources. These two patches should make that failure mode impossible, by 1) making sure that the file names of the deblobbing scripts' store items include the full version number of the kernel and 2) only defining the version in one place. The hashes of the deblob scripts will be checked automatically when Guix downloads them for each new kernel release. I had to move the linux-libre-nnn-version variables to an earlier part of the file, so that they are defined when referenced in the deblob-scripts-nnn procedures. I regret changing the way this code is organized... your advice is welcome! [0] https://lists.gnu.org/archive/html/guix-devel/2020-08/msg00040.html --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl9P5H4ACgkQJkb6MLrK fwgpEA/9GyAQspYSOkYvlPIJT9vidZpcB8RJX/0anf5gLRy/i00FXlA5t8Kx9Ewz 5JSmTjkXftfQfXsOL7ip//XkEHqUBMPU2uhNTUg4SEWmiwoiaWVgwAXXqOoqU2xr Qs5VLL8BNM+So4M926X0+lBld0+e+54RW8bDz6pcofBbzcLb7GZRfeUnj9nJaBPv Bgek3wGERkMivv9stkU55dKLhU55OuFB9O8GNQaZX1EpzOf61uzmNMErmVU4odsX 03IixwDy68hKVBehVg8AqI+eEv/pRu7VnOQ0E3Qum1Wb3wnnZ5dHrBUhz3pvMraZ Ni0NG6OjFK3UUTFMcfBo908BhIzEg+Tan8V2IoknE5VYaXV07ZDPXzRdg9hV3Zlt bFHjxyjKT3HgQIKj56y4XvPg7mIfurrY7kgS8lBD5FgdOt1DE7eVCOHliHRwqP3c 8mVeu1nNHyYf8BLE2JViwmTdbagJY49FJ8Ak1zIb2elEKYsGrExkxcfkWZ3mnGF5 WloquobBnbfLxQcdwmGV7VTHiYniHkW37iR/idb5wx9gupR+xP224caS3GuU8y2X ZdyqZ+FjP1P0mFb1hQd8SPMox1bC8rLCuQw7eZkKv/Gn9sVP4XI+vQ3DJC6tcurm mizpNXGDwONxNBkyKi3HQEWpITSan1XW7jlgDSBfmoFsr0xNiyk= =0LIu -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--