unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 43042-done@debbugs.gnu.org
Subject: bug#43042: [PATCH] gnu: Add libflame.
Date: Thu, 27 Aug 2020 18:20:03 +0300	[thread overview]
Message-ID: <20200827152003.GM30372@E5400> (raw)
In-Reply-To: <87k0xkh4sa.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

On Thu, Aug 27, 2020 at 10:27:49AM +0200, Mathieu Othacehe wrote:
> 
> Hello Efraim,
> 
> > +             "--enable-verbose-make-output"
> > +             "--enable-multithreading=pthreads" ; Openblas isn't built with openmp.
> > +             ,@(if (any (cute string-prefix? <> (or (%current-target-system)
> > +                                                    (%current-system)))
> > +                        '("x86_64" "i686"))
> 
> I thought we had a "target-intel?" or such in (guix utils), but it seems
> we don't. Maybe it could be useful addition.
> 
> Otherwise, looks good!
> 
> Thanks,
> 
> Mathieu

Thanks for the review. Patch pushed!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-08-27 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 15:54 [bug#43042] [PATCH] gnu: Add libflame Efraim Flashner
2020-08-27  8:27 ` Mathieu Othacehe
2020-08-27 15:20   ` Efraim Flashner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827152003.GM30372@E5400 \
    --to=efraim@flashner.co.il \
    --cc=43042-done@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).