unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Martin Becze <mjbecze@riseup.net>
Cc: 42935-done@debbugs.gnu.org
Subject: bug#42935: [PATCH] gnu: Add nicotine.
Date: Sat, 22 Aug 2020 12:52:24 -0400	[thread overview]
Message-ID: <20200822165224.GC6896@jasmine.lan> (raw)
In-Reply-To: <20200819170318.20989-1-mjbecze@riseup.net>

On Wed, Aug 19, 2020 at 12:03:18PM -0500, Martin Becze wrote:
> * gnu/packages/nicotine.scm (nicotine): New variable.

Thank you! Awesome! Back to the future :)

I pushed with the following changes:

I also registered the new file in gnu/local.mk. Otherwise, it won't be
included in distribution tarballs.

> +(define-public nicotine
> +  (package
> +    (name "nicotine")

I changed it to be named "nicotine+". The plus sign is okay for Guix and
more accurate.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/Nicotine-Plus/nicotine-plus")
> +                    (commit version)))
> +              (sha256 (base32 "07xagm6kwy8b6gcdv5vx78yqfllkz1gvlakkf0hi2c9ivncq457g"))))

I added a file-name field so that the source code checkout would have a
descriptive name, and to satisfy `guix lint`.

> +         (add-after 'install 'wrap-assword

I renamed this phase to 'wrap-program'.




  reply	other threads:[~2020-08-22 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 17:03 [bug#42935] [PATCH] gnu: Add nicotine Martin Becze
2020-08-22 16:52 ` Leo Famulari [this message]
2020-08-22 19:57   ` Martin Becze
2020-08-22 19:57   ` Martin Becze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200822165224.GC6896@jasmine.lan \
    --to=leo@famulari.name \
    --cc=42935-done@debbugs.gnu.org \
    --cc=mjbecze@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).