From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gA9EMdEMNV9tPgAA0tVLHw (envelope-from ) for ; Thu, 13 Aug 2020 09:50:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EC3rLNEMNV8LYgAAbx9fmQ (envelope-from ) for ; Thu, 13 Aug 2020 09:50:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4FAD894005D for ; Thu, 13 Aug 2020 09:50:09 +0000 (UTC) Received: from localhost ([::1]:37860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k69s8-0005aa-AS for larch@yhetil.org; Thu, 13 Aug 2020 05:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k69s2-0005aS-Fi for guix-patches@gnu.org; Thu, 13 Aug 2020 05:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k69s2-0001ez-6y for guix-patches@gnu.org; Thu, 13 Aug 2020 05:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k69s2-0001sI-5B for guix-patches@gnu.org; Thu, 13 Aug 2020 05:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42049] [PATCH 0/4] build-system/cargo: Propagations across the crate closure. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 Aug 2020 09:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42049 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 42049@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15973121627156 (code B ref -1); Thu, 13 Aug 2020 09:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Aug 2020 09:49:22 +0000 Received: from localhost ([127.0.0.1]:46940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k69rO-0001rM-97 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 05:49:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:40328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k69rM-0001rE-0G for submit@debbugs.gnu.org; Thu, 13 Aug 2020 05:49:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k69rL-0005Z7-Nh for guix-patches@gnu.org; Thu, 13 Aug 2020 05:49:19 -0400 Received: from flashner.co.il ([178.62.234.194]:53846) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k69rK-0001cj-1J for guix-patches@gnu.org; Thu, 13 Aug 2020 05:49:19 -0400 Received: from localhost (unknown [31.210.177.29]) by flashner.co.il (Postfix) with ESMTPSA id 9B32D4000F; Thu, 13 Aug 2020 09:49:15 +0000 (UTC) Date: Thu, 13 Aug 2020 12:48:43 +0300 From: Efraim Flashner Message-ID: <20200813094843.GC1228@E5400> References: <20200625212523.25016-1-kuba@kadziolka.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s9fJI615cBHmzTOP" Content-Disposition: inline In-Reply-To: <20200625212523.25016-1-kuba@kadziolka.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 04:28:18 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: pQPgtOEVJ/Iu --s9fJI615cBHmzTOP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 25, 2020 at 11:25:23PM +0200, Jakub K=C4=85dzio=C5=82ka wrote: > Due to the unusual (for Guix) compilation model used by > cargo-build-system, any phases or inputs added by a given library crate > need to be duplicated in all its dependents. This patchstack attempts to > solve this by allowing to propagate inputs, native-inputs and phases > across cargo-inputs edges in the dependency graph. >=20 > Apart from the build system work itself, I have included samples of the > cleanup they allow. Apart from being a good example, these are the > changes I have used to test the feature. >=20 > Jakub K=C4=85dzio=C5=82ka (4): > build-system/cargo: Allow propagating inputs across CARGO-INPUTS edges > gnu: crates-io: Use propagated-inputs and propagated-native-inputs. > build-system/cargo: Add a propagated-phases argument. > gnu: crates-io: Use propagated-phases. >=20 > gnu/packages/crates-io.scm | 157 +++++++++++------------------------- > gnu/packages/rust-apps.scm | 9 +-- > gnu/packages/sequoia.scm | 3 +- > guix/build-system/cargo.scm | 92 +++++++++++++++------ > 4 files changed, 120 insertions(+), 141 deletions(-) >=20 > --=20 > 2.26.2 >=20 I'm going to respond here so the thoughts don't get lost. While it would take care of some of the issues we have regarding adding regular inputs or propagated-/native- inputs, I don't think this is the way we want to go. If we can't figure out how to re-use build artifacts then I'd rather copy the go-build-system and install the sources into the output and use that as the input for the next package. That would give us the build-graph which we really want. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --s9fJI615cBHmzTOP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl81DHgACgkQQarn3Mo9 g1GcNRAAtcLi609PF7MtuCfbmrubnmZ4+uP8Z1idngrVOxgN/xAdtqHmCjTjukcg dH31/AKm1PvTteFKps5X95b2OzOtlvsOhzn2AU8kmCrnP1qUnLLRbrIymy0I0GLe UIRJmbc/QPhdia670reP6OJ/l1HC9xWnnBofccdNSj0gvdKWsyrB6sImNfhrZ6aH Z+b+54B8QiN8syMoB8dQd2QKG0rREj7Nnr40+4uRyHFa3SzYhkETA297V177wZKl ADueC2qP48Cc2vJSxoOvA4/22LIsFfeWcI7tdWJskvGJByK4uAcfsuO6TxxZ71Pa leQ8fXjLDZi5/rf3OvIa5oqZYGpvnwTRY/FZiKE1YlmZ9c0J2EW/CXDKHC1AUttq 2jS3obNivfkkBE/6yuI8uXkVfKiYByLYBhcl/vYZBVN1zYNQ8HCDN1NlQ+2x4LPU g/QbZ9SfTaO1GVBK9HJXdBwoHTKV47ASoC4W2XLzbbuczR0mTX2Gd50uNJ2V6QMK 3AHUn7/l2Iegg6v8rxLCp6ALQkG97BKojahj7AP2NsA0DdZHz1YgTk/BTB39QQX7 krUs+fWBm+qLkRu00BK5EJu16BTDCFdiARad23YdD/8kD+fwVIN5/hQyztO+xOnK 0Vz0tgxum6l+KnPERJqljXRI4VkRa7HM/o1xJfE1utyEAVhK9U4= =hh+1 -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP--