From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yPvnCMhcMV83YAAA0tVLHw (envelope-from ) for ; Mon, 10 Aug 2020 14:42:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SLCZBMhcMV8FVgAAbx9fmQ (envelope-from ) for ; Mon, 10 Aug 2020 14:42:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C9849402A2 for ; Mon, 10 Aug 2020 14:42:15 +0000 (UTC) Received: from localhost ([::1]:48628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k590A-0001Cd-Fe for larch@yhetil.org; Mon, 10 Aug 2020 10:42:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k58zy-0001BY-Pp for guix-patches@gnu.org; Mon, 10 Aug 2020 10:42:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k58zy-0001Nb-Gn for guix-patches@gnu.org; Mon, 10 Aug 2020 10:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k58zy-0006Yt-Eo for guix-patches@gnu.org; Mon, 10 Aug 2020 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42752] [PATCH core-updates] gnu: bash: Make completions work in non-login shells. Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42752 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42752@debbugs.gnu.org Received: via spool by 42752-submit@debbugs.gnu.org id=B42752.159707050825202 (code B ref 42752); Mon, 10 Aug 2020 14:42:02 +0000 Received: (at 42752) by debbugs.gnu.org; 10 Aug 2020 14:41:48 +0000 Received: from localhost ([127.0.0.1]:37091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k58zj-0006YP-Ou for submit@debbugs.gnu.org; Mon, 10 Aug 2020 10:41:47 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:38410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k58zg-0006YF-II for 42752@debbugs.gnu.org; Mon, 10 Aug 2020 10:41:46 -0400 Received: (qmail 31031 invoked by uid 1009); 10 Aug 2020 16:41:42 +0200 Received: from nat-0.staszic.waw.pl (kuba@kadziolka.net@nat-0.staszic.waw.pl) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25899. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(94.240.45.201):. Processed in 0.05902 secs); 10 Aug 2020 14:41:42 -0000 Received: from nat-0.staszic.waw.pl (HELO gravity) (kuba@kadziolka.net@94.240.45.201) by pat.zlotemysli.pl with SMTP; 10 Aug 2020 16:41:42 +0200 Date: Mon, 10 Aug 2020 16:41:41 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200810144141.52fpzv6m4kqp3jix@gravity> References: <20200807221439.729-1-kuba@kadziolka.net> <87k0y6hmyv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7vfnulwkbhqc3sw6" Content-Disposition: inline In-Reply-To: <87k0y6hmyv.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: xK8XUMExhpug --7vfnulwkbhqc3sw6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2020 at 11:25:12AM +0200, Mathieu Othacehe wrote: >=20 > Hey Jakub, >=20 > > Currently, /etc/bashrc is only loaded by /etc/profile. Because the > > former is responsible for setting up command-specific completions, they > > currently only work in login shells. This patch configures bash to load > > /etc/bashrc in interactive non-login shells, as by default no > > system-wide configuration is loaded. >=20 > /etc/bashrc is also loaded by ~/.bashrc in "default-skeletons". So your > patch would cover the case of an interactive, non-login shell run by a > logged in user without the default ~/.bashrc file, right? Oh! It seems I overwrote it with my own .bashrc when I migrated my dotfiles. I still think this patch is a good idea - I think we should make /etc/skel/.bashrc contain only nice-to-have defaults, such as changing the prompt based on $GUIX_ENVIRONMENT, and move the essential things to /etc/bashrc. That way, overwriting the .bashrc won't break anything important. I guess I should follow this patch up with an adjustment to /etc/skel/.bashrc, removing the 'source /etc/bashrc' line? Regards, Jakub K=C4=85dzio=C5=82ka --7vfnulwkbhqc3sw6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl8xXKAACgkQ4xWnWEYT FWRRdg/9G45UuvM3NwhmGMMZchWRsJDLCUfWczIrfOKp7LVhFRCWzZALTe5NntOd p7NufYD2dgMFfnw2RaWBYHf7k1rE8EIEoGp1C4f1UF92X+G/+TAZEO95c/yk89MM Z4LsGz7hn9ceLFeo11k5mxqwEhj0KVxtbzC2NRg2SeTYPIcG+Sb4Eo79fnEANZa2 2SsJ5oWQnDIYDG/JqLhOZEk3QxTmNp0Orzlx7yte0K/XbkLUt05ETFZuDNDHvHhs 8PaVobUHSH5Mjm9xukqgLLQ8A24LcsZbXgSslAafydKRphkzKn7HN4tl9Ug2qn+6 ntFCUxGqwNmicW8EzoOWFClL1WsDYCAX2BpttI7NCl1qdBrPnpCIC2R8esOJv/ew V7qL1QAIl8FZIZtehBmQ0qukDAz0sSHWUfnbKV6zLi8m9OvU5fguot7HqxFGKU3B +F1Xu7GUgetIScNpLeT+Rsb4PYAfJmWSGoF+qMEOCcuJCtR/q9Z6MAe1iYkV9wa6 kh6Ehx5dBjUNkSJBOwH+YqrHA1IwfDnPe55kTgl4zyAy0C/jnqUcBO0zobhB/Eul VYNGL2O/APbkJME/CzlgZ3N+MniBeDx9t8TCANHg1yyuagJtdsghtHSfI2l2qUyS kNk7a/z89j8gT99VSGAecp1McuKWsvu4PKAE4UnZsBgbSdejbZY= =zA6M -----END PGP SIGNATURE----- --7vfnulwkbhqc3sw6--