From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UJC8K5tXMV8DJAAA0tVLHw (envelope-from ) for ; Mon, 10 Aug 2020 14:20:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oMvBJ5tXMV8dTQAA1q6Kng (envelope-from ) for ; Mon, 10 Aug 2020 14:20:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 330A99400BF for ; Mon, 10 Aug 2020 14:20:11 +0000 (UTC) Received: from localhost ([::1]:59466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k58eo-000197-5c for larch@yhetil.org; Mon, 10 Aug 2020 10:20:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k58eh-00018u-5e for guix-patches@gnu.org; Mon, 10 Aug 2020 10:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k58eg-0006wp-S9 for guix-patches@gnu.org; Mon, 10 Aug 2020 10:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k58eg-0003nf-Jd for guix-patches@gnu.org; Mon, 10 Aug 2020 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42792] [PATCH] gnu: Add python-pydantic. Resent-From: Tanguy Le Carrour Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42792 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42792-done@debbugs.gnu.org Received: via spool by 42792-done@debbugs.gnu.org id=D42792.159706915914554 (code D ref 42792); Mon, 10 Aug 2020 14:20:02 +0000 Received: (at 42792-done) by debbugs.gnu.org; 10 Aug 2020 14:19:19 +0000 Received: from localhost ([127.0.0.1]:37049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k58dz-0003mf-JK for submit@debbugs.gnu.org; Mon, 10 Aug 2020 10:19:19 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k58dx-0003mL-Lv for 42792-done@debbugs.gnu.org; Mon, 10 Aug 2020 10:19:18 -0400 X-Originating-IP: 176.159.32.89 Received: from localhost (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AD92FFF807; Mon, 10 Aug 2020 14:19:11 +0000 (UTC) Date: Mon, 10 Aug 2020 16:19:11 +0200 From: Tanguy Le Carrour Message-ID: <20200810141911.jtpjdeylftxiyk6q@rafflesia> References: <20200810084343.10734-1-tanguy@bioneland.org> <87wo26g6ji.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wo26g6ji.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: YoidwlnNVEqd Hi Mathieu, Le 08/10, Mathieu Othacehe a écrit : > > * gnu/packages/python-xyz.scm (python-pydantic): New variable. > > Applied with the following diff: > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index a36e99aa32..4102902465 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -3829,30 +3829,32 @@ Language (TOML) configuration files.") > (method git-fetch) > (uri (git-reference > (url "https://github.com/samuelcolvin/pydantic") > - (commit (string-append "v" version)))) > + (commit (string-append "v" version)))) > (file-name (git-file-name name version)) > - (sha256 (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8")))) > + (sha256 > + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8")))) Thanks for paying attention to every details!! Actually, those things have been bothering me for quiet a while… They are not reported by `./pre-inst-env guix lint python-pydantic` or fixed by `emacs --script etc/indent-code.el gnu/packages/python-xyz.scm python-pydantic`. :-( Would the following have been acceptable? ``` > + (sha256 (base32 > + "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8")))) ``` And what about this? (2-space indent instead of 1, like `add-before` below) ``` > + (sha256 > + (base32 "1380s9k77g6q15by9fkxndczjk89q6xpz09jdrqip535xws2z3j8")))) ``` > (build-system python-build-system) > (arguments > '(#:phases > (modify-phases %standard-phases > - ;; Reported upstream: > - ;; Not sure how to apply the suggested fix!? > + ;; Reported upstream: > + ;; . > + ;; Disable the faulty test as the fix is unclear. Much better, thanks! In retrospect, I realize that I should have put the question in the commit message for a maintainer to read, not in the package definition. Would that have been better?! > (add-before 'check 'disable-test > (lambda _ > (substitute* "tests/test_validators.py" > (("test_assert_raises_validation_error") > - "_test_assert_raises_validation_error")) > + "_test_assert_raises_validation_error")) > #t)) > (replace 'check > (lambda _ (invoke "pytest" "-vv" "tests")))))) > (native-inputs > `(("python-pytest" ,python-pytest))) > (home-page "https://github.com/samuelcolvin/pydantic") > - (synopsis "Data validation and settings management using python type hinting") > + (synopsis "Python data validation and settings management") Sorry, I still suck at synopsis! :-( > (description > - "Pydantic enforces type hints at runtime, and provides user friendly errors > -when data is invalid.") > + "Pydantic enforces type hints at runtime, and provides user friendly > +errors when data is invalid.") > (license license:expat))) Thanks! -- Tanguy