From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oKMVKWG9MF8qFwAA0tVLHw (envelope-from ) for ; Mon, 10 Aug 2020 03:22:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IObZJGG9MF+faAAAbx9fmQ (envelope-from ) for ; Mon, 10 Aug 2020 03:22:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 28FC694066A for ; Mon, 10 Aug 2020 03:22:08 +0000 (UTC) Received: from localhost ([::1]:42412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4yNy-0004jQ-F3 for larch@yhetil.org; Sun, 09 Aug 2020 23:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4yNu-0004j4-Aq for guix-patches@gnu.org; Sun, 09 Aug 2020 23:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4yNu-0007bw-2H for guix-patches@gnu.org; Sun, 09 Aug 2020 23:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4yNt-0007ls-Sb for guix-patches@gnu.org; Sun, 09 Aug 2020 23:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42734] Export android-platform-system-core Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Aug 2020 03:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42734 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 42734@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 42734@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159702969629825 (code B ref -1); Mon, 10 Aug 2020 03:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Aug 2020 03:21:36 +0000 Received: from localhost ([127.0.0.1]:33799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yNU-0007kz-0V for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:21:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:44874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yNQ-0007kq-DE for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4yNQ-0004h3-7b for guix-patches@gnu.org; Sun, 09 Aug 2020 23:21:32 -0400 Received: from cyberdimension.org ([80.67.179.20]:59086 helo=gnutoo.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1k4yNN-0007Za-Vl for guix-patches@gnu.org; Sun, 09 Aug 2020 23:21:31 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id e300430b; Mon, 10 Aug 2020 03:21:06 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 3e005ae7; Mon, 10 Aug 2020 03:21:06 +0000 (UTC) Date: Mon, 10 Aug 2020 05:19:49 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200810051949.737d799e@primarylaptop.localdomain> In-Reply-To: <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> References: <20200807024423.1638d242@primarylaptop.localdomain> <13A86DDA-5411-495A-B6AC-042A9F932065@lepiller.eu> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/8nTri74povrZU4F_D+WD4TD"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=80.67.179.20; envelope-from=GNUtoo@cyberdimension.org; helo=gnutoo.cyberdimension.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/09 23:21:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: 5FZ2lJrIMWpu --Sig_/8nTri74povrZU4F_D+WD4TD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 07 Aug 2020 07:33:03 -0400 Julien Lepiller wrote: > Unfortunately, android-platform-core should first be fixed to accept > a hash as an argument, otherwise any other version will fail. Don't > know why we haven't done that before=E2=80=A6 I don't understand what the hash would be here, nor the consequences you describe. Do you have some pointers on the documentation or source code that I should read to better understand that? By the way I find it a bit strange to refer to have to manually extract=20 android-platform-system-core to be able to refer its include path. Beside the native-input, this results in the following code: > #:make-flags (list (string-append "CFLAGS=3D " > "-I core/include " > [...])) > > [...] > > #:phases > (modify-phases %standard-phases > (add-after 'unpack 'unpack-core > (lambda* (#:key inputs #:allow-other-keys) > (mkdir-p "core") > (with-directory-excursion "core" > (invoke "tar" "axf" (assoc-ref inputs "android-core") > "--strip-components=3D1")) > #t)) > [...]) Instead of just that: > #:make-flags (list (string-append "CFLAGS=3D " > "-I " (assoc-ref %build-inputs "android-core") > "/include ")) > [...])) Another potential improvement would be to remove the android-platform-version argument completely and set version to it in android.mk like that: > (define-public (android-platform-system-core > [...] > (version (android-platform-version)) > [...] That would make the native-input look like that: > (native-inputs > `( > ("android-core" ,android-platform-system-core))) And if we need the version 9.0.0_r3 we could define a new package: > (define-public android-platform-system-core-9 > (package > (inherit android-platform-system-core) > (version "9.0.0_r3")))) and use it: > (native-inputs > `( > ("android-core" ,android-platform-system-core-9))) Are both proposal a good idea? Or does it have any downsides that I didn't think of? Denis. --Sig_/8nTri74povrZU4F_D+WD4TD Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8wvNUACgkQX138wUF3 4mMbew//QWCDdDPwInEmtWTlmecXVoOze13W2YNyGiiokobXtRSh3poXYkmdxAXG 9ytz0AD8kEmGsiUA3iTXzSpeyaU0C9WIvWjpXBP4YgHUyJ8Vw/refwsMxvHR1MrX suMKektikY0WPShh2NW4VsoaNiWjmrIhbTKtS30FOwO5gECKOYyts2VyTcaQCUTP cbjPGqOlOIiiZmF6vj0ETGEfJ6YIwmTaJtLEYhYKwMAGKWl6R86btKmT6cEauTyh ZlzdMyiWf/lxOB6OuCvzNInom9J0kXRdlk0rRsFKfMqLs2upjaGMyFGF9/lmV1O2 0OADkcIfqNGoNj0IgxUCTsvrwvCg4WbqqPmcLQWizQhBgpzLX60eTML1SVM47dar aISui4m3XywHBmUqfpmpKwxaxPh+VJ4qjF7iTt18D8GucjCDoWyavfT1MjBStZs9 V+QewJ/JRDhhtpOrZbHiHb2PWS//s6NEV2QNzJhEb5gljdwKC7l0FP4c2RF7KWqw NQBarApNStNXs0MfLmvRqDCCrlIgs5q/tWrXtqIApt92Po428eZ0eBEWunTxjNX+ JIjLgePle2uo0peXRZvVu6oZdfyR9BlVFshyin9VuD0oiB1uDsjo73Ko8jSNbU+B 1mpkyf0aDptp96wmkxd3gY4noutXLDs/l4I2I65pHeOLnxy2FXk= =/YNc -----END PGP SIGNATURE----- --Sig_/8nTri74povrZU4F_D+WD4TD--