From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MK1JFRS/L1+JDAAA0tVLHw (envelope-from ) for ; Sun, 09 Aug 2020 09:17:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6AkWERS/L1+cXQAAB5/wlQ (envelope-from ) for ; Sun, 09 Aug 2020 09:17:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B66379403A9 for ; Sun, 9 Aug 2020 09:17:07 +0000 (UTC) Received: from localhost ([::1]:49042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4hRy-0005Rc-JK for larch@yhetil.org; Sun, 09 Aug 2020 05:17:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4hRu-0005RR-6i for guix-patches@gnu.org; Sun, 09 Aug 2020 05:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4hRt-0006wJ-SN for guix-patches@gnu.org; Sun, 09 Aug 2020 05:17:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4hRt-0007in-JJ for guix-patches@gnu.org; Sun, 09 Aug 2020 05:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42735] [PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 09 Aug 2020 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42735 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42735@debbugs.gnu.org Received: via spool by 42735-submit@debbugs.gnu.org id=B42735.159696459729643 (code B ref 42735); Sun, 09 Aug 2020 09:17:01 +0000 Received: (at 42735) by debbugs.gnu.org; 9 Aug 2020 09:16:37 +0000 Received: from localhost ([127.0.0.1]:59946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4hRV-0007i2-6X for submit@debbugs.gnu.org; Sun, 09 Aug 2020 05:16:37 -0400 Received: from cyberdimension.org ([80.67.179.20]:47498 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4hRR-0007hr-Oa for 42735@debbugs.gnu.org; Sun, 09 Aug 2020 05:16:35 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 1266990f; Sun, 9 Aug 2020 09:16:19 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id fa49de67; Sun, 9 Aug 2020 09:16:19 +0000 (UTC) Date: Sun, 9 Aug 2020 11:09:39 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200809110939.407b0bb9@primarylaptop.localdomain> In-Reply-To: <87mu36onjj.fsf@gnu.org> References: <20200807022142.26296-1-GNUtoo@cyberdimension.org> <87mu36onjj.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/k6HIh0xznJU=Y6zTMyCnl4Z"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: 40VMMoOF/niN --Sig_/k6HIh0xznJU=Y6zTMyCnl4Z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 07 Aug 2020 10:41:52 +0200 Mathieu Othacehe wrote: > Let say you have a custom my-hello package inheriting from hello, and > you want to build it on top of a recent Guix checkout, then you > probably want GUIX_PACKAGE_PATH to cooperate with pre-inst-env. >=20 > Same goes if you have a manifest mixing Guix packages and custom > packages accessed by GUIX_PACKAGE_PATH, and you want to test your > manifest on top of a Guix checkout using pre-inst-env. Thanks for the explanation. What would be the way for both use cases to be addressed? Should a warning be emitted when packages come from GUIX_PACKAGE_PATH with ./pre-inst-env ? What about something that would look like that: > guix build: warning: GUIX_PACKAGE_PATH is set > guix build: warning: choosing my-hello@0.1 from > /home/[...]/.config/guix/local/custom.scm:31:2 > guix build: warning: If you don't want to use > packages from GUIX_PACKAGE_PATH you can run > 'unset GUIX_PACKAGE_PATH' before running > pre-inst-env The issue is if it picks dependencies from GUIX_PACKAGE_PATH which are not in Guix source code yet. In that case it might be more complicated to make sure that people will see the warning as it might be hidden in the huge build log. Another option which can also be combined with the previous one would be to warn people in the manual. Note that I'm also fine with the status quo, but if it's not too complicated to improve the situation in a way that doesn't break existing use cases it would probably make sense to do it. Denis. --Sig_/k6HIh0xznJU=Y6zTMyCnl4Z Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8vvVQACgkQX138wUF3 4mPTRQ//WYGSrgkkVctf7YmWqK0C0AQK4OI2oHm0aes74xDUNLrib6hV3I9w7iNq qDdXF9Xn/QW08yNw/TYFQe150ltKnF7e9MubkbjK+PSujx+hrmLK0R+oMFcnfJgi u0cwSV8ST19BxtkDS1TVtFvf93kbGgQ9Ag5zTDq5nH3NvYl2ZBiwYDYc5yFM3GKj kV7qWijl2Coa1v822yL5dHN1HKBmgpbqHUpexpq01NlnEfDb+tZNFikZsa+tcoHc IK6vXTkJBLG0nKmv835v+6DWOJrESAetXxVMYlfG1nahXUGF+Ajqi2fxApZnwzGU 79b8GRPolSkMN7gaksiXzU0WZsGr/tZPIXsyVy2UzdNmjHt2Fd9shTLw0lR56ZZo NSVdQxH1d/LNQt/6KdW809cK4nXkPiZYsLcOwD5SAwpFfLrCNGihgUcFrZpHngUP tEJfmHTqDI2GyjXVRpJ81Imhd+D1a/3LwjqWzlKbDj45l57L3NO3EJb+lv/dGH15 OUzO96Cx7w9DC0y83I/MLnHU3eJSCJk7bulqnZYmeiDa4hj8EzJBmnggfYk1x03o c0fi//+0knGclt8NITuoSPrGZiXm29cTbQNY1IIlyT/ENduavSv4kQIvjDoXSQLR 5XD8a1bh94tz7SehSXS3YP/Hnrl2jLEHnjFHzkYEQRa6qfDeCJA= =vvTS -----END PGP SIGNATURE----- --Sig_/k6HIh0xznJU=Y6zTMyCnl4Z--