From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AKQHHQbwLF8BSgAA0tVLHw (envelope-from ) for ; Fri, 07 Aug 2020 06:09:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KOUaGQbwLF8pJwAAB5/wlQ (envelope-from ) for ; Fri, 07 Aug 2020 06:09:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7AFA940367 for ; Fri, 7 Aug 2020 06:09:09 +0000 (UTC) Received: from localhost ([::1]:55254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3vYx-00018w-No for larch@yhetil.org; Fri, 07 Aug 2020 02:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3vYs-00018S-Nk for guix-patches@gnu.org; Fri, 07 Aug 2020 02:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43951) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3vYs-0003cF-Ez for guix-patches@gnu.org; Fri, 07 Aug 2020 02:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3vYs-0002J1-7t for guix-patches@gnu.org; Fri, 07 Aug 2020 02:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42735] [PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Aug 2020 06:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42735 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 42735@debbugs.gnu.org Received: via spool by 42735-submit@debbugs.gnu.org id=B42735.15967804828787 (code B ref 42735); Fri, 07 Aug 2020 06:09:02 +0000 Received: (at 42735) by debbugs.gnu.org; 7 Aug 2020 06:08:02 +0000 Received: from localhost ([127.0.0.1]:55497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3vXu-0002HW-0P for submit@debbugs.gnu.org; Fri, 07 Aug 2020 02:08:02 -0400 Received: from cyberdimension.org ([80.67.179.20]:43976 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3vXr-0002HH-Tm for 42735@debbugs.gnu.org; Fri, 07 Aug 2020 02:08:00 -0400 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id 173a7a98; Fri, 7 Aug 2020 06:05:01 +0000 (UTC) Received: from primarylaptop.localdomain (localhost.localdomain [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 9a08fc1a; Fri, 7 Aug 2020 06:05:01 +0000 (UTC) Date: Fri, 7 Aug 2020 08:02:04 +0200 From: Denis 'GNUtoo' Carikli Message-ID: <20200807080204.0b2f9b9d@primarylaptop.localdomain> In-Reply-To: <87o8nni0cz.fsf@gnu.org> References: <20200807022142.26296-1-GNUtoo@cyberdimension.org> <87o8nni0cz.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/8CAyLauaXGd8JyBp=IAXQll"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: nzzpXWKj5lB+ --Sig_/8CAyLauaXGd8JyBp=IAXQll Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 06 Aug 2020 22:46:52 -0500 Brett Gilio wrote: > Denis 'GNUtoo' Carikli writes: >=20 > > =20 > > +# Make sure we don't use local package definitions > > +GUIX_PACKAGE_PATH=3D"" > > +export GUIX_PACKAGE_PATH > > + > > exec "$@" >=20 > Wouldn't it make more sense to use `unset` instead of defining an > empty variable? I used export and defined an empty variable because I don't know how to write portable shell scripts and export was already used in build-aux/pre-inst-env.in. Is unset portable? If so should I resend a patch with unset instead? Denis. --Sig_/8CAyLauaXGd8JyBp=IAXQll Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAl8s7lwACgkQX138wUF3 4mM6eA//cKAfT/kgMNsYchvV2Koet5Kloyf/zx1f63QkwdietPJFLaVf5majabhx NvQu0RBH8cSay5pKed+fEmSWWFVRCJAIymzzafo2A6pGzJB3naQYxGtUQUY3K62Y 98j6q72B3wlz+RNJmCJwzcxFU+4UOb7yCsvFIX5B+0WexRGqKJYzYfx9FK04LyUq IRaUNQ86028qtrrxV2QYyWrRDY7l9JTupmGv+4qZIaJfInlhrpY6r9Imrg7T8xiG FBOUVtwFlQ/F8hjk/y0/bOgby4cxMQe2kgcMdKLBzSRU8TwAs7+PgqYbQSPM+p0L Q5siitiAI/3IjpF3HYVvpRVfFjmBeD4QeUc7sy8L+s/C4AVmqkLYOI90U4Wgwm7N wEgbbCKQT/xeaNu2M1KdjzAkFyZGIDiHRu0BGvJC8xqp5ogA94BOc4095yGU70yI a6PGkB332SmAbg6aVEqggbHAl+gxVibuhdZphQBZSC33aZUB055vZ2Tk/Z/jvlOW xDibm6ilPY3cBHoDCgQkbDVHweqvTSbmbcq5gu4EwWUcZa9O6AT3LWCnKwnXQlLn qMwMQeex5y1krY50ffJPqFFLzRsxIYsZ2m7r0bnDDHahXP2yslfK+fstLRXspVJP XrKgckaD2XAlVaAzsTgONSA4aJGlyit6NhXjwNgGmpkXeDD8Hgo= =uvBH -----END PGP SIGNATURE----- --Sig_/8CAyLauaXGd8JyBp=IAXQll--