From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
To: Brett Gilio <brettg@gnu.org>
Cc: 42735@debbugs.gnu.org
Subject: [bug#42735] [PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH
Date: Fri, 7 Aug 2020 08:02:04 +0200 [thread overview]
Message-ID: <20200807080204.0b2f9b9d@primarylaptop.localdomain> (raw)
In-Reply-To: <87o8nni0cz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On Thu, 06 Aug 2020 22:46:52 -0500
Brett Gilio <brettg@gnu.org> wrote:
> Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> writes:
>
> >
> > +# Make sure we don't use local package definitions
> > +GUIX_PACKAGE_PATH=""
> > +export GUIX_PACKAGE_PATH
> > +
> > exec "$@"
>
> Wouldn't it make more sense to use `unset` instead of defining an
> empty variable?
I used export and defined an empty variable because I don't know how to
write portable shell scripts and export was already used in
build-aux/pre-inst-env.in.
Is unset portable? If so should I resend a patch with unset instead?
Denis.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-07 6:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 2:21 [bug#42735] [PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH Denis 'GNUtoo' Carikli
2020-08-07 3:46 ` Brett Gilio
2020-08-07 6:02 ` Denis 'GNUtoo' Carikli [this message]
2020-08-07 8:41 ` Mathieu Othacehe
2020-08-09 9:09 ` Denis 'GNUtoo' Carikli
2020-08-14 10:00 ` bug#42735: " Oleg Pykhalov
2020-08-14 11:16 ` [bug#42735] " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807080204.0b2f9b9d@primarylaptop.localdomain \
--to=gnutoo@cyberdimension.org \
--cc=42735@debbugs.gnu.org \
--cc=brettg@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).