From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0GYoD7KkKl8GaQAA0tVLHw (envelope-from ) for ; Wed, 05 Aug 2020 12:23:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oK7iCrKkKl+CAwAAbx9fmQ (envelope-from ) for ; Wed, 05 Aug 2020 12:23:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A795940225 for ; Wed, 5 Aug 2020 12:23:13 +0000 (UTC) Received: from localhost ([::1]:38364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3IRr-0004RI-17 for larch@yhetil.org; Wed, 05 Aug 2020 08:23:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3IRi-0004P0-79 for guix-patches@gnu.org; Wed, 05 Aug 2020 08:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3IRh-0003M8-Sl for guix-patches@gnu.org; Wed, 05 Aug 2020 08:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3IRh-00083z-Mm for guix-patches@gnu.org; Wed, 05 Aug 2020 08:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42682] [PATCH 2/2] gnu: Add qmk-cli. Resent-From: Jan Wielkiewicz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Aug 2020 12:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42682 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 42682@debbugs.gnu.org Received: via spool by 42682-submit@debbugs.gnu.org id=B42682.159663018030988 (code B ref 42682); Wed, 05 Aug 2020 12:23:01 +0000 Received: (at 42682) by debbugs.gnu.org; 5 Aug 2020 12:23:00 +0000 Received: from localhost ([127.0.0.1]:50291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3IRg-00083k-2m for submit@debbugs.gnu.org; Wed, 05 Aug 2020 08:23:00 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.154]:35103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3IRb-00083S-5S for 42682@debbugs.gnu.org; Wed, 05 Aug 2020 08:22:59 -0400 X-Interia-R: Interia X-Interia-R-IP: 89.64.43.25 X-Interia-R-Helo: Received: from localhost (89-64-43-25.dynamic.chello.pl [89.64.43.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Wed, 5 Aug 2020 14:22:48 +0200 (CEST) Date: Wed, 5 Aug 2020 14:22:40 +0200 From: Jan Wielkiewicz Message-ID: <20200805142240.075ac063@interia.pl> In-Reply-To: <87o8npjvt4.fsf@gnu.org> References: <20200802204910.15356-1-tona_kosmicznego_smiecia@interia.pl> <20200802204910.15356-2-tona_kosmicznego_smiecia@interia.pl> <87y2mwt9t0.fsf@gnu.org> <20200803144349.06022fa4@interia.pl> <87o8npjvt4.fsf@gnu.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1596630169; bh=S+Ttgle6+lB+mKfaErUT0Qmq6mEgImoehYFzziSfXZg=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Date:From:To:Cc: Subject:Message-ID:In-Reply-To:References:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Interia-Antivirus; b=noN/2HmjcGQfMH2hbphvjOSyBb8GlRU9G9FR2O0MbbfXJZz9rlvBCt0RWIiSr75GM WKso0H2INGOOanhLI3TXQXQKtCYjzVTC2kLyRI7BMyiV/PY7ay/872G0Shh9/NUWpo omsw4gUeU+wvVBZE5liGhQ6mPeC+Gl71P+2SfsoI= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=interia.pl header.s=biztos header.b=noN/2Hmj; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.49 X-TUID: 22q8FS5PfJRN Dnia 2020-08-05, o godz. 11:17:43 Mathieu Othacehe napisa=C5=82(a): >=20 > Hello Jan, >=20 > >> Do we really need to propagate all those inputs? > > The python dependencies were added to propagated inputs > > automatically by "guix import". The other tools are needed in the > > user profine, because qmk-cli uses them, for example it fetches qmk > > firmware from git, it runs some *python stuff* and when user is > > done making changes to their firmware, qmk cli builds the firmware > > using the compiler and flashes it using dfu. >=20 > Turns out qmk_cli is just a wrapper around qmk_firmware. It clones qmk > firmware repository because it cannot locate a qmk_firmware directory > using QMK_HOME variable. >=20 > I think the proper way to do things would be to package qmk_firwmare > first (it has a root shell.nix file that should help). Then this > package would define QMK_HOME using "search-paths". >=20 > This way, qmk_cli would just require some python libraries, but would > not propagate git, and the toolchains. >=20 > Does it make sense? But the entire point of qmk firmware is that the user configures it. I had to modify the source code to make my keyboard work and add some extra features like layouts, special keys. Your solution will only work for the unmodified and default firmware, or is there a Guix solution for it I'm not aware of, like a convenient interface for user defined packages? > Thanks, >=20 > Mathieu