unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
@ 2020-08-01 20:16 Denis 'GNUtoo' Carikli
  2020-08-01 20:16 ` [bug#42659] [PATCH 2/2] gnu: android: export android-liblog Denis 'GNUtoo' Carikli
  2020-08-03  7:16 ` bug#42658: [PATCH 1/2] gnu: android: export android-libcutils Mathieu Othacehe
  0 siblings, 2 replies; 6+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2020-08-01 20:16 UTC (permalink / raw)
  To: 42658; +Cc: Danny Milosavljevic, Julien Lepiller,
	Denis 'GNUtoo' Carikli

Android's libcutils is used by many Android components, and as Guix can be
used to bulid Android components, it is useful to export it as it can then
be reused as an input to packages being developped outside of the Guix
source code repository.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 gnu/packages/android.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 0fb4330d3e..af2b817298 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -229,7 +229,7 @@ in Main, System, Radio and Events sub-logs.")
 various Android core host applications.")
     (license license:asl2.0)))
 
-(define android-libcutils
+(define-public android-libcutils
   (package
     (name "android-libcutils")
     (version (android-platform-version))
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#42659] [PATCH 2/2] gnu: android: export android-liblog
  2020-08-01 20:16 [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils Denis 'GNUtoo' Carikli
@ 2020-08-01 20:16 ` Denis 'GNUtoo' Carikli
  2020-08-03  7:16 ` bug#42658: [PATCH 1/2] gnu: android: export android-libcutils Mathieu Othacehe
  1 sibling, 0 replies; 6+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2020-08-01 20:16 UTC (permalink / raw)
  To: 42659; +Cc: Danny Milosavljevic, Julien Lepiller,
	Denis 'GNUtoo' Carikli

Android's liblog is used by many Android components, and as Guix can be
used to bulid Android components, it is useful to export it as it can then
be reused as an input to packages being developped outside of the Guix
source code repository.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 gnu/packages/android.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index af2b817298..f7f3aca4a2 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -185,7 +185,7 @@ use their packages mostly unmodified in our Android NDK build system.")
      (base32
       checksum))))
 
-(define android-liblog
+(define-public android-liblog
   (package
     (name "android-liblog")
     (version (android-platform-version))
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#42658: [PATCH 1/2] gnu: android: export android-libcutils
  2020-08-01 20:16 [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils Denis 'GNUtoo' Carikli
  2020-08-01 20:16 ` [bug#42659] [PATCH 2/2] gnu: android: export android-liblog Denis 'GNUtoo' Carikli
@ 2020-08-03  7:16 ` Mathieu Othacehe
  2020-08-05  6:20   ` [bug#42658] " Denis 'GNUtoo' Carikli
  1 sibling, 1 reply; 6+ messages in thread
From: Mathieu Othacehe @ 2020-08-03  7:16 UTC (permalink / raw)
  To: Denis 'GNUtoo' Carikli
  Cc: Danny Milosavljevic, Julien Lepiller, 42658-done


Hello,

> Android's libcutils is used by many Android components, and as Guix can be
> used to bulid Android components, it is useful to export it as it can then
> be reused as an input to packages being developped outside of the Guix
> source code repository.

This looks fine. I pushed those two patches with edited commit
messages. For future reference, very similar patches can be send in the
same serie :).

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
  2020-08-03  7:16 ` bug#42658: [PATCH 1/2] gnu: android: export android-libcutils Mathieu Othacehe
@ 2020-08-05  6:20   ` Denis 'GNUtoo' Carikli
  2020-08-05  7:40     ` Mathieu Othacehe
  0 siblings, 1 reply; 6+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2020-08-05  6:20 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: Danny Milosavljevic, Julien Lepiller, 42658-done

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On Mon, 03 Aug 2020 09:16:16 +0200
Mathieu Othacehe <othacehe@gnu.org> wrote:

> Hello,
Hi,

> This looks fine. I pushed those two patches with edited commit
> messages. 
Thanks a lot. I'll probably have more patches that I need to send it
soon but I need to find a faster way to test them.

> For future reference, very similar patches can be send in
> the same serie :).

How do I do that? I used the following command to send the patch:
> git send-email --to="guix-patches@gnu.org" \
> 	--cc="Julien Lepiller <julien@lepiller.eu>" \
> 	--cc="Danny Milosavljevic <dannym@scratchpost.org>" \
> 	0001-gnu-android-export-android-libcutils.patch \
> 	0002-gnu-android-export-android-liblog.patch \
> 	${sentinel}

Do I need to use --compose?

Denis.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
  2020-08-05  6:20   ` [bug#42658] " Denis 'GNUtoo' Carikli
@ 2020-08-05  7:40     ` Mathieu Othacehe
  2020-08-05  9:11       ` Denis 'GNUtoo' Carikli
  0 siblings, 1 reply; 6+ messages in thread
From: Mathieu Othacehe @ 2020-08-05  7:40 UTC (permalink / raw)
  To: Denis 'GNUtoo' Carikli
  Cc: Danny Milosavljevic, Julien Lepiller, 42658-done


Hello,

> How do I do that? I used the following command to send the patch:
>> git send-email --to="guix-patches@gnu.org" \
>> 	--cc="Julien Lepiller <julien@lepiller.eu>" \
>> 	--cc="Danny Milosavljevic <dannym@scratchpost.org>" \
>> 	0001-gnu-android-export-android-libcutils.patch \
>> 	0002-gnu-android-export-android-liblog.patch \
>> 	${sentinel}

Each time a mail is sent to "guix-patches@gnu.org" a new bug ticket is
created. You should first send either the cover letter or the first
patch, and then send all the subsequent patches to NNN@debbugs.gnu.org
where NNN is the ticket number created when the first patch is sent.

See the bottom of
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html for
further explications.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils
  2020-08-05  7:40     ` Mathieu Othacehe
@ 2020-08-05  9:11       ` Denis 'GNUtoo' Carikli
  0 siblings, 0 replies; 6+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2020-08-05  9:11 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: Danny Milosavljevic, Julien Lepiller, 42658-done

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

On Wed, 05 Aug 2020 09:40:25 +0200
Mathieu Othacehe <othacehe@gnu.org> wrote:
> Each time a mail is sent to "guix-patches@gnu.org" a new bug ticket is
> created. You should first send either the cover letter or the first
> patch, and then send all the subsequent patches to NNN@debbugs.gnu.org
> where NNN is the ticket number created when the first patch is sent.
> 
> See the bottom of
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html for
> further explications.
Thanks a lot.

I read that part in the manual some time ago but I didn't think of
(ab)using it in this way to get the intended result.

Denis.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-08-05  9:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-01 20:16 [bug#42658] [PATCH 1/2] gnu: android: export android-libcutils Denis 'GNUtoo' Carikli
2020-08-01 20:16 ` [bug#42659] [PATCH 2/2] gnu: android: export android-liblog Denis 'GNUtoo' Carikli
2020-08-03  7:16 ` bug#42658: [PATCH 1/2] gnu: android: export android-libcutils Mathieu Othacehe
2020-08-05  6:20   ` [bug#42658] " Denis 'GNUtoo' Carikli
2020-08-05  7:40     ` Mathieu Othacehe
2020-08-05  9:11       ` Denis 'GNUtoo' Carikli

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).