From: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 42682@debbugs.gnu.org
Subject: [bug#42682] [PATCH 2/2] gnu: Add qmk-cli.
Date: Mon, 3 Aug 2020 14:43:49 +0200 [thread overview]
Message-ID: <20200803144349.06022fa4@interia.pl> (raw)
In-Reply-To: <87y2mwt9t0.fsf@gnu.org>
Dnia 2020-08-03, o godz. 10:26:03
Mathieu Othacehe <othacehe@gnu.org> napisał(a):
>
> > + (propagated-inputs
> > + `(("arm-none-eabi-gcc" ,gcc-arm-none-eabi-7-2018-q2-update)
> > + ("avr-gcc" ,avr-toolchain-5)
> > + ("avrdude" ,avrdude)
> > + ("dfu-programmer" ,dfu-programmer)
> > + ("dfu-util" ,dfu-util)
> > + ("git" ,git)
> > + ("python3" ,python)
> > + ("python-appdirs" ,python-appdirs)
> > + ("python-argcomplete" ,python-argcomplete)
> > + ("python-colorama" ,python-colorama)
> > + ("python-flake8" ,python-flake8)
> > + ("python-hjson" ,python-hjson)
> > + ("python-nose2" ,python-nose2)
> > + ("python-yapf" ,python-yapf)))
>
> Do we really need to propagate all those inputs?
The python dependencies were added to propagated inputs automatically
by "guix import". The other tools are needed in the user profine,
because qmk-cli uses them, for example it fetches qmk firmware from
git, it runs some *python stuff* and when user is done making changes
to their firmware, qmk cli builds the firmware using the compiler and
flashes it using dfu.
I think it would be cool if Guix allowed defining profiles and
environments the same way it allows defining packages.
This way installing qmk-cli would also install say qmk-profile with all
headers (and tools) needed for development. Now, even though
arv-toolchain is installed, I have to run "guix environment qmk-cli" to
be able to work with the firmware without getting build errors.
> Can't we hardcode the
> path to those tools directly in the sources, if they are not
> registered at build time?
I need them installed, so qmk-cli doesn't complain. Should the user be
responsible for installing all the tools needed for development?
> > + (arguments
> > + `(#:phases (modify-phases %standard-phases
> > + (add-before 'check 'set-qmk-home
> > + (lambda _
> > + ;; tests fail without this variable set
> > + (setenv "QMK_HOME"
> > + "")
>
> Who is supposed to set it otherwise?
I'm not sure. That's the first thing qmk-cli sets when it is already
installed. Normally, qmk-cli is installed by pip, maybe it is
responsible for setting the variables?
> > + "A program to help users work with QMK Firmware.")
>
> You also need to elaborate here :)
Should I describe what qmk firmware is or say more about what working
with qmk firmware is, or both?
> Thanks,
>
> Mathieu
next prev parent reply other threads:[~2020-08-03 12:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 20:42 [bug#42682] [PATCH 0/2] Qmk cli Jan Wielkiewicz
2020-08-02 20:49 ` [bug#42682] [PATCH 1/2] gnu: Add python-hjson Jan Wielkiewicz
2020-08-02 20:49 ` [bug#42682] [PATCH 2/2] gnu: Add qmk-cli Jan Wielkiewicz
2020-08-03 8:26 ` Mathieu Othacehe
2020-08-03 12:43 ` Jan Wielkiewicz [this message]
2020-08-05 9:17 ` Mathieu Othacehe
2020-08-05 12:22 ` Jan Wielkiewicz
2020-08-07 8:20 ` Mathieu Othacehe
2020-08-07 15:44 ` Jan Wielkiewicz
2021-02-05 11:39 ` Nicolò Balzarotti
2021-02-24 21:41 ` Jan Wielkiewicz
2021-02-24 22:23 ` Nicolò Balzarotti
2020-08-03 8:21 ` [bug#42682] [PATCH 1/2] gnu: Add python-hjson Mathieu Othacehe
2020-08-03 12:28 ` Jan Wielkiewicz
2022-12-22 12:29 ` [bug#42682] [PATCH 0/2] Qmk cli Marcel van der Boom
2023-04-09 4:31 ` [bug#42682] [PATCH v2 0/9] Add qmk-cli Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 1/9] gnu: Add python-hjson Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 2/9] gnu: Add python-log-symbols Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 3/9] gnu: Add python-spinners Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 4/9] gnu: Add python-halo Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 5/9] gnu: Add python-milc Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 6/9] gnu: Add python-dotty-dict Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 7/9] gnu: Add python-hid Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 8/9] gnu: Add qmk-cli Fredrik Salomonsson
2023-04-09 4:31 ` [bug#42682] [PATCH v2 9/9] gnu: Add qmk-udev-rules Fredrik Salomonsson
2023-05-28 23:43 ` [bug#42682] [PATCH v3 0/9] Add qmk-cli Fredrik Salomonsson
2023-05-28 23:43 ` [bug#42682] [PATCH v3 1/9] gnu: Add python-hjson Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 2/9] gnu: Add python-log-symbols Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 3/9] gnu: Add python-spinners Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 4/9] gnu: Add python-halo Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 5/9] gnu: Add python-milc Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 6/9] gnu: Add python-dotty-dict Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 7/9] gnu: Add python-hid Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 8/9] gnu: Add qmk-cli Fredrik Salomonsson
2023-05-28 23:44 ` [bug#42682] [PATCH v3 9/9] gnu: Add qmk-udev-rules Fredrik Salomonsson
2023-08-19 0:34 ` [bug#42682] [PATCH v3 0/9] Add qmk-cli Fredrik Salomonsson
2023-09-02 5:23 ` Vagrant Cascadian
2023-10-10 3:56 ` bug#42682: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803144349.06022fa4@interia.pl \
--to=tona_kosmicznego_smiecia@interia.pl \
--cc=42682@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).