unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 42681@debbugs.gnu.org
Subject: [bug#42681] [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search paths.
Date: Mon, 3 Aug 2020 13:03:52 +0200	[thread overview]
Message-ID: <20200803110352.ehwmgpnyjoxzxo5z@gravity> (raw)
In-Reply-To: <20200803064026.GF1134@E5400>

[-- Attachment #1: Type: text/plain, Size: 2389 bytes --]

On Mon, Aug 03, 2020 at 09:40:26AM +0300, Efraim Flashner wrote:
> On Sun, Aug 02, 2020 at 10:34:21PM +0200, Jakub Kądziołka wrote:
> > This updates the bootstrap-gcc to use the same search path strategy as
> > the main compilers, making the bootstrap environment more similar across
> > architectures, and fixing the bootstrap path on non-x86 architectures
> > again.
> > 
> > This is a follow up to commit 7cde865f12dd67e55946a52a21103e71f447eced.
> > 
> > * gnu/packages/bootstrap.scm (%bootstrap-gcc)[native-search-paths]: Use
> >   C_INCLUDE_PATH and CPLUS_INCLUDE_PATH instead of CPATH.
> > ---
> > 
> > Note: because I don't have any non-x86 machines on hand, I haven't
> > actually tested the patch yet.
> > 
> > Efraim, you have helped me investigate this with your ARM board, perhaps
> > you could test this patch?
> > 
> > Regards,
> > Jakub Kądziołka
> >  gnu/packages/bootstrap.scm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/bootstrap.scm b/gnu/packages/bootstrap.scm
> > index c39e60ec8b..fd6c2e099c 100644
> > --- a/gnu/packages/bootstrap.scm
> > +++ b/gnu/packages/bootstrap.scm
> > @@ -740,8 +740,11 @@ exec ~a/bin/.gcc-wrapped -B~a/lib \
> >                             "1m5miqkyng45l745n0sfafdpjkqv9225xf44jqkygwsipj2cv9ks")))))))))
> >      (native-search-paths
> >       (list (search-path-specification
> > -            (variable "CPATH")
> > +            (variable "C_INCLUDE_PATH")
> >              (files '("include")))
> > +           (search-path-specification
> > +            (variable "CPLUS_INCLUDE_PATH")
> > +            (files '("include/c++" "include")))
> >             (search-path-specification
> >              (variable "LIBRARY_PATH")
> >              (files '("lib" "lib64")))))
> > -- 
> > 2.28.0
> > 
> 
> I'm building out to hello on my aarch64 board now, starting from
> make-boot0 apparently. Guile is only listed once so hopefully it won't
> take too long.

Thanks!

> I assume this doesn't break anything on x86_64?

I don't have hello built on current core-updates (it also wants to start
from make-boot0), but I have confirmed that guix build --no-grafts -d
hello returns the same derivation path before and after the commit.
%bootstrap-gcc is not present at all in the package graph on x86.

Regards,
Jakub Kądziołka

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-08-03 11:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-02 20:34 [bug#42681] [PATCH core-updates] gnu: bootstrap-gcc: Don't use CPATH search paths Jakub Kądziołka
2020-08-03  6:40 ` Efraim Flashner
2020-08-03 11:03   ` Jakub Kądziołka [this message]
2020-08-04  6:00     ` Efraim Flashner
2020-08-04 12:34       ` bug#42681: " Jakub Kądziołka
2020-08-05  8:56         ` [bug#42681] " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803110352.ehwmgpnyjoxzxo5z@gravity \
    --to=kuba@kadziolka.net \
    --cc=42681@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).