From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 42339-done@debbugs.gnu.org
Subject: bug#42339: [PATCH core-updates] gnu: glibc-intermediate: Fixup the pre-configure phase.
Date: Fri, 24 Jul 2020 00:15:45 +0200 [thread overview]
Message-ID: <20200723221545.fqhkq6rkfjuyhadi@gravity> (raw)
In-Reply-To: <87wo2uekn6.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]
On Thu, Jul 23, 2020 at 09:49:17AM +0200, Ludovic Courtès wrote:
> Hi,
>
> Jakub Kądziołka <kuba@kadziolka.net> skribis:
>
> > On Thu, Jul 23, 2020 at 12:00:22AM +0200, Ludovic Courtès wrote:
> >> Hello,
> >>
> >> Jakub Kądziołka <kuba@kadziolka.net> skribis:
> >>
> >> > * gnu/packages/commencement.scm
> >> > (glibc-final-with-bootstrap-bash)[arguments]: Don't patch sunrpc,
> >> > as it's no longer required. Tweak C_INCLUDE_PATH and
> >> > CPLUS_INCLUDE_PATH instead of CPATH.
>
> [...]
>
> >> > The debug output does not refer to a bootstrap glibc anymore whether the phase
> >> > is there or not, though it does refer to gcc-cross-boot0:lib. Does this
> >> > mean that the phase is simply obsolete, and only the hurd parts should
> >> > remain, or is the reference to gcc a bug? Perhaps gcc should have a
> >> > separate output for the includes it provides (stdarg and such) so that
> >> > this reference doesn't bring in the whole mesboot tree? This would
> >> > improve the closure of gcc-toolchain:debug...
> >>
> >> Oooh, nice. LGTM!
> >
> > Thanks for your review!
> >
> >> Please confirm that nothing breaks (everything builds at least up to
> >> ‘gcc-final’) and you can push to ‘core-updates’.
> >
> > I have confirmed that hello builds both natively and cross-built. On a
> > similar topic, the same test succeeded for removing the native-gcc input.
> > As the comment suggests, it was only being used for --enable-obsolete-rpc.
> > I am thus considering a v2 that also removes said input. Does that make
> > sense?
>
> Yes it does (again provided nothing breaks).
>
> Thank you!
Thanks, patches pushed!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-07-23 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 23:40 [bug#42339] [PATCH core-updates] gnu: glibc-intermediate: Fixup the pre-configure phase Jakub Kądziołka
2020-07-22 22:00 ` Ludovic Courtès
2020-07-22 22:37 ` Jakub Kądziołka
2020-07-23 7:49 ` Ludovic Courtès
2020-07-23 22:15 ` Jakub Kądziołka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723221545.fqhkq6rkfjuyhadi@gravity \
--to=kuba@kadziolka.net \
--cc=42339-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).