unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 41964-done@debbugs.gnu.org
Subject: bug#41964: [PATCH 0/2] Add pass-tomb.
Date: Sat, 11 Jul 2020 23:51:23 +0200	[thread overview]
Message-ID: <20200711235045.19354852@tachikoma.lepiller.eu> (raw)
In-Reply-To: <20200620150912.27001-1-brice@waegenei.re>

Le Sat, 20 Jun 2020 17:09:12 +0200,
Brice Waegeneire <brice@waegenei.re> a écrit :

> Brice Waegeneire (2):
>   gnu: tomb: Add 'getent' to PATH.
>   gnu: Add 'pass-tomb'.
> 
>  gnu/packages/crypto.scm         |  3 ++-
>  gnu/packages/password-utils.scm | 41
> +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+),
> 1 deletion(-)
> 

Pushed as 12d69fc5745759b11d6e19cdcdad64d34ecd9dd4 and
36a1925f21ee6787d8b80025f1b96238309f4b96.

I tried to enable tests in pass-tomb (because there were actually
tests) but it didn't work because it checks there is no swap partition,
and tries to use /tmp/zsh which is not accessible in the build
container.  One of the test dependencies was kcov, which I added in a
separate patch, but ended up not using, as it's only required for tests
and we disable them.

Note that the usual way to disable tests is by using the argument

#:tests? #f

instead of deleting the check phase. I've fixed that before pushing.

Thanks for working on this!




      parent reply	other threads:[~2020-07-11 21:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-20 15:09 [bug#41964] [PATCH 0/2] Add pass-tomb Brice Waegeneire
2020-06-20 15:11 ` [bug#41964] [PATCH 1/2] gnu: tomb: Add 'getent' to PATH Brice Waegeneire
2020-07-17 18:53   ` Danny Milosavljevic
2020-06-20 15:11 ` [bug#41964] [PATCH 2/2] gnu: Add 'pass-tomb' Brice Waegeneire
2020-07-17 18:52   ` Danny Milosavljevic
2020-07-11 21:51 ` Julien Lepiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200711235045.19354852@tachikoma.lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=41964-done@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).