From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CJUUIfznBF/0SgAA0tVLHw (envelope-from ) for ; Tue, 07 Jul 2020 21:24:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GMoAHfznBF+yKwAAbx9fmQ (envelope-from ) for ; Tue, 07 Jul 2020 21:24:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB56A940ACE for ; Tue, 7 Jul 2020 21:24:11 +0000 (UTC) Received: from localhost ([::1]:35300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsv4S-0004vk-Rt for larch@yhetil.org; Tue, 07 Jul 2020 17:24:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsv4M-0004vY-O9 for guix-patches@gnu.org; Tue, 07 Jul 2020 17:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53581) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsv4M-0003KY-F2 for guix-patches@gnu.org; Tue, 07 Jul 2020 17:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsv4M-0000ls-Bz for guix-patches@gnu.org; Tue, 07 Jul 2020 17:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42229] [PATCH 8/9] gnu: jami: Fix compilation by providing necessary webchat files. Resent-From: Jan Wielkiewicz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Jul 2020 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42229 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 42229@debbugs.gnu.org Received: via spool by 42229-submit@debbugs.gnu.org id=B42229.15941569992909 (code B ref 42229); Tue, 07 Jul 2020 21:24:02 +0000 Received: (at 42229) by debbugs.gnu.org; 7 Jul 2020 21:23:19 +0000 Received: from localhost ([127.0.0.1]:36894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsv3e-0000kq-V6 for submit@debbugs.gnu.org; Tue, 07 Jul 2020 17:23:19 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.155]:55978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsv3b-0000kZ-LA for 42229@debbugs.gnu.org; Tue, 07 Jul 2020 17:23:17 -0400 X-Interia-R: Interia X-Interia-R-IP: 89.64.43.25 X-Interia-R-Helo: Received: from localhost (89-64-43-25.dynamic.chello.pl [89.64.43.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Tue, 7 Jul 2020 23:23:08 +0200 (CEST) Date: Tue, 7 Jul 2020 23:22:59 +0200 From: Jan Wielkiewicz Message-ID: <20200707232259.22052026@interia.pl> In-Reply-To: <87lfjwnxxt.fsf@cbaines.net> References: <20200706155030.1938-1-tona_kosmicznego_smiecia@interia.pl> <20200706155030.1938-8-tona_kosmicznego_smiecia@interia.pl> <87lfjwnxxt.fsf@cbaines.net> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1594156988; bh=1oS9TFBUGkQP+RGLrM0+/ULGL8BtNeS1WGTq/dFLMC4=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Date:From:To:Cc: Subject:Message-ID:In-Reply-To:References:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Interia-Antivirus; b=fXgOzMeTQ+w2ZPLCje5cvVb+WnjzguhoN32oCSZqdkK0pUaxT1D48XxaVK2mWRBi8 NDztIgMZgJ2cIUKSHO3HYbovQG4iV9BaxI96Qfcb0rVqYU1tmTI8HFxjzQS3wc4bME xpnFx8rctCELw8vruYHt5lxVpihKBv2gIRKX9VF4= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=interia.pl header.s=biztos header.b=fXgOzMeT; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: e9MajE2EpaXr Hello. On Mon, 06 Jul 2020 22:19:42 +0100 Christopher Baines wrote: > I'd perhaps just say instead that these files are packaged as > jami-chatview which is used by the jami package, that's probably > what's useful to know here. Done. > > Because substitute* uses regular expressions, characters like . should > probably be escaped. However, you might want to try something like the > following: > > (substitute* "CMakeLists.txt" > (("src/web-chatview/.*") "")) > I use to forget this, don't know why. Testing how it works right now. > > It would be good if this could be clearer as to what the user gets if > they install this package. I'm guessing because it's an input to Jami, > it's probably not useful to have it in your profile? Users don't have to know this. I made it private by changing define-public to define. > Also, if it's going to describe the contents of the package, I'd do it > in a full sentance, so something like: "This package provides the > HTML, CSS and JavaScript files for the web chatview for Jami". Done. > I think there's some Expat stuff in there too. Yes, there is, added expat to license list. Shouldn't Jami files contain explicit license statement though? > > Rather than copying, could this be a symlink? That way you're just > using another store item, rather than copying the files from one to > another. Working on this. The build fails on the ".eslintrc.json". Guix for some reason doesn't like dotfiles. Jan Wielkiewicz