From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uOMiHqsdAV8pJQAA0tVLHw (envelope-from ) for ; Sun, 05 Jul 2020 00:24:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IIAsGqsdAV9XdgAA1q6Kng (envelope-from ) for ; Sun, 05 Jul 2020 00:24:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D08C9940900 for ; Sun, 5 Jul 2020 00:24:10 +0000 (UTC) Received: from localhost ([::1]:49390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrsS0-0005WH-U9 for larch@yhetil.org; Sat, 04 Jul 2020 20:24:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrsRu-0005Vp-V7 for guix-patches@gnu.org; Sat, 04 Jul 2020 20:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jrsRu-00059m-M7 for guix-patches@gnu.org; Sat, 04 Jul 2020 20:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jrsRu-0004rc-Hf for guix-patches@gnu.org; Sat, 04 Jul 2020 20:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#38408] [PATCH v9 3/8] Added Guile-Semver as a dependency to guix Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Jul 2020 00:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38408 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze Cc: 38408@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Efraim Flashner , jsoo1@asu.edu, Leo Famulari Received: via spool by 38408-submit@debbugs.gnu.org id=B38408.159390861118657 (code B ref 38408); Sun, 05 Jul 2020 00:24:02 +0000 Received: (at 38408) by debbugs.gnu.org; 5 Jul 2020 00:23:31 +0000 Received: from localhost ([127.0.0.1]:59858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrsRO-0004qq-Pk for submit@debbugs.gnu.org; Sat, 04 Jul 2020 20:23:31 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:59660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrsRM-0004qh-Tg for 38408@debbugs.gnu.org; Sat, 04 Jul 2020 20:23:30 -0400 Received: (qmail 3788 invoked by uid 1009); 5 Jul 2020 02:23:27 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25862. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.053477 secs); 05 Jul 2020 00:23:27 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 5 Jul 2020 02:23:26 +0200 Date: Sun, 5 Jul 2020 02:23:25 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200705002325.4yz3ur6fpvpr5ziy@gravity> References: <47ed3e36-0d9f-cd6f-a64b-e3f9c9d71537@riseup.net> <20200322201018.GB16716@jasmine.lan> <45972138-5bf8-821a-178a-c04e6446e076@riseup.net> <87mu86njj3.fsf@gnu.org> <5ae20de5-ddf8-22ab-2c40-d76715751962@riseup.net> <6eedb6bb-49ec-87ac-9a38-10d02a21726f@riseup.net> <87lfn0myho.fsf@gnu.org> <3a0949f6-0e01-0909-f3c8-311c4bb5cf7b@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i5g4lyhomimgvyyn" Content-Disposition: inline In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: wknCCVZqMRjd --i5g4lyhomimgvyyn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Martin, On Wed, Apr 29, 2020 at 02:51:33PM -0500, Martin Becze wrote: > diff --git a/tests/crate.scm b/tests/crate.scm > index beaa696be0..65d5ac3389 100644 > --- a/tests/crate.scm > +++ b/tests/crate.scm > @@ -280,7 +280,7 @@ > (_ (error "Unexpected URL: " url))))) > =20 > (match (crate->guix-package "foo") > - ((define-public rust-foo-1.0.0 > + ((define-public rust-foo-1.0 > (package (name "rust-foo") > (version "1.0.0") > (source I was under the impression that, ideally, we'd only include the minor version when it's necessary for disambugating semver-incompatible packages, i. e. rust-foo@1.0.0 would be called rust-foo-1, but rust-bar@0.3.7 would be called rust-bar-0.3. Thoughts? Regards, Jakub K=C4=85dzio=C5=82ka --i5g4lyhomimgvyyn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl8BHX0ACgkQ4xWnWEYT FWTblA//fRHVxpRTPRU2ZVFgAL64MvYo/hSq/6sCQvwVoMUTHEPleVYYvHpD6Tz8 6HER/6wOlN4KxypdYUExYdzL5LQvJjnsoiKeY4kSoG7ujH3dc3xodINcTzZOqb55 woK8kEa/f2fFCyU3U3BxvtmChSlQsmcP/exJjckwaetY2T8o9eYqiIavpX04Wxuv /IdcTnXuPQeTe49H005H47DlPtk8jjObglbxEroFc/3IJjdf2jloikzLM4xCW/sr Qhb5aUZpjAFRklhnxFMXVCUYiKB+RBETIbYTX/kMNWSG5z73+gWKR1/dKOJvOEcd nLdxRO6Hbmq3+QokzPENOAr6AGLDfkgFU08M0aPdToG3Gj2xrS3746v/McHdjAjK 7jGmWaNDSOABvg9zSUmu7pidsjiNSJRG9vnJLFPZRQ9J1qh29yfpXIOVXoQ9D7oL ZiG1dn3luWhUAEWzUvkfivBWttl7C3OX2UyQFuwdFMk9wAA6NRMBZdmYFo9qOhqo jsfS2DOQVbPMmA27AJiTiefRHPtGAHCuAf+5AHNNZNTQw6aaTpu5S57aLW1dEeBN Hq8uyRZBPDIzT5sitCQWaQ+Dutm7Sgjh4ijmm1qwxKJJu+J+bF94hr7jZgI2aq8w p+u2UFQIpelsQeQu+yuICG/68q24pESigtmhLVDPkD0QDUe9Fbk= =vu6v -----END PGP SIGNATURE----- --i5g4lyhomimgvyyn--