unofficial mirror of guix-patches@gnu.org 
 help / color / Atom feed
* [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of guile-redis.
@ 2020-06-27 22:42 Masaya Tojo
  2020-06-28  7:56 ` Efraim Flashner
  0 siblings, 1 reply; 4+ messages in thread
From: Masaya Tojo @ 2020-06-27 22:42 UTC (permalink / raw)
  To: 42097; +Cc: Masaya Tojo

* gnu/packages/guile-xyz.scm (artanis)[propagated-inputs]: Change from
guile-redis to guile2.2-redis.
---
 gnu/packages/guile-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index f8e59b0b21..5416b30c2e 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us>
 ;;; Copyright © 2020 Julien Lepiler <julien@lepiller.eu>
 ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
+;;; Copyright © 2020 Masaya Tojo <masaya@tojo.tokyo>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -157,7 +158,7 @@
     (propagated-inputs
      `(("guile-json" ,guile-json-1)
        ("guile-readline" ,guile2.2-readline)
-       ("guile-redis" ,guile-redis)))
+       ("guile-redis" ,guile2.2-redis)))
     (native-inputs
      `(("bash"       ,bash)         ;for the `source' builtin
        ("pkgconfig"  ,pkg-config)
-- 
2.26.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of guile-redis.
  2020-06-27 22:42 [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of guile-redis Masaya Tojo
@ 2020-06-28  7:56 ` Efraim Flashner
  2020-06-28 10:58   ` Masaya Tojo
  0 siblings, 1 reply; 4+ messages in thread
From: Efraim Flashner @ 2020-06-28  7:56 UTC (permalink / raw)
  To: Masaya Tojo; +Cc: 42097

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

On Sun, Jun 28, 2020 at 07:42:03AM +0900, Masaya Tojo wrote:
> * gnu/packages/guile-xyz.scm (artanis)[propagated-inputs]: Change from
> guile-redis to guile2.2-redis.
> ---
>  gnu/packages/guile-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index f8e59b0b21..5416b30c2e 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -28,6 +28,7 @@
>  ;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us>
>  ;;; Copyright © 2020 Julien Lepiler <julien@lepiller.eu>
>  ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
> +;;; Copyright © 2020 Masaya Tojo <masaya@tojo.tokyo>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -157,7 +158,7 @@
>      (propagated-inputs
>       `(("guile-json" ,guile-json-1)
>         ("guile-readline" ,guile2.2-readline)
> -       ("guile-redis" ,guile-redis)))
> +       ("guile-redis" ,guile2.2-redis)))
>      (native-inputs
>       `(("bash"       ,bash)         ;for the `source' builtin
>         ("pkgconfig"  ,pkg-config)
> -- 
> 2.26.2
> 

Should guile-json-1 be switched to guile2.2-json-1 also?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of guile-redis.
  2020-06-28  7:56 ` Efraim Flashner
@ 2020-06-28 10:58   ` Masaya Tojo
  2020-06-29  6:21     ` bug#42097: " Efraim Flashner
  0 siblings, 1 reply; 4+ messages in thread
From: Masaya Tojo @ 2020-06-28 10:58 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 42097


Hello,

Thank you for reviewing my patch.

> Should guile-json-1 be switched to guile2.2-json-1 also?

Guile-json-1 seem version of guile2.2. I search for guile2.2-json-1, but it
does not exist yet.

So, I think that it's not necessary.

Regards,




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#42097: [PATCH] gnu: artanis: Use guile2.2 version of guile-redis.
  2020-06-28 10:58   ` Masaya Tojo
@ 2020-06-29  6:21     ` Efraim Flashner
  0 siblings, 0 replies; 4+ messages in thread
From: Efraim Flashner @ 2020-06-29  6:21 UTC (permalink / raw)
  To: Masaya Tojo; +Cc: 42097-done

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Sun, Jun 28, 2020 at 07:58:37PM +0900, Masaya Tojo wrote:
> 
> Hello,
> 
> Thank you for reviewing my patch.
> 
> > Should guile-json-1 be switched to guile2.2-json-1 also?
> 
> Guile-json-1 seem version of guile2.2. I search for guile2.2-json-1, but it
> does not exist yet.
> 
> So, I think that it's not necessary.
> 

Agreed. I added a comment mentioning that guile-json-1 was already using
guile-2.2 so no one else gets confused and pushed the patch. Thanks!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-27 22:42 [bug#42097] [PATCH] gnu: artanis: Use guile2.2 version of guile-redis Masaya Tojo
2020-06-28  7:56 ` Efraim Flashner
2020-06-28 10:58   ` Masaya Tojo
2020-06-29  6:21     ` bug#42097: " Efraim Flashner

unofficial mirror of guix-patches@gnu.org 

Archives are clonable:
	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git