From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IDofLKaT+F78eAAA0tVLHw (envelope-from ) for ; Sun, 28 Jun 2020 12:57:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KGv+J6aT+F7WPwAAB5/wlQ (envelope-from ) for ; Sun, 28 Jun 2020 12:57:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E003F940220 for ; Sun, 28 Jun 2020 12:57:09 +0000 (UTC) Received: from localhost ([::1]:45398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpWrs-0004ov-JV for larch@yhetil.org; Sun, 28 Jun 2020 08:57:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpWrm-0004oY-6G for guix-patches@gnu.org; Sun, 28 Jun 2020 08:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpWrl-0001uW-Sg for guix-patches@gnu.org; Sun, 28 Jun 2020 08:57:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpWrl-0008Rf-P9 for guix-patches@gnu.org; Sun, 28 Jun 2020 08:57:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41040] [PATCH] Package Definition for QDirStat Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Jun 2020 12:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41040 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thovthe Cc: "41040@debbugs.gnu.org" <41040@debbugs.gnu.org> Received: via spool by 41040-submit@debbugs.gnu.org id=B41040.159334899632426 (code B ref 41040); Sun, 28 Jun 2020 12:57:01 +0000 Received: (at 41040) by debbugs.gnu.org; 28 Jun 2020 12:56:36 +0000 Received: from localhost ([127.0.0.1]:45612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpWrK-0008Qu-OZ for submit@debbugs.gnu.org; Sun, 28 Jun 2020 08:56:36 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:59862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpWrF-0008Qg-2Q for 41040@debbugs.gnu.org; Sun, 28 Jun 2020 08:56:33 -0400 Received: (qmail 23392 invoked by uid 1009); 28 Jun 2020 14:56:26 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25856. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.069066 secs); 28 Jun 2020 12:56:26 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 28 Jun 2020 14:56:26 +0200 Date: Sun, 28 Jun 2020 14:56:24 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200628125624.3vr2borezix5ij4s@gravity> References: <27uwM7nMqpAz-RfKtxXzIOJWs0UnmDO3vqxoqkN1VeXR7GHQJTCgM5B0f8bCMuG2y5QsbCDj_AScqxM-4c1NO5YTf-ZAg3psDt-_FC27LJI=@protonmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tssho3rsprjbdjo2" Content-Disposition: inline In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: wuOxkh2C+uNK --tssho3rsprjbdjo2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thanks for your patch! The repository includes man pages, but the built package doesn't. Interestingly, the man1 directory is there, it's just empty. Could you investigate why this happens? On Sat, Jun 13, 2020 at 09:51:29PM +0000, Thovthe wrote: > > > > I think that perl should be added as input, so that the #! line of > > > > qdirstat-cache-writer can be patched to refer to a perl in the stor= e. > > > > > > I'm leaving this for once I've moved qdirstat-cache-writer into a > > > separate package/output since this definition works for the essential > > > functionality. > > > > Ok. > > ------------------------- > > > > For bonus points, it might be nice to move qdirstat-cache-writer to= its > > > > own output since it is made to be run independently of QDirStat and= that > > > > way it could be installed without pulling in all the C++ and Graphi= cal > > > > dependencies. > > > > > > How do you think this should look? Would I make another output in this > > > qdirstat.scm? > > > > Yes, adding another output is what I was thinking. The bind package is = an > > example of this. >=20 > I've added some comments about this but right now I'm not interested in f= iguring > out how this package is built at a lower level since with this definition > provides the essential functionality and all tests pass. I don't think it makes much sense to separate it into another output, given that the data produced by the script would be consumed by qdirstat proper anyway. It does make sense, however, to include perl as an input. This makes the script work even though /usr/bin/perl doesn't exist on Guix System. > >From 159a4f8b44537c8b76db52b65cd9571962cb58e4 Mon Sep 17 00:00:00 2001 > From: Thovthe > Date: Sat, 13 Jun 2020 21:42:38 +0000 > Subject: [PATCH] gnu: Add qdirstat. >=20 > * gnu/packages/qdirstat.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. > --- > gnu/local.mk | 1 + > gnu/packages/qdirstat.scm | 49 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 50 insertions(+) > create mode 100644 gnu/packages/qdirstat.scm Applying this patch was a bit problematic. If you put your comments after the --- here and send the mail with git send-email (from the send-email output of the git package), it would get picked up automatically. Sending the patch as an attachment also works. However, pasting the patch into the message requires quite some fiddling with 'git am'... > diff --git a/gnu/packages/qdirstat.scm b/gnu/packages/qdirstat.scm > new file mode 100644 > index 0000000000..8188357855 > --- /dev/null > +++ b/gnu/packages/qdirstat.scm > @@ -0,0 +1,49 @@ > +(define-module (gnu packages qdirstat) > + #:use-module (gnu packages compression) > + #:use-module (gnu packages qt) > + #:use-module (guix build-system gnu) > + #:use-module (guix git-download) > + #:use-module (guix packages) > + #:use-module ((guix licenses) #:prefix license:)) Make sure to include the copyright header that's present in all other files. > +(define-public qdirstat > + (package > + (name "qdirstat") > + (version "1.6.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/shundhammer/qdirstat.git") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0q77a347qv1aka6sni6l03zh5jzyy9s74aygg554r73g01kxczpb"))= )) > + > + (outputs `("out")) ; "cache-writer" could be made an output There's no point in specifying OUTPUTS if we're going to use the default value. Regards, Jakub K=C4=85dzio=C5=82ka --tssho3rsprjbdjo2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl74k3gACgkQ4xWnWEYT FWTLUA/+PkJz7GjI6VxjT9OLRy7bwGXIGq0CRJ4e1HSe1Idkfc2xAn+fzhbsRE9A Tx5UeuHGQcWf0kuWJGS1wQ/aCp2+6I9QHsCGivjxEoqq5V7jrnnjGHCz3gJQ/e2r 6wUQ0uO7RMau+uaSYK/0LlNt1eATyO02EbGFv7eBbQ4KkhP3mVocQ52TEv6+1aq9 uQn1UBJGqZ9DJqhCdou6kaGVzxaeUQv1Fy30mYAUPRLkFpdHZM6ZdWfv58gLCKTi ciXINDGLxtikhW4Ab3863AXpgJ6AYu3JijM5yFLjd3D2FzJFMUcsLSfnPxRf6WbO QSYNlTj+fOT+Kph5L9F7Zh2nwuuBsvsZIi+1bKrNDl5teWsRngckOeBZp1+r5rvS eneSIMZd4I+6xXuRIGkh1iv76CApnOVqKSprkab7VuGsdTNv2iS2iHecMdp5AD7b a3AcxgG1ayYToqa1hb10FiD3dQ7bNyxzCAXrNgLVt+UZukDaapUuTP8MikSdIBnK EAiMDVVdA5rpJGGTQnT+qIAW/Bx8g76cZ7Rk2MhIejCkNuci1VyfD5V0xfuENVok okpK1IrHSD3AG5ORnfXFXcVkLUiggdlI3v7frd2/pdoz0tmZnJi4sEZSIinmxTLz 25vkXO0PQBWeRV7zaRclbURp3K9GtgBHsZiTptoLueOg7JE60dU= =k9dq -----END PGP SIGNATURE----- --tssho3rsprjbdjo2--