From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0Ae3IM+D914VKQAA0tVLHw (envelope-from ) for ; Sat, 27 Jun 2020 17:37:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id VV6LHM+D916adAAA1q6Kng (envelope-from ) for ; Sat, 27 Jun 2020 17:37:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB3DC940308 for ; Sat, 27 Jun 2020 17:37:18 +0000 (UTC) Received: from localhost ([::1]:49630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpElQ-0004YU-Ms for larch@yhetil.org; Sat, 27 Jun 2020 13:37:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpElC-0004Y9-Pm for guix-patches@gnu.org; Sat, 27 Jun 2020 13:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpElC-0002TG-GO for guix-patches@gnu.org; Sat, 27 Jun 2020 13:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpElC-0000LN-D0 for guix-patches@gnu.org; Sat, 27 Jun 2020 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42089] [PATCH 0/1] gnu: icedtea-7: Update to 2.6.22. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Jun 2020 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42089 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42089@debbugs.gnu.org Cc: Simon South X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15932793811271 (code B ref -1); Sat, 27 Jun 2020 17:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2020 17:36:21 +0000 Received: from localhost ([127.0.0.1]:44548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpEkV-0000KP-QK for submit@debbugs.gnu.org; Sat, 27 Jun 2020 13:36:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:48298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpEkS-0000KG-Ha for submit@debbugs.gnu.org; Sat, 27 Jun 2020 13:36:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpEkS-0004Pq-B4 for guix-patches@gnu.org; Sat, 27 Jun 2020 13:36:16 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:55384) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpEkP-0002Jv-Oi for guix-patches@gnu.org; Sat, 27 Jun 2020 13:36:16 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id B13FFA0490; Sat, 27 Jun 2020 17:36:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IpiWb23v1i7C; Sat, 27 Jun 2020 17:36:11 +0000 (UTC) Received: from mars.simonsouth.net (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id B9FF6A0279; Sat, 27 Jun 2020 17:36:08 +0000 (UTC) From: Simon South Date: Sat, 27 Jun 2020 13:36:00 -0400 Message-Id: <20200627173600.1368133-1-simon@simonsouth.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/27 13:36:11 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 3.99 X-TUID: K9IalD8QwFFN This patch updates IcedTea 7 to version 2.6.22, which brings in a number of bugfixes. (I did this work originally hoping it would fix a build error on AArch64; it didn't and the solution lay elsewhere, but I figured I might as well finish and submit the change anyway.) It assumes the patches for issue 41871 (https://issues.guix.gnu.org/issue/41871) have already been applied, but doesn't depend on them. I've successfully built IcedTea 7 and 8 with this patch applied on x86_64 and (using additional patches) on AArch64. I've updated the URIs for the project's home page and source code to match what's current upstream. I've also taken the time to review the patching being done and bring it in-line with the updated source code, including fixing one case where "sh" was being replaced with "rm" (!). Importantly, I've changed the "--enable-bootstrap" configure option to "--disable-bootstrap". This seems correct to me (and I'm surprised it hasn't been an issue before) but am pointing it out in case there's something else here I'm missing. Without "--disable-bootstrap" this version of IcedTea 7 fails to build, with error messages like /tmp/guix-build-icedtea-2.6.22.drv-0/icedtea-2.6.22/generated.build/java/nio/ByteBuffer.java:1190: error: cannot find symbol return Byte.compare(x, y); ^ symbol: method compare(byte,byte) location: class Byte That makes sense, since this method was added in Java 1.7 and therefore won't be recognized by the Java 1.6 compiler (i.e. IcedTea 6) being used. And this seems to be what the option controls: Whether or not to assume an existing Java 1.7-compatible compiler is present. In fact IcedTea 7's instructions in INSTALL say To build IcedTea with an older version of IcedTea, use: ./autogen.sh ./configure --disable-bootstrap make So this seems to be both necessary and correct; I'm just not sure why it wasn't this way already. -- Simon South simon@simonsouth.net Simon South (1): gnu: icedtea-7: Update to 2.6.22. gnu/packages/java.scm | 70 +++++++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 32 deletions(-) -- 2.26.2