unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon South <simon@simonsouth.net>
To: 42089@debbugs.gnu.org
Cc: Simon South <simon@simonsouth.net>
Subject: [bug#42089] [PATCH 0/1] gnu: icedtea-7: Update to 2.6.22.
Date: Sat, 27 Jun 2020 13:36:00 -0400	[thread overview]
Message-ID: <20200627173600.1368133-1-simon@simonsouth.net> (raw)

This patch updates IcedTea 7 to version 2.6.22, which brings in a number of
bugfixes. (I did this work originally hoping it would fix a build error on
AArch64; it didn't and the solution lay elsewhere, but I figured I might as
well finish and submit the change anyway.)

It assumes the patches for issue 41871
(https://issues.guix.gnu.org/issue/41871) have already been applied, but
doesn't depend on them.

I've successfully built IcedTea 7 and 8 with this patch applied on x86_64 and
(using additional patches) on AArch64.

I've updated the URIs for the project's home page and source code to match
what's current upstream. I've also taken the time to review the patching being
done and bring it in-line with the updated source code, including fixing one
case where "sh" was being replaced with "rm" (!).

Importantly, I've changed the "--enable-bootstrap" configure option to
"--disable-bootstrap". This seems correct to me (and I'm surprised it hasn't
been an issue before) but am pointing it out in case there's something else
here I'm missing.

Without "--disable-bootstrap" this version of IcedTea 7 fails to build, with
error messages like

    /tmp/guix-build-icedtea-2.6.22.drv-0/icedtea-2.6.22/generated.build/java/nio/ByteBuffer.java:1190: error: cannot find symbol
	    return Byte.compare(x, y);
		       ^
      symbol:   method compare(byte,byte)
      location: class Byte

That makes sense, since this method was added in Java 1.7 and therefore won't
be recognized by the Java 1.6 compiler (i.e. IcedTea 6) being used. And this
seems to be what the option controls: Whether or not to assume an existing
Java 1.7-compatible compiler is present.

In fact IcedTea 7's instructions in INSTALL say

    To build IcedTea with an older version of IcedTea, use:
    ./autogen.sh
    ./configure --disable-bootstrap 
    make

So this seems to be both necessary and correct; I'm just not sure why it
wasn't this way already.

--
Simon South
simon@simonsouth.net


Simon South (1):
  gnu: icedtea-7: Update to 2.6.22.

 gnu/packages/java.scm | 70 +++++++++++++++++++++++--------------------
 1 file changed, 38 insertions(+), 32 deletions(-)

-- 
2.26.2





             reply	other threads:[~2020-06-27 17:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 17:36 Simon South [this message]
2020-06-27 17:39 ` [bug#42089] [PATCH 1/1] gnu: icedtea-7: Update to 2.6.22 Simon South

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200627173600.1368133-1-simon@simonsouth.net \
    --to=simon@simonsouth.net \
    --cc=42089@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).