From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41753-done@debbugs.gnu.org
Subject: bug#41753: [PATCH] gnu: Add tup.
Date: Mon, 15 Jun 2020 00:15:37 +0200 [thread overview]
Message-ID: <20200614221537.w3d5leewtpf5e4gj@gravity> (raw)
In-Reply-To: <87imfts6u8.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Sun, Jun 14, 2020 at 10:58:07PM +0200, Ludovic Courtès wrote:
> Hi,
>
> Jakub Kądziołka <kuba@kadziolka.net> skribis:
>
> > * gnu/packages/build-tools.scm (tup): New variable.
> > * gnu/packages/patches/tup-unbundle-dependencies.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Register new file.
>
> [...]
>
> > --- /dev/null
> > +++ b/gnu/packages/patches/tup-unbundle-dependencies.patch
> > @@ -0,0 +1,74 @@
> > +From 895a7d4e8200f9430414a5fe47756efb67d2e5d0 Mon Sep 17 00:00:00 2001
> > +From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
> > +Date: Sun, 7 Jun 2020 15:14:42 +0200
> > +Subject: [PATCH] Unbundle dependencies
> > +
> > +---
> > + build.sh | 10 ++++------
> > + src/tup/db.c | 2 +-
> > + src/tup/tupid.h | 2 +-
> > + 3 files changed, 6 insertions(+), 8 deletions(-)
>
> Nitpick: I’d remove the whole Git header and just keep the subject.
>
> Otherwise LGTM!
Thanks for the review! I have pushed a revised patch as commit
2c1d1b7599a3738cdbdcaa281d56fa47b0b4c025.
Regards,
Jakub Kądziołka
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-06-14 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 19:07 [bug#41753] [PATCH] gnu: Add tup Jakub Kądziołka
2020-06-14 20:58 ` Ludovic Courtès
2020-06-14 22:15 ` Jakub Kądziołka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614221537.w3d5leewtpf5e4gj@gravity \
--to=kuba@kadziolka.net \
--cc=41753-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).