From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MCA+OgDe3V5QOQAA0tVLHw (envelope-from ) for ; Mon, 08 Jun 2020 06:43:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MH7zNQDe3V7XcwAAbx9fmQ (envelope-from ) for ; Mon, 08 Jun 2020 06:43:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C53794013C for ; Mon, 8 Jun 2020 06:43:12 +0000 (UTC) Received: from localhost ([::1]:53422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiBUz-0007Jp-JM for larch@yhetil.org; Mon, 08 Jun 2020 02:43:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiBUs-0007JV-Ov for guix-patches@gnu.org; Mon, 08 Jun 2020 02:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiBUs-0000Fk-F0 for guix-patches@gnu.org; Mon, 08 Jun 2020 02:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jiBUs-0004nh-Cq for guix-patches@gnu.org; Mon, 08 Jun 2020 02:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41720] [PATCH] store: Use buffered I/O for all protocol writes Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Jun 2020 06:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41720 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 41720@debbugs.gnu.org Received: via spool by 41720-submit@debbugs.gnu.org id=B41720.159159855718413 (code B ref 41720); Mon, 08 Jun 2020 06:43:02 +0000 Received: (at 41720) by debbugs.gnu.org; 8 Jun 2020 06:42:37 +0000 Received: from localhost ([127.0.0.1]:55798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiBUT-0004mu-Lw for submit@debbugs.gnu.org; Mon, 08 Jun 2020 02:42:37 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:46926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiBUR-0004mb-Ni for 41720@debbugs.gnu.org; Mon, 08 Jun 2020 02:42:36 -0400 Received: by mail-ej1-f67.google.com with SMTP id e2so16924740eje.13 for <41720@debbugs.gnu.org>; Sun, 07 Jun 2020 23:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leibniz-psychology-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=raAstWu4KD5rTFxoeKRofHnEv5q45XMnNBuwaBD4yQI=; b=RcRX/UpX+dN+esFTfY3ItIXl9omD0OKId6vuqs32dhnts5/ljiafa4vs1amCWp2J7I awFubb75xkxqfqTolUAREoEjJVB80c0tuF39nH69S3JMreAz2Ame3N9N8v9uZcgFaD6X An1H7kpMt1pNL4We4oochOJ/4nCE/fLR5GXwacHQsGpZ2N4rkUvkwtI521luAIizvX23 ZT5pA9Z34SLM68IJXh4SmTRk9bHnZqP0yhtWc9RKKQmHUeGkn/k7gv66dJqDUc/TcDSB WPgLaViC/fdzDT/1Y+pjfJ/dTKVzOcTDVSxxWg5qMyU0lOx3mi5FCN8qcR69Y8QqkL/R pz5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=raAstWu4KD5rTFxoeKRofHnEv5q45XMnNBuwaBD4yQI=; b=nvnWy6z0meCASwmJzhbzjpcaufhiXqLbvsJ4thJ++xLs9rNqSp463jHyfPMpMhM41K STxDIyEgT1QiKHD3dl0eamEI4m3zeUmghtWpE6X3lV6K2x6cA28/zzWWF8FiMzEjP7v/ dIDR8mwVHnNy8XFfPQCmZITFIurVHCq+8SF01IBNzMxJAJ9/TJHQNoOXM7Mdhv8sLDX0 hsdElqNhW4HfL1w0EFxjMIgSJFHih/wXCHD5eRLdoMrlv1ELJCaft5G7IM/Jw2PrFnb5 D7qj4lLAJ6WqqG0t3KI/LQIQZIoCquw2LlNPcvNqzc+LoDhSmyNFFNPAAksYdqlZ7GvP Wj3w== X-Gm-Message-State: AOAM533496DRad0Jap/+AO7KI8zI9IhBCMUPYM37cIM0B8i4lW3Ec+Fa Eu37LShZcUNDQWM8cdR5/0hONO+nora65y0GKHr9LrVFAKzmhpOr72EuqAdgYhx3Jm1Yb8Hm9iO hop2qIO+LCycX2ZGKr6uXstDiqFBebQdvkdVfK2mkqzGjbbnJeoxxd/4t8cEw+SVTZfX6cgnkNK 8bsM0= X-Google-Smtp-Source: ABdhPJzdnqdbg76RBI2QrjLZ+BHdRAbC6KDIqTLQTXwU/K1X5YzRdLTLM61bAqGRS8SxZ9I+1lj8PA== X-Received: by 2002:a17:906:768e:: with SMTP id o14mr20243746ejm.497.1591598549639; Sun, 07 Jun 2020 23:42:29 -0700 (PDT) Received: from localhost (dynamic-2a01-0c22-d48d-f900-f58e-6c44-3fc3-d82c.c22.pool.telefonica.de. [2a01:c22:d48d:f900:f58e:6c44:3fc3:d82c]) by smtp.gmail.com with ESMTPSA id q12sm10019343ejn.23.2020.06.07.23.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2020 23:42:28 -0700 (PDT) Date: Mon, 8 Jun 2020 08:42:28 +0200 From: Lars-Dominik Braun Message-ID: <20200608064228.GB3166@zpidnp36> References: <20200605091151.GB3225@zpidnp36> <875zc5xkoh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XF85m9dhOBO43t/C" Content-Disposition: inline In-Reply-To: <875zc5xkoh.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=leibniz-psychology-org.20150623.gappssmtp.com header.s=20150623 header.b=RcRX/UpX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: FxAqPe+5t+bm --XF85m9dhOBO43t/C Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ludo, > Nice, though the slowdown on Unix-domain sockets is annoying given that > it=E2=80=99s the primary transport. Are the 10% significant and stable o= ver > multiple runs? I don=E2=80=99t want to blind your eyes with meaningless statistics here, b= ut let=E2=80=99s do this properly then. So for `guix environment guix -- true` with 10 trials t= hese are the results: ---snip--- $ ministat -A -c 99 before_ssh after_ssh x before_ssh + after_ssh N Min Max Median Avg Stddev x 10 7.63 10.635 10.1585 9.9382 0.85517585 + 10 5.986 6.424 6.1755 6.1917 0.15398416 Difference at 99.0% confidence -3.7465 +/- 0.790815 -37.698% +/- 5.0788% (Student's t, pooled s =3D 0.614425) $ ministat -A -c 99 before_unix after_unix x before_unix + after_unix N Min Max Median Avg Stddev x 10 1.528 1.624 1.5445 1.5636 0.035842867 + 10 1.576 1.701 1.6145 1.6229 0.037869513 Difference at 99.0% confidence 0.0593 +/- 0.0474548 3.79253% +/- 3.08989% (Student's t, pooled s =3D 0.0368701) ---snap--- And the same for `guix environment --ad-hoc r-learnr`: ---snip--- $ ministat -A -c 99 before_ssh after_ssh x before_ssh + after_ssh N Min Max Median Avg Stddev x 10 20.104 21.629 21.082 21.0115 0.45142472 + 10 16.082 16.713 16.292 16.3416 0.25018224 Difference at 99.0% confidence -4.6699 +/- 0.469719 -22.2254% +/- 1.86734% (Student's t, pooled s =3D 0.364949) $ ministat -A -c 99 before_unix after_unix x before_unix + after_unix N Min Max Median Avg Stddev x 10 11.322 11.529 11.401 11.4127 0.062467858 + 10 11.249 11.469 11.3515 11.368 0.078689262 No difference proven at 99.0% confidence ---snap--- > Otherwise the patch LGTM as long as it doesn=E2=80=99t introduce any test= suite > regressions. Yes, it passes the test suite. Lars --XF85m9dhOBO43t/C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl7d3dAACgkQQhN3ARo3 hEYkJAv/XGCQySywDtYuQLK2yAKLZvGo27Y6RQ0RiqR1C16Xvcf9h1V3BzuL7zg7 1DGSY4dgExUIKNVXE7TnzD6/Ulg1qNcMunnsWRLnZX/pRVmqWtc7/jHrfxsuPHd4 Guevj+QIWT2kC1Dtj+eTKGJVodDr9BLTfJmWh8orLMOeWCB9dtDmrfWX1DLKdsMH P1IzOEmRlrE4CS0syqD1F/5yKueT6sAvjSqeQ5aQfJZr1ecGwJZ+xFmxfS1kwnSU OWAfJ+pOHKyeZIL5DMYGIem+CtUHBlXZf6rhSmNhS2aCOYFzcSDZfR/nAcCMyzJR m4F9mZQp+38C8ljXYR3UwUeWHguwjDwMFFI2p0kAsD2FigFuYWP7z2BpfuTPWxiJ CnIjRHBgxTAmXUoZfI/tDqX9MzrjX2bPN04Eiqm9+z14Tluq45BmnnMCLOEZBfy4 +nShsaKXerTBqr4LpyYzD11uRiPsO/22QC95Y1S848bWisEkFuh6mCA+8RN9N+6s dNqqHMXJ =KYN5 -----END PGP SIGNATURE----- --XF85m9dhOBO43t/C--