From: Danny Milosavljevic <dannym@scratchpost.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 41643-done@debbugs.gnu.org
Subject: bug#41643: [PATCH] build-system: linux-module: Allow passing #:make-flags argument.
Date: Tue, 2 Jun 2020 14:22:59 +0200 [thread overview]
Message-ID: <20200602142259.48258e27@scratchpost.org> (raw)
In-Reply-To: <87zh9lx2gj.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
It only works as the last argument on "apply". Using quasiquote for this would
be a little over-the-top.
Also, almost all the other build system, even the ones using quasiquote, also
pass them at the end of the argument list. Just scons-build-system doesn't at
one single place of multiple, and meson-build-system doesn't with
configure-flags.
I'm not opposed to doing it like you suggest, but let's do it for all the
build systems in an extra patch.
Pushed to guix master as commit f51fd97ec54a98668d63c52d8a6bd75d8dc3292e.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-06-02 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 12:59 [bug#41643] [PATCH] build-system: linux-module: Allow passing #:make-flags argument Danny Milosavljevic
2020-06-02 9:05 ` Mathieu Othacehe
2020-06-02 12:22 ` Danny Milosavljevic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602142259.48258e27@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=41643-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).