From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: tsmish <tsymsh@gmail.com>
Cc: 41151-done@debbugs.gnu.org
Subject: bug#41151: [PATCH] gnu: vis: Fix #39394
Date: Mon, 1 Jun 2020 15:44:13 +0200 [thread overview]
Message-ID: <20200601134413.m65s76owjlhlqg5e@gravity> (raw)
In-Reply-To: <CAMaATaNQBPNbx6GGcnSgR5h1C6s2CpOsSEYscTWTMRKn-cPQwA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
On Sat, May 09, 2020 at 03:51:53PM +0000, tsmish wrote:
> There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
> (#define), which is also in search path
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
> is already set by Makefile to $prefix/share/vis
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).
Thanks for the patch! We usually avoid putting a bug number as the only
information in the commit title, so I took the liberty to rewrite the
commit message a bit:
commit 5b588f2c9ba9c40dc32aed7c3cdaa45e8f920509 (HEAD -> master, upstream/master)
Author: tsmish <tsymsh@gmail.com>
Date: Sat May 9 15:51:53 2020 +0000
gnu: vis: Fix configuration load order.
* gnu/packages/text-editors.scm (vis)[native-search-paths]: Remove.
There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
(#define), which is also in search path
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
is already set by Makefile to $prefix/share/vis
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).
This fixes issue https://issues.guix.gnu.org/39394
Signed-off-by: Jakub Kądziołka <kuba@kadziolka.net>
Cheers!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-06-01 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 15:51 [bug#41151] [PATCH] gnu: vis: Fix #39394 tsmish
2020-06-01 13:44 ` Jakub Kądziołka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601134413.m65s76owjlhlqg5e@gravity \
--to=kuba@kadziolka.net \
--cc=41151-done@debbugs.gnu.org \
--cc=tsymsh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).