* [bug#41610] [PATCH] gnu: glade3: Enable tests.
@ 2020-05-29 21:31 Arun Isaac
2020-06-14 10:25 ` Mathieu Othacehe
0 siblings, 1 reply; 3+ messages in thread
From: Arun Isaac @ 2020-05-29 21:31 UTC (permalink / raw)
To: 41610; +Cc: Arun Isaac
* gnu/packages/gnome.scm (glade3)[arguments]: Enable tests. Add custom
pre-check phase.
[native-inputs]: Add hicolor-icon-theme and xorg-server-for-tests.
---
gnu/packages/gnome.scm | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1745bf7906..02e14233d1 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2102,8 +2102,7 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
"023gx8rj51njn8fsb6ma5kz1irjpxi4js0n8rwy22inc4ysldd8r"))))
(build-system glib-or-gtk-build-system)
(arguments
- `(#:tests? #f ; needs X, GL, and software rendering
- #:phases
+ `(#:phases
(modify-phases %standard-phases
(add-before 'configure 'fix-docbook
(lambda* (#:key inputs #:allow-other-keys)
@@ -2113,18 +2112,27 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
"/xml/xsl/docbook-xsl-"
,(package-version docbook-xsl)
"/manpages/docbook.xsl")))
+ #t))
+ (add-before 'check 'pre-check
+ (lambda _
+ (setenv "HOME" "/tmp")
+ ;; Tests require a running X server.
+ (system "Xvfb :1 &")
+ (setenv "DISPLAY" ":1")
#t)))))
(inputs
`(("gtk+" ,gtk+)
("libxml2" ,libxml2)))
(native-inputs
- `(("intltool" ,intltool)
+ `(("hicolor-icon-theme" ,hicolor-icon-theme)
+ ("intltool" ,intltool)
("itstool" ,itstool)
("libxslt" ,libxslt) ;for xsltproc
("docbook-xml" ,docbook-xml-4.2)
("docbook-xsl" ,docbook-xsl)
("python" ,python-2)
- ("pkg-config" ,pkg-config)))
+ ("pkg-config" ,pkg-config)
+ ("xorg-server" ,xorg-server-for-tests)))
(home-page "https://glade.gnome.org")
(synopsis "GTK+ rapid application development tool")
(description "Glade is a rapid application development (RAD) tool to
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#41610] [PATCH] gnu: glade3: Enable tests.
2020-05-29 21:31 [bug#41610] [PATCH] gnu: glade3: Enable tests Arun Isaac
@ 2020-06-14 10:25 ` Mathieu Othacehe
2020-06-15 18:40 ` bug#41610: " Arun Isaac
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2020-06-14 10:25 UTC (permalink / raw)
To: Arun Isaac; +Cc: 41610
Hello Arun,
> - ("pkg-config" ,pkg-config)))
> + ("pkg-config" ,pkg-config)
> + ("xorg-server" ,xorg-server-for-tests)))
> (home-page "https://glade.gnome.org")
> (synopsis "GTK+ rapid application development tool")
> (description "Glade is a rapid application development (RAD) tool to
This looks fine, please go ahead!
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#41610: [PATCH] gnu: glade3: Enable tests.
2020-06-14 10:25 ` Mathieu Othacehe
@ 2020-06-15 18:40 ` Arun Isaac
0 siblings, 0 replies; 3+ messages in thread
From: Arun Isaac @ 2020-06-15 18:40 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 41610-done
[-- Attachment #1: Type: text/plain, Size: 32 bytes --]
Pushed, thanks for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-15 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-29 21:31 [bug#41610] [PATCH] gnu: glade3: Enable tests Arun Isaac
2020-06-14 10:25 ` Mathieu Othacehe
2020-06-15 18:40 ` bug#41610: " Arun Isaac
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).