unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: John Soo <jsoo1@asu.edu>
Cc: 40557@debbugs.gnu.org
Subject: [bug#40557] [PATCH] Add dhall.
Date: Thu, 28 May 2020 21:50:42 -0400	[thread overview]
Message-ID: <20200529015042.GJ5443@jasmine.lan> (raw)
In-Reply-To: <87r1wuqa9h.fsf@asu.edu>

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Sat, Apr 11, 2020 at 09:04:26AM -0700, John Soo wrote:
> Hi Guix!
> 
> Dhall is a language for configuration that aims to be the best in class
> for devops work.  It features strong normalization, strong static types,
> imports, and more.
> 
> I hope you enjoy it!

Thanks! The first 24 patches LGTM as-is.

> From 97163f01cb31dd70e09e0245630d1f7babe5251c Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Fri, 10 Apr 2020 21:01:46 -0700
> Subject: [PATCH 25/25] gnu: Add dhall.
> 
> * gnu/packages/dhall.scm (dhall): New variable.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add dhall.scm.
> * gnu/packages/patches/dhall-remove-network-tests.patch: Add patch to remove
>   network tests.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'remove-more-tests

Can you add a brief comment explaining why we need to remove these
tests, rename the phase to reflect that, and send a revised patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-29  1:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11 16:04 [bug#40557] [PATCH] Add dhall John Soo
2020-05-29  1:50 ` Leo Famulari [this message]
2020-05-29 13:40   ` John Soo
2020-05-29 15:01     ` bug#40557: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529015042.GJ5443@jasmine.lan \
    --to=leo@famulari.name \
    --cc=40557@debbugs.gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).