unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 40471-done@debbugs.gnu.org
Subject: bug#40471: [PATCH] gnu: Add lsp-plugins.
Date: Wed, 27 May 2020 12:25:08 +0300	[thread overview]
Message-ID: <20200527092508.GA10771@E5400> (raw)
In-Reply-To: <4df3ebd1eb7b6bfbdac5f4840e13756427ca0a8f.camel@zrythm.org>

[-- Attachment #1: Type: text/plain, Size: 3338 bytes --]

Patched pushed with a few changes:

On Wed, May 27, 2020 at 01:06:38AM +0100, Alexandros Theodotou wrote:
> Fixed! The failure was due to the lv2 upgrade. The upstream has fixed
> this in the new release.
> 
> See new patch attached.
> 
> Thanks,
> Alex
> 
> On Wed, 2020-05-06 at 22:55 +0300, Efraim Flashner wrote:
> > This actually failed to build for me, even when I bumped the version
> > up
> > to 1.1.19. Can you take a look at it?
> > 
> > Thanks
> > 
> > 

> From b3aa2ea22bc2be15a7ab11c792ea85a1ec3900d6 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Wed, 27 May 2020 01:04:42 +0100
> Subject: [PATCH] gnu: Add lsp-plugins.
> 
> * gnu/packages/music.scm (lsp-plugins): new variable.
> ---
>  gnu/packages/music.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 2c6be8eba8..f01978d118 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -4863,6 +4863,49 @@ effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
>  and reverb.")
>      (license license:gpl2+)))
>  
> +(define-public lsp-plugins
> +  (package
> +    (name "lsp-plugins")
> +    (version "1.1.21")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/sadko4u/lsp-plugins.git")
> +               (commit (string-append "lsp-plugins-" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "1zw0iip6ki9k65kh8dp53x7l4va4mi5rj793n2yn4p9y84qzwrz9"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags

I changed the CC=gcc line so that it can cross compile

> +       (list "CC=gcc" "BUILD_MODULES=\"lv2 ladspa jack\"" "VST_UI=0"
> +             (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +             (string-append "ETC_PATH=" (assoc-ref %outputs "out") "/etc"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure

I changed this to a #:test-flag

> +         (replace 'check
> +           (lambda _
> +             (invoke "make" "test"))))))

And I re-indented so that the ` was under the 'i' in inputs.
Same with native-inputs.

> +    (inputs
> +      `(("cairo", cairo)
> +        ("hicolor-icon-theme", hicolor-icon-theme)
> +        ("jack", jack-1)
> +        ("ladspa", ladspa)
> +        ("libsndfile", libsndfile)
> +        ("lv2", lv2)
> +        ("mesa", mesa)))
> +    (native-inputs
> +      `(("pkg-config", pkg-config)))
> +    (synopsis "Audio plugin collection")
> +    (description "LSP (Linux Studio Plugins) is a collection of audio
> +plugins available as LADSPA/LV2 plugins and as standalone JACK
> +applications.")
> +    (home-page "https://lsp-plug.in/")
> +    (license license:lgpl3)))
> +
>  (define-public sherlock-lv2
>    (package
>      (name "sherlock-lv2")
> -- 
> 2.26.2
> 




-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-05-27  9:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 15:08 [bug#40471] [PATCH] gnu: Add lsp-plugins Alexandros Theodotou
2020-04-07 20:08 ` Alexandros Theodotou
2020-05-06 19:55   ` Efraim Flashner
2020-05-27  0:06     ` Alexandros Theodotou
2020-05-27  9:25       ` Efraim Flashner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200527092508.GA10771@E5400 \
    --to=efraim@flashner.co.il \
    --cc=40471-done@debbugs.gnu.org \
    --cc=alex@zrythm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).