From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Fep4DQvzxF6AFAAA0tVLHw (envelope-from ) for ; Wed, 20 May 2020 09:06:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8IatCAvzxF5CTgAAbx9fmQ (envelope-from ) for ; Wed, 20 May 2020 09:06:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0B0594038F for ; Wed, 20 May 2020 09:06:18 +0000 (UTC) Received: from localhost ([::1]:43322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbKg5-00006x-NK for larch@yhetil.org; Wed, 20 May 2020 05:06:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbKfq-0008Nt-9I for guix-patches@gnu.org; Wed, 20 May 2020 05:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbKfq-00036a-0J for guix-patches@gnu.org; Wed, 20 May 2020 05:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbKfp-0000eF-QM for guix-patches@gnu.org; Wed, 20 May 2020 05:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41411] gnu: gnurl: Update to 7.70.0 Resent-From: Nikita Gillmann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 May 2020 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41411 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ricardo Wurmus Cc: Nikita Gillmann , 41411@debbugs.gnu.org Received: via spool by 41411-submit@debbugs.gnu.org id=B41411.15899655342454 (code B ref 41411); Wed, 20 May 2020 09:06:01 +0000 Received: (at 41411) by debbugs.gnu.org; 20 May 2020 09:05:34 +0000 Received: from localhost ([127.0.0.1]:52275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbKfN-0000dW-Qm for submit@debbugs.gnu.org; Wed, 20 May 2020 05:05:34 -0400 Received: from aibo.runbox.com ([91.220.196.211]:58438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbKfL-0000dM-8F for 41411@debbugs.gnu.org; Wed, 20 May 2020 05:05:31 -0400 Received: from [10.9.9.204] (helo=mailfront22.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1jbKfH-0002NN-VE; Wed, 20 May 2020 11:05:28 +0200 Received: by mailfront22.runbox with esmtpsa [Authenticated alias (924257)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1jbKez-0004zO-Qs; Wed, 20 May 2020 11:05:09 +0200 Date: Wed, 20 May 2020 11:05:08 +0200 From: Nikita Gillmann Message-ID: <20200520090508.wc5rac3islnxy6se@hex> References: <20200519221714.qywwmiyq6zivfrjb@hex> <87a723fmtd.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a723fmtd.fsf@elephly.net> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=n0.is (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.41 X-TUID: aSzWebkgkv0u Ricardo Wurmus transcribed 0.6K bytes: > > > runtests.pl: > > In the environment of guix, $USER is unset. > > > > # get the name of the current user > > my $USER = $ENV{USER}; # Linux > > if (!$USER) { > > $USER = $ENV{USERNAME}; # Windows > > if (!$USER) { > > $USER = $ENV{LOGNAME}; # Some Unix (I think) > > } > > } > > > > > > leads to $USER being uninitialized at some point (around line 3600 or > > something further below, grep for it). The tests loudly complain to the > > log but it's not fatal. > > What is the USER variable used for? If it’s not needed why set it at all? I did some reading in runtests.pl and then sshserver.pl. My perl knowledge isn't that good but from what I can gather the main reason it exists is so that sshserver.pl can check if the arguments passed to it and the env do not result in user root starting an ssh server. Most tests run with predefined user, and runtests.pl seems to do some substition with $USER when it's in the environment. Since gnurl does not build with ssh enabled I assume the ssh tests are unnecessary anyway (if they are run at all), so a fallback to 'Anonymous' (like most tests which set this user) should be free of unexpected side-effects. > -- > Ricardo