[bug#41411] gnu: gnurl: Update to 7.70.0

[bug#41411] gnu: gnurl: Update to 7.70.0

[Nikita Gillmann]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

This updates gnurl to version 7.70.0.

Something to consider (for gnurl and curl):
While all tests pass, gnurl and curl want the python module "impacket"
for some tests since bundled impacket got removed.

runtests.pl:
In the environment of guix, $USER is unset.

# get the name of the current user
my $USER = $ENV{USER};          # Linux
if (!$USER) {
    $USER = $ENV{USERNAME};     # Windows
    if (!$USER) {
        $USER = $ENV{LOGNAME};  # Some Unix (I think)
    }
}


leads to $USER being uninitialized at some point (around line 3600 or
something further below, grep for it). The tests loudly complain to the
log but it's not fatal.
Can I (as gnurl upstream) set a fallback value like "Anonymous" in the
next release, or what's your take on this?

[-- Attachment #2: 0001-gnu-gnurl-Update-to-7.70.0.patch --]
[-- Type: text/plain, Size: 1702 bytes --]

From 2a2da39e5139a41b0a96531f9919e0225ac02ea4 Mon Sep 17 00:00:00 2001
From: nikita <nikita@n0.is>
Date: Wed, 20 May 2020 00:06:05 +0200
Subject: [PATCH] gnu: gnurl: Update to 7.70.0.

* gnu/packages/gnunet.scm (gnurl): Update to 7.70.0.
---
 gnu/packages/gnunet.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 1b7ea9246c..27fb39fb8b 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2015, 2017, 2019, 2020 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2016 Mark H Weaver <mhw@netris.org>
-;;; Copyright © 2016, 2017, 2018, 2019 Nikita <nikita@n0.is>
+;;; Copyright © 2016, 2017, 2018, 2019, 2020 Nikita <nikita@n0.is>
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
 ;;; Copyright © 2019 Brett Gilio <brettg@gnu.org>
@@ -180,13 +180,13 @@ authentication and support for SSL3 and TLS.")
 (define-public gnurl
   (package
    (name "gnurl")
-   (version "7.69.1")
+   (version "7.70.0")
    (source (origin
             (method url-fetch)
             (uri (string-append "mirror://gnu/gnunet/gnurl-" version ".tar.gz"))
             (sha256
              (base32
-              "0x8m26y3klndis6a28j8i0b7ab04d38q3rmlvgaqa65bjhlfdrp0"))))
+              "0px9la8v4bj1dzxb95fx3yxk0rcjqjrxpj733ga27cza45wwzkqa"))))
    (build-system gnu-build-system)
    (outputs '("out"
               "doc"))                             ; 1.8 MiB of man3 pages
-- 
2.25.2

[bug#41411] gnu: gnurl: Update to 7.70.0

[Ricardo Wurmus]

> runtests.pl:
> In the environment of guix, $USER is unset.
>
> # get the name of the current user
> my $USER = $ENV{USER};          # Linux
> if (!$USER) {
>     $USER = $ENV{USERNAME};     # Windows
>     if (!$USER) {
>         $USER = $ENV{LOGNAME};  # Some Unix (I think)
>     }
> }
>
>
> leads to $USER being uninitialized at some point (around line 3600 or
> something further below, grep for it). The tests loudly complain to the
> log but it's not fatal.

What is the USER variable used for?  If it’s not needed why set it at all?

-- 
Ricardo

[bug#41411] gnu: gnurl: Update to 7.70.0

[Nikita Gillmann]

Ricardo Wurmus transcribed 0.6K bytes:
> 
> > runtests.pl:
> > In the environment of guix, $USER is unset.
> >
> > # get the name of the current user
> > my $USER = $ENV{USER};          # Linux
> > if (!$USER) {
> >     $USER = $ENV{USERNAME};     # Windows
> >     if (!$USER) {
> >         $USER = $ENV{LOGNAME};  # Some Unix (I think)
> >     }
> > }
> >
> >
> > leads to $USER being uninitialized at some point (around line 3600 or
> > something further below, grep for it). The tests loudly complain to the
> > log but it's not fatal.
> 
> What is the USER variable used for?  If it’s not needed why set it at all?

I did some reading in runtests.pl and then sshserver.pl. My perl knowledge
isn't that good but from what I can gather the main reason it exists is so
that sshserver.pl can check if the arguments passed to it and the env do not
result in user root starting an ssh server.
Most tests run with predefined user, and runtests.pl seems to do some
substition with $USER when it's in the environment. Since gnurl does not build
with ssh enabled I assume the ssh tests are unnecessary anyway (if they are
run at all), so a fallback to 'Anonymous' (like most tests which set this user)
should be free of unexpected side-effects.

> -- 
> Ricardo

bug#41411: gnu: gnurl: Update to 7.70.0

[Ludovic Courtès]

Hi Nikita,

Nikita Gillmann <nikita@n0.is> skribis:

> From 2a2da39e5139a41b0a96531f9919e0225ac02ea4 Mon Sep 17 00:00:00 2001
> From: nikita <nikita@n0.is>
> Date: Wed, 20 May 2020 00:06:05 +0200
> Subject: [PATCH] gnu: gnurl: Update to 7.70.0.
>
> * gnu/packages/gnunet.scm (gnurl): Update to 7.70.0.

Applied, thanks!

BTW, the home page is now 404.

Ludo’.